From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754734AbcGEKuZ (ORCPT ); Tue, 5 Jul 2016 06:50:25 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34302 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751835AbcGEKuV (ORCPT ); Tue, 5 Jul 2016 06:50:21 -0400 Subject: Re: [PATCH 1/5] mmu: mark spte present if the x bit is set To: Wanpeng Li References: <1467088360-10186-1-git-send-email-bsd@redhat.com> <1467088360-10186-2-git-send-email-bsd@redhat.com> <55601232-c941-74e8-f740-fd09e9e8a6ae@redhat.com> <70de38d1-2743-09dd-dc47-6242799a701c@redhat.com> Cc: Bandan Das , kvm , guangrong.xiao@linux.intel.com, "linux-kernel@vger.kernel.org" From: Paolo Bonzini Message-ID: <862bf835-7937-5118-eafb-12adb3d1e7d3@redhat.com> Date: Tue, 5 Jul 2016 12:50:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/07/2016 05:06, Wanpeng Li wrote: > 2016-06-29 4:49 GMT+08:00 Paolo Bonzini : > [...] >> >> I think another way to write it is "(pte & 0xFFFFFFFFull) && >> !is_mmio_spte(pte)", since non-present/non-MMIO SPTEs never use bits > > I misunderstand it here, this will also treat -W- EPT SPTEs as present, right? -W- EPT SPTEs are present but invalid. They should never happen unless they are MMIO SPTEs (in which case !is_mmio_spte(pte) will return true and the function will return false). Paolo > Regards, > Wanpeng Li > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >