From: "Thomas Weißschuh" <linux@weissschuh.net>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@infradead.org>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v3 0/3] blk-integrity: drop integrity_kobj from gendisk
Date: Thu, 27 Apr 2023 01:12:42 +0200 [thread overview]
Message-ID: <862c1901-ee6e-44e5-8906-4bb1c3893372@t-8ch.de> (raw)
In-Reply-To: <yq1v8ivtzrn.fsf@ca-mkp.ca.oracle.com>
Hi Martin, Christoph, Jens,
On 2023-03-20 07:56:58-0400, Martin K. Petersen wrote:
> > The embedded member integrity_kobj member of struct gendisk violates
> > the assumption of the driver core that only one struct kobject should
> > be embedded into another object and then manages its lifetime.
> >
> > As the integrity_kobj is only used to hold a few sysfs attributes it
> > can be replaced by direct device_attributes and removed.
>
> Looks good to me and passed a quick test on a couple of systems. Thanks
> for cleaning this up!
>
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Am I getting some part of the process for block/ wrong?
It seems my patches for the block subsystem are having a hard time
getting merged.
* https://lore.kernel.org/all/20221110052438.2188-1-linux@weissschuh.net/
* this series
* https://lore.kernel.org/all/20230419-const-partition-v2-0-817b58f85cd1@weissschuh.net/
Thanks for any pointers,
Thomas
next prev parent reply other threads:[~2023-04-26 23:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 17:36 Thomas Weißschuh
2023-03-18 17:36 ` [PATCH v3 1/3] blk-integrity: use sysfs_emit Thomas Weißschuh
2023-03-20 6:14 ` Christoph Hellwig
2023-03-18 17:36 ` [PATCH v3 2/3] blk-integrity: convert to struct device_attribute Thomas Weißschuh
2023-03-20 6:14 ` Christoph Hellwig
2023-03-18 17:36 ` [PATCH v3 3/3] blk-integrity: register sysfs attributes on struct device Thomas Weißschuh
2023-03-20 6:15 ` Christoph Hellwig
2023-03-20 11:56 ` [PATCH v3 0/3] blk-integrity: drop integrity_kobj from gendisk Martin K. Petersen
2023-04-26 23:12 ` Thomas Weißschuh [this message]
2023-04-27 0:26 ` Jens Axboe
2023-04-27 6:00 ` Thomas Weißschuh
2023-04-27 0:26 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=862c1901-ee6e-44e5-8906-4bb1c3893372@t-8ch.de \
--to=linux@weissschuh.net \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®