From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 757AE40BCC2 for ; Mon, 3 Aug 2026 13:09:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785762552; cv=none; b=IQSvwZAz1OHNiTutU/MATRjx8Db7VnbXeJDiv+9b1HvU2M7NvI86hTdxovNnSlmLahJBytHxqlXQGBoKyodqIvG4RZZL8sLWNGMxqw2matvMwRAZvf6y7Ur4ehuMnhB+MPdJcPnAvIruOw9VD5BDvUi4wrQ9/45Pg/9ZtBiThsI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785762552; c=relaxed/simple; bh=Z6AoCJziUAEBoKdWqdaCYWruqsYRcNZY5aqj6IIJg50=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SFLlaKaOS6wJ8krwW/A7a32gPuddcO15KBx0DxN5nye5+4k9ZAnR/fch3l2uJ0j6efV126EEog1h2rdNtt+VRY0MWG1831QGtJ/FNEX30OS/0O0gMx1lj01dmhThCBLiRem8Ew1ECWPpNxhxBbNUO+Jhq6FRW2NzF/FLw5TjMVQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WYDjTupd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ihmSvs/T; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WYDjTupd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ihmSvs/T" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 673C4oD8365084 for ; Mon, 3 Aug 2026 13:09:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +bEBKAJA/+cRFgI8e27Dj0HsJfWCLd+x+yu0XT2bSxw=; b=WYDjTupdLXwjDaaB 77kSPC62DtFX4L/1/uW4rAnfpKyaDRjNDRqfr2CRyhKrU/PbcSOK1plmP6CxQMKb 6634pT7H3/dpmSw0c3WPH682pmP1jRWSegSNdRIXs3CuSa/XlyUMLjuQYeMa0GNd v/DRuhHgAyKOPdk4xY59DVzJsUbkZ/tG08nygCB+uvsD/4H1UkVRMxK8Lkr2kbDm ogZCV6ouI+Zd0+vHHb+TRNNHAELxBTioWR7CN0y7xTlwzXP/bDZO5B+HXJUWhkLz 2jjeP/t8taobp0wTwROY2c87cfEa0lCaVRJbwT4h+7floPpPjdq8HyYp2ObVnpzj FjaHZw== Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ftnrnsm7w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 03 Aug 2026 13:09:09 +0000 (GMT) Received: by mail-ua1-f72.google.com with SMTP id a1e0cc1a2514c-9771c8f5045so3039780241.3 for ; Mon, 03 Aug 2026 06:09:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785762548; x=1786367348; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=+bEBKAJA/+cRFgI8e27Dj0HsJfWCLd+x+yu0XT2bSxw=; b=ihmSvs/TOPol/62hu2Wefzysf5l3RGtA1zaWbbjNGu8bX8nprkn+92xxq8+INuWWKa 3+hAVrVuH8wRp3Qdqtb8DcwT+urs3GYbJU7sN0pNSOgwjnVNB5TUWR8jqUHWEsTl4k3Y vfJSG6yYhtzg/Z0rIH85YR2IBxYzX7nCYU7RTwLDsdqGe0woLYOfLrF4q8AFU9+QoRgR AfKbzWtkDhbhwvz7YgglcT7MgpnTiXudZD//fInmMUemJPHdmabnhj0tH+kPWimDNyn8 bU2GQrTJ4HdKgKFzfuwI+yzS0xT2HquMDyyjY6TOwPG1/32CTO2h9IeZSUmqkGazqJ/q F2ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785762548; x=1786367348; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+bEBKAJA/+cRFgI8e27Dj0HsJfWCLd+x+yu0XT2bSxw=; b=cKFGukK28fA3xzsr+tu9C2xE6x+G1vDnZOXDV4OA5q1UmHc667hzoA2P7IGghVtXsN HF4fk/NGvAbhg8uBGiXVvKT+Mg77pxEdGBmNbER/IDlGJI7HEUpHgkGUJrjQKmd8Dbru gV9j0P6/hwjet6nJ0BjHa3cHpvr5v8fcPJrOb98ahryxvB15zkaJCN3OAipazbdotWla 3wBYc2rpJTgMFHZfrFvq82E0WJb2sfmOl+QRY5ZXXPXNPDXQxcN+iWoMYrbr+dEU9cc2 BZRikiLOSIG14fvS2ehJT8cy1Q3VdiJwpzXzugRyXelSf0e/fIYIaBKc8wgBE+E+j8rI FVgw== X-Forwarded-Encrypted: i=1; AHgh+RpvOWxVFexbgcFbi3pd7NcXRjxvRPzDsnrP3rKWit0CBWpKEtX8a1feAQ5bTfzHhTBFd+FdHbi/9raWFDg=@vger.kernel.org X-Gm-Message-State: AOJu0YwKjTpcBTysutELA/Soy/Wh1ulrSnATarUAPRvX9w8iwMOCW530 HvFPfDmZ9i895xd8VxUmg18Wp5U/05S0JBIXCgy1jS13EtvYxI2DkQY4/02C+H55iNnl+Pkwpek jNZiPrSU0/19vdWla+4WYlJrLbRqv3bvBGVNS70epIawnfsBusBVZk5dJ6jy16i9v5YY+xLwuSE Q= X-Gm-Gg: AR+sD13G+7s2vD3ZvkViIvO7FPnMzU/xrBUB0nborJoprPEr1N3yzct9OCSacvtRA6l 5u//Raf0DfNCK74jGKPsnHEO0u0TMpWyz4syJYZZOWL48LdQ3kEKOMOwhxjmZXxey2c9CB23r1w gwzuHPAWwgrBaP9QXowD/0GWM0B+MGbkOsssSJTtTJTc2aeoet+dO/RdhukHsU1Neq3BUImA/Mh DBHE8kXclD2iic7Rflw3dxLeoKufem2eqb9VisO6TLoFMi1In4h3P+QVdzdU7i1hUo1twFrTmAw jUlRtJmxZghlKMs2v2Q+IVGtOxZyBnnq6mOptC/c/n7TUhAsWBqmTSdDke0Ia27riTF18YdGDJd jrag0ZJpKR9IgpLzFu4L1LVL0Jm6LBw== X-Received: by 2002:a05:6102:3f45:b0:744:a3fd:410a with SMTP id ada2fe7eead31-75b24071090mr6439572137.14.1785762548277; Mon, 03 Aug 2026 06:09:08 -0700 (PDT) X-Received: by 2002:a05:6102:3f45:b0:744:a3fd:410a with SMTP id ada2fe7eead31-75b24071090mr6439460137.14.1785762547623; Mon, 03 Aug 2026 06:09:07 -0700 (PDT) Received: from [192.168.1.110] ([178.197.219.214]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd3cc3ea1sm541388166b.26.2026.08.03.06.09.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 06:09:07 -0700 (PDT) Message-ID: <862f47fa-628b-49dd-b8a9-873955ce5a13@oss.qualcomm.com> Date: Mon, 3 Aug 2026 15:09:05 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] phy: renesas: rcar-gen2: Fix double of_node_put on phy creation failure To: Felix Gu , Vinod Koul , Neil Armstrong , Geert Uytterhoeven , Magnus Damm Cc: linux-phy@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260803-rcar-gen2-v1-1-9aa35c36d7d7@gmail.com> From: Krzysztof Kozlowski Content-Language: en-US In-Reply-To: <20260803-rcar-gen2-v1-1-9aa35c36d7d7@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODAzMDExOCBTYWx0ZWRfX3PF+tH3SiC/e npc7M870F94tp7CVLrvzGBdUs9LX+G5jTPLH6iCs9VCiDQtIJvfh3xieOlornVkE4YqVZ8lzkCT lNl+2VAAlupxJ4KTjnpeKT/5LMrV5h0= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODAzMDExOCBTYWx0ZWRfX4MEI4ZKvfy7T 53GZdGUd1zu6JOv1pLD4mSwNwV+j/0E19O/CqZ2H18cZrHAnssrhaTPF44eCxIs0cDHyzsv8VVo DqeBU8Cs87rHIjf5BYzxBhHwJ4XxhHcr4hM3G/MdOYbFddvJDh8z8DxmXCA4u8+PFSbDBJb+wTS jDB6Hz70t7I0p9luaxfVuxCAZSD6aS/ETDLG4MTm/BlhYxPloICFQRc8nI8DvrKUd8BdsHfY6Sd fekxRfQmwK71pwzUqJs+dB7dMJz7LdPWHSV2Q/fjnppaa02tXer/oFylcQ4aWglfKh+4IAOEX6c w/1ry/4Hw5O4bDNXn+4p4ovR90XTsaypd3es7GV2TBhcgQLdVH1RCSMqVgcogDT/KB6stB9mpCy mvdkMrNQ42o0STwEZl51x2pcqQnbqhCxUXuNqTj3pxrOa5ong3bWU85cHPsaoX87aWMOKSFH8IG l2ntJca0B5Bfv99SJ+w== X-Authority-Analysis: v=2.4 cv=Zest8MVA c=1 sm=1 tr=0 ts=6a7092f5 cx=c_pps a=ULNsgckmlI/WJG3HAyAuOQ==:117 a=+bKQE0WJfmhK2875HamI0Q==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=gU5Lm4jXYh4j8fgtNvcA:9 a=QEXdDO2ut3YA:10 a=1WsBpfsz9X-RYQiigVTh:22 X-Proofpoint-GUID: LD8UU9EZYYqu14aHusqaIxs6OAXIGWUA X-Proofpoint-ORIG-GUID: LD8UU9EZYYqu14aHusqaIxs6OAXIGWUA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-03_03,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608030118 On 03/08/2026 14:43, Felix Gu wrote: > for_each_child_of_node_scoped() releases the node reference on scope > exit, so the explicit of_node_put(np) in the devm_phy_create() error > path drops it twice. > > Drop the redundant of_node_put() and let the scoped cleanup handle it. > > Fixes: b64b32791fb5 ("phy: renesas: rcar-gen2: Simplify with scoped for each OF child loop") > Signed-off-by: Felix Gu > --- > drivers/phy/renesas/phy-rcar-gen2.c | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof