From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 811183AFAEB for ; Wed, 29 Jul 2026 19:38:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785353884; cv=none; b=Pw4qG5lF9Wg9mbAIfh1+2ISesieNmaPdLErqSzfmVfyKo2/ZXV30h/WHX/TMA/RidmiFmcDHpkljyCyKxftIHFnjJu6F6vVBZAxwVYsLJuTcSGLj7ZZDviqBWxd67CH7/KXZzTEsM2+hP3odeWFNMp9BNMyOo7KB3PU7f5mzCZg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785353884; c=relaxed/simple; bh=x/rRlVoLnYuXwT3efDQi9GUzViJ4obE1kKtouvQkKvQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Jzg4K/BulkphX/qMQ8Tx3i3TTRYI9++EbaVe4+aExBSDFFEuQNTAUfbWQS4Af7ToR4oG+AM9zTL28bHhRTXB20UZH8tMt1EjtFVptx0KwOo2QXmN5zelDi3nKfobXFWrqeHYIbssdItLP0fhjSzCSEyiKLsei4aIy31vm9E0eek= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Onw4mA5W; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=HSwH0egp; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Onw4mA5W"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="HSwH0egp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785353882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ce/4jE7SKUx9c/gVXIDISjJnAxGiSvKecY4InIRGaJ0=; b=Onw4mA5WXrRVJtwsn5r6j3RnO1S2foX6sBHJQCPfJ0d4WNzYxjibZvtRhusID40E2oyNxd ziaiCex6yBUG/BIIFlDYCpgC4+uuW0itiIh0vbLm6LeKh8bnDIA+pz1YAN42FX2YoipQOU PQuQ97mU1iSuZhvyTtTM+WJgIjQ9B10= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-74-UKyF0_yXNg6GlwdAMoRlHg-1; Wed, 29 Jul 2026 15:38:01 -0400 X-MC-Unique: UKyF0_yXNg6GlwdAMoRlHg-1 X-Mimecast-MFC-AGG-ID: UKyF0_yXNg6GlwdAMoRlHg_1785353880 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e6ed4fe99so267538285a.0 for ; Wed, 29 Jul 2026 12:38:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785353880; x=1785958680; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :organization:references:in-reply-to:date:cc:to:from:subject :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ce/4jE7SKUx9c/gVXIDISjJnAxGiSvKecY4InIRGaJ0=; b=HSwH0egpcdw6iA4yfDQ1/Ru9YB6LX+0Mub9WUuXjGO7hk2orrSjQSAAq4CJ3HcvVID bVoie2xMV2pPKK8UguBidf9H7WfLDHL2EB+LNqEx730nNk/q3qgl4lEm8BoGdmX99/c6 TiyU1bD+whBzunLZqdiEhCE0HIfYP6ySEPfSanSVSfFerA6Tn5gGZ6PWhuyQ3qppeXY3 QIIPvMSkYTJPoXor1T66mkyM9XB2EoGBZ/rLHsREvCaPdhEHTEKLa4UcYxfxZ8EuXZUo XI3qrZbi79snSTuMe1QnJm967bLvzc4fmmJA8qKKDqnCNBLGXnYG0I6+QdBnfiJMuRyj QpNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785353880; x=1785958680; h=mime-version:user-agent:content-transfer-encoding:content-type :organization:references:in-reply-to:date:cc:to:from:subject :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ce/4jE7SKUx9c/gVXIDISjJnAxGiSvKecY4InIRGaJ0=; b=n/lujKO4trCHpnJzsxvoIm2POU1RbM90rjjPIPLxJBD4KseaDcsN+ngcgib1G8gsN2 y2cX8ZfXV19yr/DNiHhBf1JQVNe3lbjX+NogbwI5eOORLrWn4mRgWhkAf9z9gRKn9nwU dygcGBBgh0QxapISfYuY1dlgqnOaEOY4ld7kRaG62Ifl7W5Ojj2IVGHT4MZaQ4+9ohlP GUGire9W7SqQnsOsTwqCIc7bjonwXS/xdvzX9qAypGSvKxDc5VNvmMiomi5CmCWcDf5O nHK4Dwc+o7XNDhHal9dM0LNx17ekzSRjzNL27JSnsJOfVZBBpohJE3ya5+HLhptrn/g2 smSQ== X-Forwarded-Encrypted: i=1; AHgh+RpxkYBN2G4kiFjoMudygwWbMqFnWBvKikhug4pkVvwQZ956mb/KywowZIjHKtBCPCFFQ22g+mgmuJcm2Dc=@vger.kernel.org X-Gm-Message-State: AOJu0Ywq31X+FKh3ASdDix13zu6X1CSWCkNZkQ7BPEdogQN96FLm/nr/ 6m0/YBgs9rri+qSHjj8YsuX0KfQGTGlS+WHGOqvHGP1iCf3FFkjn+Xfb10LS8siWEmK678Qj9Mv NMUF+uT3m+/4WB774Dd44oqdKN6iFnx0kLaLPJdX+BYtPqb2dhrrV7yGAFJTEYMWmFA== X-Gm-Gg: AR+sD12mlqo+HhcblXvauwuo4IgIqmsBcrrL24wsnnrXZyvl6EKo+GeGAevmDUeB8qR m/5xx6Zg+rl4aubztCfPI/msC0/BKbdTWIFWtk3KXnlemtQFSSMji5I3mEqtPp9wy8YCrWh08X4 V+7X7bWkcrjvqMarzu4I6700IM08puPGXp1RsDVbYOwInFboSfpsplRcvZA/9TyNjoeQmIpOkUV 0JcQdsAMfXdH4ByP2YLJ81UzcjqWUwZmhASltM2d+H39ysV9U6kSA5Yb2hIVy/gDZOxKIO+/Bm6 Ph+YaiBVE2nwkA0tUshk/IMjItCkcYU7i/r3hbD10OmiscOXXl4g7xNPgwhY14ZzvLrResg= X-Received: by 2002:a05:620a:471f:b0:92e:e5f1:2bc9 with SMTP id af79cd13be357-93483e9ca5cmr29058085a.65.1785353880328; Wed, 29 Jul 2026 12:38:00 -0700 (PDT) X-Received: by 2002:a05:620a:471f:b0:92e:e5f1:2bc9 with SMTP id af79cd13be357-93483e9ca5cmr29054985a.65.1785353879849; Wed, 29 Jul 2026 12:37:59 -0700 (PDT) Received: from m8.users.ipa.redhat.com ([2603:7000:9400:fe80::7a7]) by smtp.gmail.com with ESMTPSA id af79cd13be357-933e7318323sm237946385a.23.2026.07.29.12.37.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 12:37:58 -0700 (PDT) Message-ID: <86385ae5f9f753e42efde7d0088a494c91639741.camel@redhat.com> Subject: Re: [PATCH] crypto: ecc - Add NIST P224 curve parameters From: Simo Sorce To: Paul Louvel , Thomas Huth , Lukas Wunner , Ignat Korchagin , Stefan Berger , Herbert Xu , "David S. Miller" Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni Date: Wed, 29 Jul 2026 15:37:56 -0400 In-Reply-To: References: <20260729-add-nist-p224-curve-v1-1-334dfbe16683@bootlin.com> <42f6dd7b-8db0-46cc-ad22-c914d64d15bb@redhat.com> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-07-29 at 21:06 +0200, Paul Louvel wrote: > Hi Thomas, Simo, >=20 > On Wed Jul 29, 2026 at 6:43 PM CEST, Thomas Huth wrote: > > On 29/07/2026 17.51, Paul Louvel wrote: > >> Add the parameters for the NIST P224 curve and define a new curve ID = for > >> it. Make the curve available in ecc_get_curve(). > > > > May I ask: Who's going to consume this? >=20 > I am in charge of upstreaming the ECDSA and ECDH support of a PKA device.= The > downstream driver is using the NIST P224 curve in it's code internally. > We are waiting approval to upstream the driver, and I took the initiative= to > send the curve definition ahead of time, as I thought it might be better = to have > this definition in the core rather than in the driver itself. >=20 > This is an old IP that is more than 10 years old, and seeing Simo Sorce's > comment, it might not be a good idea to use this curve anymore. I would simply not expose P224 at all, nothing should use it anyway. Simo. --=20 Simo Sorce Distinguished Engineer RHEL Crypto Team Red Hat, Inc