From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010034.outbound.protection.outlook.com [52.101.201.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53DCC28DC4 for ; Sun, 19 Apr 2026 17:50:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.34 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776621038; cv=fail; b=eCY+QHE4WgsHKIdNT52Ub6gJi2a19dMzS+HTlm/BNhInOzacM1tJFsefkESdwbRYx4bSRtq3qaJWPYpaQ16hk7gJ0S+vG5kqgZX1GuF9euNyZUReL1tJ4Nkd+ylfoHeI8xB49BXtVqp87MDwE50xzpha/KH5PpCs3twcQ/5cjuc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776621038; c=relaxed/simple; bh=AutPUqc5o9OVYoJRu3Q7hsbcH1kHyWh5aB7W+yUcxCU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=Jg4pyFCzpdp3lIcAOmd6IhDYo8SBeZTY9hzBUXYvSzwoNMhi7YNt137pETYh7cq3IOzqp7fMwJ+lGMiHXOJUKaVSZMk2kyZuL9E0iuy0X6nJ3Q5Jzlzy02E3qdUF3oKqvBCU1zD6gp7CYrc68NVRYfuai6f8DSGFvGHkBXhYGgU= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=RfVlK8qF; arc=fail smtp.client-ip=52.101.201.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="RfVlK8qF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=c4HbYmNAmg+Ap2BYQW7kUX7ESbnvUBNgPJ8iOKi+BGJpBUc6VeqDknCcn/MnCJCYKpb88I0wXRTZxj92o0ltmbkaH3HB5Bn0UiMWE6xo39iSRHI1PdTkJaHarWG+6vzeMoBrompw0WzcOJzo1fPeY2tKXmqNwyUrc7KQK1K/sPLyzRR6NmI5MRTUVyDXekAVwuw5QnJISCQ8gqCL3DISgw7AB/LbKh+oJS969z2VO/ONRzL/JzEBsCJqufFHykeGoAPJ0wF6wbonTLoBlRHzj612p8J3DbCqLmaoHudWw3HPuSaapuw9hc+8pAUj4giOoBEL6c+sihGbhmaK1nHVhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5OB/fZe9oCKVlRS4/aPMojvDMOpI+wRIoPjcQRb10Qc=; b=Ojh1i5nV8TFK7CXOGiqESSpz4or54EHpoSUNL6xlGs62AXuKmzLdil35nJoDcMJUwGzqMWiitzYQs1gw3iSdOvxB4VT9UQLhkeMyd7n2kee/42/VsSIfNvqWYduaFPTWwH1Mo7WajdsZIjj6jE373GMKMGH9XhUQ3G/l8HxYykZVHqmaCKzkbOpBTtxRLiB5ZerP9x+wkJ98onx7qgZVtk9jVqrlYScFXUXZsoLqym6fdWSWjvO6HVKqJOzY++cX6FVjHCUUuCn3aF2X82no4+V3kTVnE/Iuahxh/j5mTBL7kh/9uZq41kEQfbDdI4a4xfFkaHAVzqUe2XwgQ5JTyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5OB/fZe9oCKVlRS4/aPMojvDMOpI+wRIoPjcQRb10Qc=; b=RfVlK8qF1qRHDgJNCwT589usOKgMhYC73FXk7ipqVCad8RIOLA2u084PwhD4i1I7qg5+eQySXlGwPH4YcLbvQwsDgaRphWlXvveZN3jEfjwj+7NQ3PB/pu+Z5ub9GVLXNdsa4vdmZj3Y0mBNQsxNJce9o9xC0cAqTQFohHEYSqG3ZOS5Mc8ZyKRQnw0RRZQA82U30eOwHuLqSTZRF7XPnVoUwbX7XT85bo04xrgL8M5KCcASjTROH4fjFHxyTx1iHT3jlGUA1mCY+RM/3qQLaTkq9V+54yoGm3dXLR7AO5+LtMIWrYy78FPQmRQysXWnJxUEWfOwhMXimQnQsrtE4Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by IA0PR12MB7724.namprd12.prod.outlook.com (2603:10b6:208:430::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.12; Sun, 19 Apr 2026 17:50:29 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::f01d:73d2:2dda:c7b2%4]) with mapi id 15.20.9846.012; Sun, 19 Apr 2026 17:50:29 +0000 From: Zi Yan To: Sunny Patel Cc: Andrew Morton , David Hildenbrand , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/migrate_device: Cleanup up PMD Checks and warnings Date: Sun, 19 Apr 2026 13:50:27 -0400 X-Mailer: MailMate (2.0r6290) Message-ID: <863FC1DF-BA32-4C96-B7E1-9405D1C4FEF0@nvidia.com> In-Reply-To: <20260419174747.10701-1-nueralspacetech@gmail.com> References: <20260419174747.10701-1-nueralspacetech@gmail.com> Content-Type: text/plain X-ClientProxiedBy: MN2PR18CA0027.namprd18.prod.outlook.com (2603:10b6:208:23c::32) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|IA0PR12MB7724:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d1a9891-9daf-459a-1691-08de9e3c2552 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|366016|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: xcNo1+hMrbgVnQnXTHRc3eaYcVvo0vP9pCL/6tWI6r4Tqywav+aZsHqvDXwXfilRDgTpZOLlH2d8NIR2JiUNeW4F2NII9IAV4PECZAiIODKVQAHcodM7D/bmsMHMHDzbHeI254/Yxo3DQjuehZGeR66j5Ug1UMtxTbHTcFJGI7QFAW0KOUm6OqLtZDx4CAYPbBGvNh4f7I10cpZM3++twhWdeCE98uPGZNn/n/fh4mHLXon/fxYQbjmJ4l06Rr0N0B1RGNmYkgyoU9Ipp4eqgMf1hOyvo1RWolfzLCh0UqqxgcruOAcSW/iDFAlAwxZINuwpzVOwaeru45DF7gEDxHWmmhwmwlLhayAGh/x15sPCTRyvR3NMuoPwLEGWSMOx6jstptkS1W6tGD/40/2n/QSQHMIFcObo3q2S/LWx5VWwEQemRZqG5UAMXKbbDrObD8Bnki9XxO1SjxBFl3uJVUTC/aMa/H3CWdUAO4I3NEaP+pD7pCDDc/nvCgEwwPnuyn1NAVzTozKX8f3riud1t/VO5Anq9B+AdXzQVb5L6ZHZIrvchoYUhLKMS5w2QhMczv/zE2xPVkhqAXLaHS91Yn+WNSpzmqG9rX+e4ojMhzZ02nD8PhYYEiD6mt3fgVw2bHeWWraMT27GmOcoF3ml+PaU/B3B3AVJlvfmPxepvcuIdYgKhzl4LE4YECGmxS8ee4JczicBLBf4vIRrv9xeX/blKTQHS6b6xt3c1py58sg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(366016)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SazDid/isRleYUOiL7IYxHxtiupdBs+rV0VI8NoPEUh9tmjEtaeh55kbr0E8?= =?us-ascii?Q?1EwG3Kziu0BWypoaakvZriVzAeekvaEciLvSHzXTMwvEDUN+UwhQYIe4UEUI?= =?us-ascii?Q?U3qhsWyG2NLPXt27GmUd7MAVjcazXUFOEVt8/NIpIgXSkXYIGRt8lgMn3U4F?= =?us-ascii?Q?w5+XKJ7aa3ocf4gd0qGec9RPQzQT00kwTDgtz3K+tAodNk5uO9epD6fXlTuz?= =?us-ascii?Q?rXKV20OHbQBIoaZeJPgvrOSL0qtw00qXLjWKThK4yBSisO8KhftDrra92+/2?= =?us-ascii?Q?dlX12YedsU34VwC5lDQZfrYzx+HFwr+qqGj8N9Vu6ynzeXXIDkajSXNen7FP?= =?us-ascii?Q?XwgpccaUO49QrPlMHSfD1u976k56wLxF9dB1jnD+8qqEgoduK1RWhhzB4ELv?= =?us-ascii?Q?Z8eSrMnClUhCUalueOtLELfJ3qLS/HSwFR5fMRcyoLdXDDdetF0y4i3Xl4Nk?= =?us-ascii?Q?FpQnH3KE9ubpWayLx/5osGrFnosImvCvjBNwUTsUAJNZ0whN/m0W8aPwG7cW?= =?us-ascii?Q?CVFWfUw2p1ZSVX9E77mPYbLyui+vV2aljquTStNmF6OsBrmdZynvgQ0ng42i?= =?us-ascii?Q?sNAW+CaF+epbbWUtgDPaWyq3p4XPmlBDcJeFGb7BioYQAFea2+AUYUbCF9Sm?= =?us-ascii?Q?kEv3EUK6qkra7ftcqaDeBAMXqWtK2g32Dkbb3rZunYWyqts+InnRw0aK5xln?= =?us-ascii?Q?dK/x6xT6a3fogE9kIaiVsk3L5MQfsg4G9JXyZnCMkt+nwq8FrItDZjj8nyEC?= =?us-ascii?Q?51RUzEQ8NJy+6HwP0o/JOyEvgkXby9m1poNe4xOqowGXxVy4lQUxCvZpJjx4?= =?us-ascii?Q?TF+F4mjM3YHEL8zmpOPcfN3c5Y9wOxD7Zug3LeWskWrOElyzdGxW/P3hMatw?= =?us-ascii?Q?/2QIvgQGxuwfgsE6iTcdCE8yupn7G/QNO7CprESPuIgTBRokV0fzGQFpnYPy?= =?us-ascii?Q?v7WP2QdoE1eSbGH4MIaK+GezqQ3m7BG9MsVA0GfkE9g4UFSBgvgb4OvkgzEt?= =?us-ascii?Q?s/Ijlw3lRk8LJ6/DMBVecE6665tjijW/JAU2gkpbgS8aC2ImggPyfHg75RZL?= =?us-ascii?Q?KL+S3MyXFBMhySCHCYGV0NvDjEeNuSTztiE/rtIdVjqs1oKSbhLd5Q8rJjwl?= =?us-ascii?Q?WyJPMPAJ1cRtvy96AbSp3egg17cVfaTPEL42JtBMQbtzUEfctSgFeGAf/nea?= =?us-ascii?Q?uc165cZaUjAuIrsUdyn7HYwOh1z5kBHerj/4YPB4lgPtL4K5Q4rrICR1GaO/?= =?us-ascii?Q?DM6IXSzlB+FCjK5oR2aqgNeJmzjk3wZJkyy9fvCCYoCFxRXTWpGGW8KHG28S?= =?us-ascii?Q?c6E75A6/OJa2z1VMUEJfiO1Q5qKMpJzY/CPKcc30MEAfLU8jM0hsgCqa+sgL?= =?us-ascii?Q?0RfQi4xsqeH6BWWVTM+OGPyLInMmnPc8wwbnByVEvwLhAaT3ENkKXw4Pukj4?= =?us-ascii?Q?uGaTnukPH862WfehTqKH1i2lgkDPtNq2xHhHVXaFQS4TM1a519rebGas7d2k?= =?us-ascii?Q?84g3Hrdhw13dH6FEK2b0cwyIfkw7Q35eQ0k0d1LvfZSvLXF8ijpOqN1psEVw?= =?us-ascii?Q?kWRkNTBLxG4PloXIXPX2rYnGLFZQ6F2aywAumoYmJouf7U2CevNzr6o698zz?= =?us-ascii?Q?HCAgGXwdsGj1F6KrFJ4uI9/69Zof5B0Vxg35tWqbuO0M4XMRGCTdyffTXiDY?= =?us-ascii?Q?K7375IAiBNGGs/FEqz9Bmz5r5nU+KUeQ8IrnSQgAZV62qcru?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d1a9891-9daf-459a-1691-08de9e3c2552 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2026 17:50:29.5841 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AafJ3yv2MfMoAaEGhiEsNl4TSkhUzmfLCvKg+vkPv8DfIO7T3aDf2ivUHlsf3pNW X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7724 On 19 Apr 2026, at 13:47, Sunny Patel wrote: > Remove the odd VM_WARN_ON_FOLIO(!folio, folio) usage and replace it > with a simpler VM_WARN_ON_ONCE(!folio) check. > > Drop the redundant VM_WARN_ON_ONCE(!pmd_none(*pmdp) && > !is_huge_zero_pmd(*pmdp)). > > Refactor the PMD checks, making the control flow > clearer and avoiding duplicate condition checks. > > Signed-off-by: Sunny Patel > --- > > Changes in v2: > - Removed additional check for pmd_present() as is_huge_zero_pmd() > already checks for pmd_present(). > > Missed it in first version of this patch. > > mm/migrate_device.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > LGTM. Acked-by: Zi Yan -- Best Regards, Yan, Zi