From: Gao Xiang <gaoxiang25@huawei.com>
To: Greg KH <gregkh@linuxfoundation.org>,
Bharath Vedartham <linux.bhar@gmail.com>
Cc: <yuchao0@huawei.com>, <devel@driverdev.osuosl.org>,
<linux-erofs@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] staging: erofs: Add whitespace after declaration
Date: Mon, 18 Mar 2019 23:40:35 +0800 [thread overview]
Message-ID: <863a7266-0068-a751-bbe6-cea78caf9355@huawei.com> (raw)
In-Reply-To: <20190318153816.GA15943@kroah.com>
On 2019/3/18 23:38, Greg KH wrote:
> On Mon, Mar 18, 2019 at 09:02:24PM +0530, Bharath Vedartham wrote:
>> Add whitespace after declaration. Fixed the checkpatch.pl warning.
>>
>> ---
>
> No signed-off-by?
>
>> changes since v2
>> - mutt gave me a lot of problems. Hence 3 patches for a really
>> small problem.
>> - Fixed the extra missing line.
>>
>> Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
>
> It needs to be above the --- line, otherwise it will be stripped off
> when applied.
>
> v4 please?
Actually a duplicate commit, see:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/?h=staging-next&id=8af36478f9516d51fcfedf9b9ed8905a1c00d278
several people submit patches on this line in erofs_iget()....
Thanks,
Gao Xiang
>
> thanks,
>
> greg k-h
>
next prev parent reply other threads:[~2019-03-18 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 15:32 Bharath Vedartham
2019-03-18 15:38 ` Greg KH
2019-03-18 15:40 ` Gao Xiang [this message]
2019-03-18 16:00 ` Bharath Vedartham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=863a7266-0068-a751-bbe6-cea78caf9355@huawei.com \
--to=gaoxiang25@huawei.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.bhar@gmail.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®