From: Mark Brown <broonie@kernel.org>
To: Marco Crivellari <marco.crivellari@suse.com>
Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
Frederic Weisbecker <frederic@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Michal Hocko <mhocko@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH 2/2] ASoC: replace use of system_wq with system_percpu_wq
Date: Fri, 5 Sep 2025 17:05:35 +0100 [thread overview]
Message-ID: <863db036-c077-4b2e-a65e-af80ea3c2d24@sirena.org.uk> (raw)
In-Reply-To: <CAAofZF4XEFXWQEqeKJ3aTjPRuu5RgOEYRLX4Aeq=RGh7gnLGTQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 893 bytes --]
On Fri, Sep 05, 2025 at 06:00:04PM +0200, Marco Crivellari wrote:
> Hello Mark,
Please don't top post, reply in line with needed context. This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.
> The above change is just a 1:1 conversion.
> system_wq is a per-cpu wq, so we only converted the name with the new one.
> system_wq is still present in the code, for a few release cycles.
> If the users don't care to be per-cpu, system_dfl_wq (the new unbound
> wq) can be used instead.
> This is just the first step of the conversion.
If we're going to convert everything I'd rather we do a sensible
conversion now than have multiple rounds of conversions. I strongly
suspect that most if not all of the current users don't know or care
that system_wq is percpu.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-09-05 16:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 9:10 [PATCH 0/2] sound: soc: replace wq users and add WQ_PERCPU to alloc_workqueue() users Marco Crivellari
2025-09-05 9:10 ` [PATCH 1/2] ASoC: replace use of system_unbound_wq with system_dfl_wq Marco Crivellari
2025-09-05 9:10 ` [PATCH 2/2] ASoC: replace use of system_wq with system_percpu_wq Marco Crivellari
2025-09-05 10:54 ` Mark Brown
2025-09-05 16:00 ` Marco Crivellari
2025-09-05 16:05 ` Mark Brown [this message]
2025-09-08 14:52 ` Marco Crivellari
2025-09-08 15:19 ` Mark Brown
2025-09-05 13:32 ` (subset) [PATCH 0/2] sound: soc: replace wq users and add WQ_PERCPU to alloc_workqueue() users Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=863db036-c077-4b2e-a65e-af80ea3c2d24@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=marco.crivellari@suse.com \
--cc=mhocko@suse.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®