From: "Abhishek Sagar" <sagar.abhishek@gmail.com>
To: ananth@in.ibm.com
Cc: LKML <linux-kernel@vger.kernel.org>,
"Masami Hiramatsu" <mhiramat@redhat.com>,
akpm@linux-foundation.org
Subject: Re: [PATCH] kprobes: remove redundant config check
Date: Wed, 11 Jun 2008 11:23:54 +0530 [thread overview]
Message-ID: <863e9df20806102253p4161e5bfv96ecc8ac5b4f9a89@mail.gmail.com> (raw)
In-Reply-To: <20080611035955.GA19154@in.ibm.com>
On 6/11/08, Ananth N Mavinakayanahalli <ananth@in.ibm.com> wrote:
> Abhishek,
>
> This was intentional (to take care of some gcc 4.2 issues). See commit
> cd5bfea278987ebfe60f3ff92a01696b17c4f978 (fix compilation with gcc 4.2)
> from Peter Chubb for details.
Yea, I checked it out and the problem the commit seems to be fixing is that
EXPORT_SYMBOL complains for static symbols with gcc-4.2. Can't see why
there was a need to cram CONFIG_KPROBES inside kprobes.c. This
check was sneaked in defensively it seems, and is unnecessary.
--
Regards,
Abhishek Sagar
prev parent reply other threads:[~2008-06-11 5:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-10 17:13 Abhishek Sagar
2008-06-10 19:35 ` Masami Hiramatsu
2008-06-11 3:59 ` Ananth N Mavinakayanahalli
2008-06-11 5:53 ` Abhishek Sagar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=863e9df20806102253p4161e5bfv96ecc8ac5b4f9a89@mail.gmail.com \
--to=sagar.abhishek@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®