From: "Abhishek Sagar" <sagar.abhishek@gmail.com>
To: "Steven Rostedt" <rostedt@goodmis.org>
Cc: "Ingo Molnar" <mingo@elte.hu>,
"Thomas Gleixner" <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
"Al Viro" <viro@zeniv.linux.org.uk>,
ananth@in.ibm.com, jkenisto@us.ibm.com, mhiramat@redhat.com
Subject: Re: [PATCH] ftrace: distinguish kretprobe'd functions in trace logs
Date: Fri, 31 Oct 2008 11:32:42 -0400 [thread overview]
Message-ID: <863e9df20810310832uadf4daay7b5a98b677d86561@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0810311036130.20157@gandalf.stny.rr.com>
On Fri, Oct 31, 2008 at 10:36 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
>> Hi Abhishek,
>>
>> Now that this code is in mainline, it has become apparent that
>> kretprobe_trampoline is not defined on all archs as a global like it is in
>> x86. This needs to be fixed (it breaks ia64 build).
>>
>
> Also note that kretprobe_trampoline will not be the return address.
>
> Hmm, I think I can solve this by not even doing the test here, but simply
> on the name itself.
Ok. I wonder if it would be a good idea to export kretprobe_trampoline
(or kretprobe_trampoline->ip) via asm/kprobes.h for all archs, for the
kind of checks done here for ftrace (to have them elsewhere too like
in OOPs generation etc).
Adding Kprobe folks in CC
-- Abhishek
next prev parent reply other threads:[~2008-10-31 15:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 18:33 Abhishek Sagar
2008-05-27 18:48 ` Steven Rostedt
2008-06-02 10:41 ` Ingo Molnar
2008-10-31 2:30 ` Steven Rostedt
2008-10-31 14:36 ` Steven Rostedt
2008-10-31 15:32 ` Abhishek Sagar [this message]
2008-10-31 15:50 ` Steven Rostedt
2008-10-31 19:33 ` Abhishek Sagar
2008-10-31 19:44 ` [PATCH] ftrace: use kretprobe trampoline name to test in output Steven Rostedt
2008-11-03 9:41 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=863e9df20810310832uadf4daay7b5a98b677d86561@mail.gmail.com \
--to=sagar.abhishek@gmail.com \
--cc=ananth@in.ibm.com \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®