From: Kumar Gala <galak@kernel.crashing.org>
To: benh@kernel.crashing.org
Cc: Greg KH <greg@kroah.com>,
linux-pci@atrey.karlin.mff.cuni.cz, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] [POWERPC] Always build setup-bus.c on powerpc
Date: Thu, 24 Jan 2008 00:33:34 -0600 [thread overview]
Message-ID: <8642742F-E8BF-43C7-9FE4-AAF54855ECF7@kernel.crashing.org> (raw)
In-Reply-To: <1201156120.6815.48.camel@pasglop>
On Jan 24, 2008, at 12:28 AM, Benjamin Herrenschmidt wrote:
>
> On Thu, 2008-01-24 at 00:07 -0600, Kumar Gala wrote:
>> The common arch/powerpc code calls in to functions in setup-bus.c
>> so some builds of ppc32 would fail.
>>
>> Note, ppc32 usage of setup-irq.c is limited to arch/ppc and should be
>> removed when arch/ppc goes away.
>
> I don't understand... the old code would build setup-bus.o for both
> PPC32 and PPC64 cases, how did you make it fail ?
The patch is bogus. The old makefile rules looked like:
obj-$(CONFIG_PPC64) += setup-bus.o
obj-$(CONFIG_PPC32) += setup-irq.o
pmac most like builds because CONFIG_HOTPLUG pulls in setup-bus.o
(I'll fix my foobar'd patch and send this via Paul).
- k
next prev parent reply other threads:[~2008-01-24 6:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-24 6:07 Kumar Gala
2008-01-24 6:28 ` Benjamin Herrenschmidt
2008-01-24 6:33 ` Kumar Gala [this message]
2008-01-24 6:38 ` [PATCH v2][POWERPC] " Kumar Gala
2008-01-24 7:06 ` Benjamin Herrenschmidt
2008-01-24 6:29 ` [PATCH] [POWERPC] " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8642742F-E8BF-43C7-9FE4-AAF54855ECF7@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=benh@kernel.crashing.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®