From: Arnd Bergmann <arnd@arndb.de>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: sre@kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn
Subject: Re: [PATCH] HSI: omap_ssi_core: move function declaration to header file
Date: Sat, 24 Sep 2016 10:58:15 +0200 [thread overview]
Message-ID: <8643667.VP5CpNPstK@wuerfel> (raw)
In-Reply-To: <1474693916-11789-1-git-send-email-baoyou.xie@linaro.org>
On Saturday, September 24, 2016 1:11:56 PM CEST Baoyou Xie wrote:
> ---
> drivers/hsi/clients/ssi_protocol.c | 2 --
> include/linux/hsi/hsi.h | 1 +
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c
> index 6031cd1..fe86444 100644
> --- a/drivers/hsi/clients/ssi_protocol.c
> +++ b/drivers/hsi/clients/ssi_protocol.c
> @@ -45,8 +45,6 @@
> #include <linux/hsi/hsi.h>
> #include <linux/hsi/ssi_protocol.h>
>
> -void ssi_waketest(struct hsi_client *cl, unsigned int enable);
> -
> #define SSIP_TXQUEUE_LEN 100
> #define SSIP_MAX_MTU 65535
> #define SSIP_DEFAULT_MTU 4000
>
Maybe the declaration should be moved to include/linux/hsi/ssi_protocol.h
instead of include/linux/hsi/hsi.h? It's not completely clear as the
exported function is a bit of a layering violation.
Arnd
next prev parent reply other threads:[~2016-09-24 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-24 5:11 Baoyou Xie
2016-09-24 8:58 ` Arnd Bergmann [this message]
2016-09-24 19:36 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8643667.VP5CpNPstK@wuerfel \
--to=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sre@kernel.org \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®