Re: [EXTERNAL] Re: [PATCH v3 1/2] dt-bindings: power: Add the bq256xx dt bindings

[Ricardo Rivera-Matos <r-rivera-matos@ti.com>]

Dan

On 9/22/20 8:05 PM, Dan Murphy wrote:
> RIcardo
>
> On 9/22/20 5:56 PM, Ricardo Rivera-Matos wrote:
>> Rob
>>
>> On 9/22/20 5:22 PM, Rob Herring wrote:
>>> On Thu, Sep 10, 2020 at 11:45:33AM -0500, Ricardo Rivera-Matos wrote:
>>>> Add the bindings for the bq256xx series of battery charging ICs.
>>>>
>>>> Datasheets:
>>>> - https://www.ti.com/lit/ds/symlink/bq25600.pdf
>>>> - https://www.ti.com/lit/ds/symlink/bq25601.pdf
>>>> - https://www.ti.com/lit/ds/symlink/bq25600d.pdf
>>>> - https://www.ti.com/lit/ds/symlink/bq25601d.pdf
>>>> - https://www.ti.com/lit/ds/symlink/bq25611d.pdf
>>>> - https://www.ti.com/lit/ds/symlink/bq25618.pdf
>>>> - https://www.ti.com/lit/ds/symlink/bq25619.pdf
>>>>
>>>> Signed-off-by: Ricardo Rivera-Matos <r-rivera-matos@ti.com>
>>>> ---
>>>>   .../bindings/power/supply/bq256xx.yaml        | 97 
>>>> +++++++++++++++++++
>>>>   1 file changed, 97 insertions(+)
>>>>   create mode 100644 
>>>> Documentation/devicetree/bindings/power/supply/bq256xx.yaml
>>>>
>>>> diff --git 
>>>> a/Documentation/devicetree/bindings/power/supply/bq256xx.yaml 
>>>> b/Documentation/devicetree/bindings/power/supply/bq256xx.yaml
>>>> new file mode 100644
>>>> index 000000000000..8cc2242f7df0
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/power/supply/bq256xx.yaml
>>>> @@ -0,0 +1,97 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
>>>> +# Copyright (C) 2020 Texas Instruments Incorporated
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: "http://devicetree.org/schemas/power/supply/bq256xx.yaml#"
>>>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>>>> +
>>>> +title: TI bq256xx Switch Mode Buck Charger
>>>> +
>>>> +maintainers:
>>>> +  - Ricardo Rivera-Matos <r-rivera-matos@ti.com>
>>>> +
>>>> +description: |
>>>> +  The bq256xx devices are a family of highly-integrated battery 
>>>> charge
>>>> +  management and system power management ICs for single cell 
>>>> Li-ion and Li-
>>>> +  polymer batteries.
>>>> +
>>>> +  Datasheets:
>>>> +    - https://www.ti.com/lit/ds/symlink/bq25600.pdf
>>>> +    - https://www.ti.com/lit/ds/symlink/bq25601.pdf
>>>> +    - https://www.ti.com/lit/ds/symlink/bq25600d.pdf
>>>> +    - https://www.ti.com/lit/ds/symlink/bq25601d.pdf
>>>> +    - https://www.ti.com/lit/ds/symlink/bq25611d.pdf
>>>> +    - https://www.ti.com/lit/ds/symlink/bq25618.pdf
>>>> +    - https://www.ti.com/lit/ds/symlink/bq25619.pdf
>>>> +
>>>> +properties:
>>>> +  compatible:
>>>> +    enum:
>>>> +      - ti,bq25600
>>>> +      - ti,bq25601
>>>> +      - ti,bq25600d
>>>> +      - ti,bq25601d
>>>> +      - ti,bq25611d
>>>> +      - ti,bq25618
>>>> +      - ti,bq25619
>>>> +
>>>> +  reg:
>>>> +    maxItems: 1
>>>> +
>>>> +  ti,watchdog-timer:
>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>> +    description: |
>>>> +      Watchdog timer in ms. 0 (default) disables the watchdog
>>>> +    minimum: 0
>>>> +    maximum: 160000
>>>> +    enum: [ 0, 40000, 80000, 160000]
>>>> +
>>>> +  input-voltage-limit-microvolt:
>>>> +    description: |
>>>> +       Minimum input voltage limit in µV with a 100000 µV step
>>>> +    minimum: 3900000
>>>> +    maximum: 5400000
>>>> +
>>>> +  input-current-limit-microamp:
>>>> +    description: |
>>>> +       Maximum input current limit in µA with a 100000 µA step
>>>> +    minimum: 100000
>>>> +    maximum: 3200000
>>>> +
>>>> +required:
>>>> +  - compatible
>>>> +  - reg
>>>> +  - monitored-battery
>>> additionalProperties: false
>>>
>>> And then fix what breaks in the example.
>> ACK. I will document the monitored-battery and interrupts properties 
>> and fix the example. Is ti,watchdog-timer okay as it is currently 
>> documented?
>
> For TI consistency please use ti,watchdog-timeout-ms
ACK, thanks.
>
> Dan
>
> Ricardo