From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 582AD296BBC for ; Tue, 13 Jan 2026 08:48:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768294139; cv=none; b=IRCKFxhmZDlSNEsuu8FK8FqPqTScqfCkPrjzAErp8XcmkOGo3qrcsAtRR3Zk3YeQEe5kYPvimJx5ZfLkTd478D36HKeyqsOZSlnXmnsWjeg5HhLRwglQTc8f4xFuWfi7Qa8Iy5OTVt3ttekCTokB9yMMkRNsbBFKcEF871G9PdU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768294139; c=relaxed/simple; bh=BP8aTClFhh4iJSHAxqvMGNkmdeQFIV0ORDvMdjNtVso=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=r6QjJklzQCsIcv81XmNImQ2Z1P4XHtZlhaJ1Khs8M3Icr2hIeBv+YnV7b50xzqQp/YwbUqmur3Vou6+Ji4lNgUXaklJIIMzeIkTqZF73mlj1HJ7f3RhzlmB4YjfI9Exr1AZv4rAWLSgJVlsyW7vFUNQYAQ3aRFyxsEuMeEcSZSo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zJ4IjvYo; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zJ4IjvYo" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-47a95efd2ceso62527605e9.2 for ; Tue, 13 Jan 2026 00:48:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768294137; x=1768898937; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=uIplZHRhc0bqvGNzZc7ZuexnTcKJ7c+gkReXl4SjmdA=; b=zJ4IjvYonRAEqtpaToiRecA8G5ZYN3EJu2EKhpBkoaF8WW+sCQfErfB+NUfIeNOmJj RrxnVqFrCTfXMivUmq+yvcTT+8HN8gOfyyYzkqOMwwJ2XBa79bbKCX8XMQwLChDbgmGN 4e2hGcb74N9ZtvvVJZ1Hc0cRYW+fkixRyZU6FBbeJi0ybvgAw65cfciPDV/TaiWRdIQZ wWyS/UPcyKStR5ij2lMHbJVRmIiHSvryQ50AKUQicQg8PY31BJiXcvhQZnY3V899lmgH 526TG7zcYuuyt4Tj6Hv9bStT1Sr7LGc7Tgz5vbkqGxU1Kj2/B3Ijyzqw4zYbv1twQu0/ jNcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768294137; x=1768898937; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uIplZHRhc0bqvGNzZc7ZuexnTcKJ7c+gkReXl4SjmdA=; b=rnV3grpCOQuCdx6iDpISkbjxKRNTFNWmA3QqEON7oNBqPYIMhsVto5N0HW1RsM5i8I DdwtDSbYqhRZQGfaYHtYuJZJHPB90S4ZgZZ204LAhl5Z7LMfOcDavtkOsznbRn470xn/ ge+szCBG2cPmNAvXbR4IyU26QJ7meQ90ru4NBCDP46R+BDwYV4D+BBmvWLW7XCVP2CSt 6d2P1PCIpBvxYUEQUptAvGfAxPJqCSG9eP6PFmSJ4hleagN5Q+IvA8hi/3R4KoEyPIc5 LVEQmcWd+U9RW8P2AJCWSos18JqCtOOae1Dq092m9zo6cSh/4hL8gHMA5yohv6kBn5af qTSg== X-Gm-Message-State: AOJu0YwqLKjT6ony57kwBBQROrgwft7wgETulXAH3bsNCvRugGeyUJn3 Xdy+U1iADF/BBGoWNA7LcCSauUKslZ9NsY1nyD9IioDKAfSO5/iyBI+OZnl58Xkol84= X-Gm-Gg: AY/fxX76PTo1ho0EB50PDjAIY4Url/+48ECfWK1T6jcicVLbyvECr2aoAyu37+6KQJx 2doNR1Ybzqu0cDuYjKSjO7CqmOymiRrmAiKyI9lK2bxiQHR/ljM+tBk+dNuYWNKbvvWYw9Hx6CK RLOjiQpDo/AdozfjPZ2kz4qtxcu8DQCrwTCm4j2Owy4GANaDasUpqJ5AHeZJTVa0pf+IgC+bdQp h7g/xZmetZThjVZrSgRh0u46U+EwViYd3g9dvoWfCGFPkZ4mtZSUs8ylZCcLYPVOsNLuokboBmG E1jRDdExCrLmdWdaru+294f64SlnY4EO1QXkSGRP2Va+SOBjAoo4TvurwNKMO6Pfktp7/de76rx /c2O/X2gfDTYLcQ7KmPbYucZxbRuLX7g5MYaytWpuMLCZSedHpBHbu4LnuPcV5MU/iIgFe/1ASF A1WB9euqTiV4uvwWeu9kLXHvZWExohUv4fxQke7ecHkdBKzs7Y2g== X-Google-Smtp-Source: AGHT+IEVq4zMh+exAfwLWPqTt1zwcdV5bKni86GoSGiMDDsS401edtmeHzgSVN5IypBq2cvM3hmIQQ== X-Received: by 2002:a05:600c:840f:b0:47b:d949:9ba9 with SMTP id 5b1f17b1804b1-47d84b1895fmr254070125e9.13.1768294136508; Tue, 13 Jan 2026 00:48:56 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080::fa42:7768? ([2a01:e0a:3d9:2080::fa42:7768]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f668e03sm408792255e9.14.2026.01.13.00.48.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 00:48:55 -0800 (PST) Message-ID: <8647ce72-7fce-48b4-be88-099ebc865423@linaro.org> Date: Tue, 13 Jan 2026 09:48:55 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: Neil Armstrong Subject: Re: [PATCH v2 1/2] drm/mipi-dsi: add mipi_dsi_shutdown_peripheral_multi To: Avinal Kumar , dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch References: <20260109155203.34886-1-avinal.xlvii@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260109155203.34886-1-avinal.xlvii@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/9/26 16:52, Avinal Kumar wrote: > Add mipi_dsi_shutdown_peripheral_multi function and mark > mipi_dsi_shutdown_peripheral fucntion as deprecated. > > Signed-off-by: Avinal Kumar > --- > drivers/gpu/drm/drm_mipi_dsi.c | 28 ++++++++++++++++++++++++++++ > include/drm/drm_mipi_dsi.h | 1 + > 2 files changed, 29 insertions(+) > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c > index a712e177b350..2fed50172a44 100644 > --- a/drivers/gpu/drm/drm_mipi_dsi.c > +++ b/drivers/gpu/drm/drm_mipi_dsi.c > @@ -587,6 +587,9 @@ EXPORT_SYMBOL(mipi_dsi_create_packet); > * mipi_dsi_shutdown_peripheral() - sends a Shutdown Peripheral command > * @dsi: DSI peripheral device > * > + * This function is deprecated. Use mipi_dsi_shutdown_peripheral_multi() > + * instead. > + * > * Return: 0 on success or a negative error code on failure. > */ > int mipi_dsi_shutdown_peripheral(struct mipi_dsi_device *dsi) > @@ -1980,6 +1983,31 @@ void mipi_dsi_dcs_set_tear_scanline_multi(struct mipi_dsi_multi_context *ctx, > } > EXPORT_SYMBOL(mipi_dsi_dcs_set_tear_scanline_multi); > > +/** > + * mipi_dsi_shutdown_peripheral_multi() - sends a Shutdown Peripheral command > + * @ctx: Context for multiple DSI transactions > + * > + * Like mipi_dsi_shutdown_peripheral() but deals with errors in a way that > + * makes it convienient to make seeral calls in a row. > + */ > +void mipi_dsi_shutdown_peripheral_multi(struct mipi_dsi_multi_context *ctx) > +{ > + struct mipi_dsi_device *dsi = ctx->dsi; > + struct device *dev = &dsi->dev; > + int ret; > + > + if (ctx->accum_err) > + return; > + > + ret = mipi_dsi_shutdown_peripheral(dsi); > + if (ret < 0) { > + ctx->accum_err = ret; > + dev_err(dev, "Failed to shutdown peripheral: %d\n", > + ctx->accum_err); > + } > +} > +EXPORT_SYMBOL(mipi_dsi_shutdown_peripheral_multi); > + > static int mipi_dsi_drv_probe(struct device *dev) > { > struct mipi_dsi_driver *drv = to_mipi_dsi_driver(dev->driver); > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index 3aba7b380c8d..19ccdf5eeb5f 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -389,6 +389,7 @@ void mipi_dsi_dcs_set_page_address_multi(struct mipi_dsi_multi_context *ctx, > void mipi_dsi_dcs_set_tear_scanline_multi(struct mipi_dsi_multi_context *ctx, > u16 scanline); > void mipi_dsi_dcs_set_tear_off_multi(struct mipi_dsi_multi_context *ctx); > +void mipi_dsi_shutdown_peripheral_multi(struct mipi_dsi_multi_context *ctx); > > /** > * mipi_dsi_generic_write_seq_multi - transmit data using a generic write packet Reviewed-by: Neil Armstrong Thanks, Neil