mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Pankaj Patil <pankaj.patil@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Manaf Meethalavalappu Pallikunhi
	<manaf.pallikunhi@oss.qualcomm.com>
Subject: Re: [PATCH 21/24] arm64: dts: qcom: glymur: Enable tsens and thermal zone nodes
Date: Thu, 25 Sep 2025 13:15:32 +0200	[thread overview]
Message-ID: <86492536-c14d-422c-add1-a6c60a7cb2e0@oss.qualcomm.com> (raw)
In-Reply-To: <20250925-v3_glymur_introduction-v1-21-24b601bbecc0@oss.qualcomm.com>

On 9/25/25 8:32 AM, Pankaj Patil wrote:
> From: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>
> 
> Add tsens and thermal zones nodes for Glymur SoC.
> 
> Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>
> Signed-off-by: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/glymur.dtsi | 1998 ++++++++++++++++++++++++++++++++++
>  1 file changed, 1998 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
> index 17a07d33b9396dba00e61a3b4260fa1a535600f2..986dc385200029071136068ab79ff8dd66d5284a 100644
> --- a/arch/arm64/boot/dts/qcom/glymur.dtsi
> +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
> @@ -2790,6 +2790,134 @@ pdc: interrupt-controller@b220000 {
>  			interrupt-controller;
>  		};
>  
> +		tsens0: thermal-sensor@c22c000 {
> +			compatible = "qcom,glymur-tsens", "qcom,tsens-v2";
> +			reg = <0 0x0c22c000 0 0x1000>, /* TM */
> +			      <0 0x0c222000 0 0x1000>; /* SROT */

These comments are not useful

I noticed that some patches use reg = <0x0, while others use reg = <0

please unify them for the former

> +
> +			interrupts = <GIC_SPI 771 IRQ_TYPE_LEVEL_HIGH>,

pdc 26

> +				     <GIC_SPI 861 IRQ_TYPE_LEVEL_HIGH>;
> +
> +			interrupt-names = "uplow",
> +					  "critical";
> +
> +			#qcom,sensors = <13>;
> +
> +			#thermal-sensor-cells = <1>;
> +		};
> +
> +		tsens1: thermal-sensor@c22d000 {
> +			compatible = "qcom,glymur-tsens", "qcom,tsens-v2";
> +			reg = <0 0x0c22d000 0 0x1000>, /* TM */
> +			      <0 0x0c223000 0 0x1000>; /* SROT */
> +
> +			interrupts = <GIC_SPI 772 IRQ_TYPE_LEVEL_HIGH>,

pdc 27

> +				     <GIC_SPI 862 IRQ_TYPE_LEVEL_HIGH>;
> +
> +			interrupt-names = "uplow",
> +					  "critical";
> +
> +			#qcom,sensors = <9>;
> +
> +			#thermal-sensor-cells = <1>;
> +		};
> +
> +		tsens2: thermal-sensor@c22e000 {
> +			compatible = "qcom,glymur-tsens", "qcom,tsens-v2";
> +			reg = <0 0x0c22e000 0 0x1000>, /* TM */
> +			      <0 0x0c224000 0 0x1000>; /* SROT */
> +
> +			interrupts = <GIC_SPI 773 IRQ_TYPE_LEVEL_HIGH>,

pdc 28

> +				     <GIC_SPI 863 IRQ_TYPE_LEVEL_HIGH>;
> +
> +			interrupt-names = "uplow",
> +					  "critical";
> +
> +			#qcom,sensors = <13>;
> +
> +			#thermal-sensor-cells = <1>;
> +		};
> +
> +		tsens3: thermal-sensor@c22f000 {
> +			compatible = "qcom,glymur-tsens", "qcom,tsens-v2";
> +			reg = <0 0x0c22f000 0 0x1000>, /* TM */
> +			      <0 0x0c225000 0 0x1000>; /* SROT */
> +
> +			interrupts = <GIC_SPI 774 IRQ_TYPE_LEVEL_HIGH>,

pdc 29

> +				     <GIC_SPI 864 IRQ_TYPE_LEVEL_HIGH>;
> +
> +			interrupt-names = "uplow",
> +					  "critical";
> +
> +			#qcom,sensors = <8>;
> +
> +			#thermal-sensor-cells = <1>;
> +		};
> +
> +		tsens4: thermal-sensor@c230000 {
> +			compatible = "qcom,glymur-tsens", "qcom,tsens-v2";
> +			reg = <0 0x0c230000 0 0x1000>, /* TM */
> +			      <0 0x0c226000 0 0x1000>; /* SROT */
> +
> +			interrupts = <GIC_SPI 791 IRQ_TYPE_LEVEL_HIGH>,

pdc 46

> +				     <GIC_SPI 865 IRQ_TYPE_LEVEL_HIGH>;
> +
> +			interrupt-names = "uplow",
> +					  "critical";
> +
> +			#qcom,sensors = <13>;
> +
> +			#thermal-sensor-cells = <1>;
> +		};
> +
> +		tsens5: thermal-sensor@c231000 {
> +			compatible = "qcom,glymur-tsens", "qcom,tsens-v2";
> +			reg = <0 0x0c231000 0 0x1000>, /* TM */
> +			      <0 0x0c227000 0 0x1000>; /* SROT */
> +
> +			interrupts = <GIC_SPI 619 IRQ_TYPE_LEVEL_HIGH>,

pdc 108

> +				     <GIC_SPI 814 IRQ_TYPE_LEVEL_HIGH>;
> +
> +			interrupt-names = "uplow",
> +					  "critical";
> +
> +			#qcom,sensors = <8>;
> +
> +			#thermal-sensor-cells = <1>;
> +		};
> +
> +		tsens6: thermal-sensor@c232000 {
> +			compatible = "qcom,glymur-tsens", "qcom,tsens-v2";
> +			reg = <0 0x0c232000 0 0x1000>, /* TM */
> +			      <0 0x0c228000 0 0x1000>; /* SROT */
> +
> +			interrupts = <GIC_SPI 620 IRQ_TYPE_LEVEL_HIGH>,

pdc 109

> +				     <GIC_SPI 815 IRQ_TYPE_LEVEL_HIGH>;
> +
> +			interrupt-names = "uplow",
> +					  "critical";
> +
> +			#qcom,sensors = <13>;
> +
> +			#thermal-sensor-cells = <1>;
> +		};
> +
> +		tsens7: thermal-sensor@c233000 {
> +			compatible = "qcom,glymur-tsens", "qcom,tsens-v2";
> +			reg = <0 0x0c233000 0 0x1000>, /* TM */
> +			      <0 0x0c229000 0 0x1000>; /* SROT */
> +
> +			interrupts = <GIC_SPI 621 IRQ_TYPE_LEVEL_HIGH>,

pdc 110

> +				     <GIC_SPI 816 IRQ_TYPE_LEVEL_HIGH>;
> +
> +			interrupt-names = "uplow",
> +					  "critical";
> +
> +			#qcom,sensors = <15>;
> +
> +			#thermal-sensor-cells = <1>;
> +		};
> +
>  		aoss_qmp: power-management@c300000 {
>  			compatible = "qcom,glymur-aoss-qmp", "qcom,aoss-qmp";
>  			reg = <0 0x0c300000 0 0x400>;
> @@ -4611,4 +4739,1874 @@ timer {
>  			     <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>,
>  			     <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>;
>  	};
> +
> +	thermal_zones: thermal-zones {
> +		aoss-0-thermal {
> +		thermal-sensors = <&tsens0 0>;

You need one more \t here

> +			trips {
> +				trip-point0 {
> +					temperature = <90000>;
> +					hysteresis = <5000>;
> +					type = "hot";
> +				};
> +				aoss-0-critical {

Please keep a \n between subnodes and between the last property and
following subnodes


> +					temperature = <110000>;
> +					hysteresis = <0>;
> +					type = "critical";
> +				};
> +			};
> +		};
> +
> +		cpu-0-0-0-thermal {
> +			thermal-sensors = <&tsens0 1>;
> +
> +			trips {
> +				trip-point0 {
> +					temperature = <90000>;
> +					hysteresis = <5000>;
> +					type = "passive";
> +				};
> +
> +				trip-point1 {
> +					temperature = <95000>;
> +					hysteresis = <5000>;
> +					type = "passive";
> +				};

See:

06eadce93697 ("arm64: dts: qcom: x1e80100: Drop unused passive thermal trip points for CPU")

It also only makes sense to keep "hot" trips for devices where we
can actually apply some cooling (e.g. the GPU)

Konrad

  reply	other threads:[~2025-09-25 11:15 UTC|newest]

Thread overview: 131+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-25  6:32 [PATCH 00/24] arm64: dts: qcom: Introduce Glymur SoC dtsi and Glymur CRD dts Pankaj Patil
2025-09-25  6:32 ` [PATCH 01/24] dt-bindings: arm: qcom: Document Glymur SoC and board Pankaj Patil
2025-09-25  6:32 ` [PATCH 02/24] arm64: defconfig: Enable Glymur configs for boot to shell Pankaj Patil
2025-09-25 17:31   ` Dmitry Baryshkov
2025-10-08 11:26     ` Pankaj Patil
2025-10-08 12:56       ` Dmitry Baryshkov
2025-09-25  6:32 ` [PATCH 03/24] arm64: dts: qcom: Introduce Glymur base dtsi and CRD dts Pankaj Patil
2025-09-25 10:16   ` Konrad Dybcio
2025-10-29 10:00     ` Taniya Das
2025-10-29 10:36       ` Dmitry Baryshkov
2025-10-30 10:44         ` Taniya Das
2025-10-30 11:09           ` Dmitry Baryshkov
2025-10-30 17:10             ` Taniya Das
2025-09-25 13:02   ` Marc Zyngier
2025-10-08 11:30     ` Pankaj Patil
2025-09-25 17:44   ` Dmitry Baryshkov
2025-10-08 11:36     ` Pankaj Patil
2025-10-08 15:55       ` Dmitry Baryshkov
2025-10-10  7:50   ` Abel Vesa
2025-09-25  6:32 ` [PATCH 04/24] arm64: dts: qcom: glymur: Add QUPv3 configuration for serial engines Pankaj Patil
2025-09-25 10:18   ` Konrad Dybcio
2025-09-25 17:46     ` Dmitry Baryshkov
2025-10-15 10:28     ` Jyothi Kumar Seerapu
2025-10-15 13:33       ` Dmitry Baryshkov
2025-10-15 14:12         ` Jyothi Kumar Seerapu
2025-10-15 19:53           ` Dmitry Baryshkov
2025-10-20 11:54       ` Konrad Dybcio
     [not found]     ` <5931e2eb-5f2d-49bb-8b9c-b49f77d7fcbf@oss.qualcomm.com>
2025-10-30 10:56       ` Konrad Dybcio
2025-10-11 11:06   ` Abel Vesa
2025-10-11 11:11     ` Abel Vesa
2025-10-12  2:46       ` Krzysztof Kozlowski
2025-10-15 10:33       ` Jyothi Kumar Seerapu
2025-10-11 11:16   ` Abel Vesa
2025-10-15 10:53     ` Jyothi Kumar Seerapu
2025-09-25  6:32 ` [PATCH 05/24] arm64: dts: qcom: glymur: Add cpu idle states Pankaj Patil
2025-09-25 10:25   ` Konrad Dybcio
2025-10-13  9:29     ` Maulik Shah (mkshah)
2025-10-06 14:26   ` Krzysztof Kozlowski
2025-10-08 11:37     ` Pankaj Patil
2025-09-25  6:32 ` [PATCH 06/24] arm64: dts: qcom: glymur: Enable pdp0 mailbox Pankaj Patil
2025-09-25  8:23   ` Krzysztof Kozlowski
2025-09-25 17:06     ` Bjorn Andersson
2025-09-25 18:49       ` Dmitry Baryshkov
2025-09-25 10:29   ` Konrad Dybcio
2025-10-09 10:43     ` Sibi Sankar
2025-10-20 11:51       ` Konrad Dybcio
2025-09-25  6:32 ` [PATCH 07/24] arm64: dts: qcom: glymur: Enable cpu dvfs for CPU scaling Pankaj Patil
2025-09-25  8:06   ` Krzysztof Kozlowski
2025-09-25 17:26   ` Bjorn Andersson
2025-09-25  6:32 ` [PATCH 08/24] arm64: dts: qcom: glymur: Enable ipcc and aoss nodes Pankaj Patil
2025-09-25 11:00   ` Konrad Dybcio
2025-09-25  6:32 ` [PATCH 09/24] arm64: dts: qcom: glymur-crd: Add RPMH regulator rails Pankaj Patil
2025-09-25 11:01   ` Konrad Dybcio
2025-10-15 15:40     ` Kamal Wadhwa
2025-10-20 11:53       ` Konrad Dybcio
2025-09-25 17:09   ` Bjorn Andersson
2025-10-08 11:42     ` Pankaj Patil
2025-10-11 11:31   ` Abel Vesa
2025-10-11 15:56     ` Dmitry Baryshkov
2025-09-25  6:32 ` [PATCH 10/24] arm64: dts: qcom: glymur: Add SPMI PMIC arbiter device Pankaj Patil
2025-09-25 10:31   ` Konrad Dybcio
2025-10-06 14:27   ` Krzysztof Kozlowski
2025-09-25  6:32 ` [PATCH 11/24] arm64: dts: qcom: Add PMCX0102 pmic dtsi Pankaj Patil
2025-09-25  6:32 ` [PATCH 12/24] arm64: dts: qcom: Add SMB2370 " Pankaj Patil
2025-09-25  6:32 ` [PATCH 13/24] arm64: dts: qcom: Update pmh0104 dtsi for Glymur CRD Pankaj Patil
2025-09-25  6:32 ` [PATCH 14/24] arm64: dts: qcom: Update the pmh0110.dtsi for Glymur Pankaj Patil
2025-09-25  8:08   ` Krzysztof Kozlowski
2025-09-25 13:14     ` Dmitry Baryshkov
2025-09-25 13:34       ` Krzysztof Kozlowski
2025-09-25 14:00         ` Konrad Dybcio
2025-09-25 18:57         ` Dmitry Baryshkov
2025-10-08  7:31           ` Kamal Wadhwa
2025-10-08  8:02             ` Krzysztof Kozlowski
2025-10-08 11:25               ` Krzysztof Kozlowski
2025-10-10 11:26                 ` Kamal Wadhwa
2025-10-08  9:15             ` Konrad Dybcio
2025-10-10 12:08               ` Aiqun(Maria) Yu
2025-09-25  6:32 ` [PATCH 15/24] arm64: dts: qcom: glymur: Add PMICs dtsi for CRD Pankaj Patil
2025-09-25  6:32 ` [PATCH 16/24] arm64: boot: dts: glymur-crd: Add Volume down/up keys support Pankaj Patil
2025-09-25 11:16   ` Konrad Dybcio
2025-10-01 13:48     ` Kamal Wadhwa
2025-10-06  8:56       ` Konrad Dybcio
2025-10-06 14:28   ` Krzysztof Kozlowski
2025-09-25  6:32 ` [PATCH 17/24] arm64: dts: qcom: glymur-crd: Avoid RTC probe failure Pankaj Patil
2025-09-25  8:11   ` Krzysztof Kozlowski
2025-10-01 12:23     ` Kamal Wadhwa
2025-10-06 14:28       ` Konrad Dybcio
2025-10-13 11:04         ` Kamal Wadhwa
2025-10-14 10:23           ` Konrad Dybcio
2025-10-14 12:36             ` Kamal Wadhwa
2025-10-14 19:52               ` Dmitry Baryshkov
2025-10-20 11:54               ` Konrad Dybcio
2025-10-06 14:32       ` Krzysztof Kozlowski
2025-09-25  6:32 ` [PATCH 18/24] arm64: dts: qcom: glymur: Add PMIC glink node Pankaj Patil
2025-09-25  8:13   ` Krzysztof Kozlowski
2025-09-25 10:32   ` Konrad Dybcio
2025-10-08 11:55     ` Pankaj Patil
2025-11-03 10:26       ` Kamal Wadhwa
2025-11-10 14:06         ` Kamal Wadhwa
2025-11-12 14:13           ` Konrad Dybcio
2025-09-25  6:32 ` [PATCH 19/24] arm64: dts: qcom: glymur: Add support for PCIe5 Pankaj Patil
2025-09-25  8:15   ` Krzysztof Kozlowski
2025-09-25 11:32   ` Konrad Dybcio
2025-10-10  7:02     ` Qiang Yu
2025-10-08 13:36   ` Abel Vesa
2025-10-10  7:08     ` Qiang Yu
2025-10-11 11:43       ` Abel Vesa
2025-10-11 15:57         ` Dmitry Baryshkov
2025-10-11 18:12           ` Abel Vesa
2025-09-25  6:32 ` [PATCH 20/24] arm64: dts: qcom: glymur-crd: Add power supply and sideband signal for pcie5 Pankaj Patil
2025-09-25 11:09   ` Konrad Dybcio
2025-10-09  9:53   ` Abel Vesa
2025-10-10  7:13     ` Qiang Yu
2025-09-25  6:32 ` [PATCH 21/24] arm64: dts: qcom: glymur: Enable tsens and thermal zone nodes Pankaj Patil
2025-09-25 11:15   ` Konrad Dybcio [this message]
2025-11-19 13:10     ` Manaf Meethalavalappu Pallikunhi
2025-09-25  6:32 ` [PATCH 22/24] arm64: dts: qcom: glymur: Add display clock controller device Pankaj Patil
2025-09-25  8:18   ` Krzysztof Kozlowski
2025-09-29  3:57     ` Taniya Das
2025-09-25 10:33   ` Konrad Dybcio
2025-09-29  3:54     ` Taniya Das
2025-10-09  5:12       ` Taniya Das
2025-10-09  8:30         ` Konrad Dybcio
2025-09-25  6:32 ` [PATCH 23/24] arm64: dts: qcom: glymur: Add USB support Pankaj Patil
2025-09-25 11:06   ` Konrad Dybcio
2025-09-25 13:19   ` Abel Vesa
2025-11-03 15:26   ` Abel Vesa
2025-11-03 17:00   ` Abel Vesa
2025-09-25  6:32 ` [PATCH 24/24] arm64: dts: qcom: glymur: Add remoteprocs Pankaj Patil
2025-09-25 17:30 ` [PATCH 00/24] arm64: dts: qcom: Introduce Glymur SoC dtsi and Glymur CRD dts Dmitry Baryshkov
2025-10-08 12:18   ` Pankaj Patil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86492536-c14d-422c-add1-a6c60a7cb2e0@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manaf.pallikunhi@oss.qualcomm.com \
    --cc=pankaj.patil@oss.qualcomm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®