From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F82C36680E for ; Tue, 21 Jul 2026 13:35:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784640914; cv=none; b=Lgr/0cjsBiAVfnOWwg9J8QbOjd0RAqBP2+hDRB2I/0kpFjGK6DyXtIJgF3m6iaEUtx8UQ1Uby3+VogqNt242MSF8Vghnxj8wrU7Glj8Qd9zoadw6RTWabiY6c8DfbefzV2XNcjLf7HlM+hPFo4QKYYy42mu4QeNl6c/cfF4tKhU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784640914; c=relaxed/simple; bh=a782tGijlNjR0oP5USP7fhxgWawGH8U5duyNoKInPNg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dwiRXDN/eDZ6QiRA0Fb84m0jMnHAu1BXTItzxEbVyqrtydQixQuw4/GWSnQ2rEBvJnFQz+6EaEaiCHzp6g6hcLSXenwZRT6pCu/vhsWBcXtPfraEY0FyI317ZFt3YLg+yZ8xsNHzqLaenHB1n40B4sxlP5+NAKSf8DADzqQ9lhg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yBFQ3rMY; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yBFQ3rMY" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-5aebd7da975so1285180e87.2 for ; Tue, 21 Jul 2026 06:35:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1784640910; x=1785245710; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=XBEoUQBhQJegFsZb7/UMDUnu+Fzmn8HXOU/ouOdSNmw=; b=yBFQ3rMYXrLzIaa1ePdLUY71Czf6KTyrKw5EvuJcuREXLLA86ItJqPfmO8DrRIqYMQ jWQsxAuxJHAjOsKJrOz3BlYxTx6FPr0V+udxwZSlVlHOAIUCMYzEkFAnxbrBdSuEX2S/ nDC8EA31prIuyeSmOM40sxWlVc98Gu6Xe0hAnMt5WvcxjHDVrkcBPFjKWsuCcHDEt565 L0NInvS3Ry3H3txA2n/vWjKM7pJKpIdQHwNdz7MrvbKiM6rwqS43gzk6Kmv4aeNGbbBC 5uOPTrc/oAWz67jWBvY4CTnKhoE/kY4shzf+DVxKMaPUhcyQ+haYjLrNChNnyo2Uo3oH M9Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784640910; x=1785245710; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XBEoUQBhQJegFsZb7/UMDUnu+Fzmn8HXOU/ouOdSNmw=; b=OWdRSJJnLOnRnNets/AkVxSfvpHtQ4+VjMEeCe6Uy9yUkK+pSxOGwkGuZiL+PAyops AzhFGizwTeE258D8t0N7nBHfPhfMoSxdKzNTQtOdDinMh1WS9UlZM3Ikx3j1cNWA7R+G MysspTvjRqZ7BCh4PiTtmb+AcDdlebPnkI1MjBIpRkMYJdnLsfYh7su+glgMVw7kaw+m l0uy8gINmSa0ZUb0XpQ/VNzZrPUbLy6OFr2SvejYNuscu2hL9CUqdJj+3ZZkVKsIUdwb T/XPBHffDOUuMoj4DxHHNmzJahkv+pL9U+PvMgzh7PA/2Ka2L+BKUhmJCWs3RxOE6/s3 R9Bg== X-Forwarded-Encrypted: i=1; AHgh+RrNdD/xph3tLzOOwkPsZacPzmM2g3BL0DecTV1fYPYZdgut2eXp4eKudJUhLqZRPjqW6Ra4KZmWV6F4zVU=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9L+Exsnqyf9gPSVG0/iDtV34Z3pIQGbMpS9eXV49+IPorR6RB kUg5hKvnRJ8a4F3gCcD7JabJAbnK5psScPESnNA4f/wZ3Xff3f0ob8XelNcIUddurT4= X-Gm-Gg: AR+sD12+UOyh85HQPvDOgIr8i1oXe1zaL14oomM38meMawcxhqZzQpiOuC509YAydUC 5S5m0jlv54tY5z4gnCZ7/azty7Aoirkp/lnVTCYH7vufIumsVyWgN3zpFKABH/yAqJTTlyJ8aYI LibHV+B6OwNqHzJGW3AQeSSLoH/nsEPNKpymlJL+tcTYNIacRcKnmWP95FQmqOxx16HCLcpWTaF A40OFalDYxh6hVDcLMzSQzO29Dly7H/J2xD6OSqc8+DCUAhWTFfxi3owH0QBktV1LeKmwXvKHwS UKOd5jn9TAa52nPPvWM7Y+LMvax/z40BfCTkliXiCcjieZMU52ZLhfpJcY7YFI1xgMZAIySflsj ig9TVL/mSLWg+pa99kJA1skxsHa36yGC5bGwz5rTIFm12SaZEb9Anu6aPyotDHAuQ7DWWhpeduV UBewyXh7fg8s8vBV69AZzrqdyErnOCwToA7HMV9OaVAfwOMgyUYhBjL7nJ X-Received: by 2002:a05:6512:b93:b0:5b1:5b9e:8de7 with SMTP id 2adb3069b0e04-5b2a49fca14mr515212e87.2.1784640910132; Tue, 21 Jul 2026 06:35:10 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b2a5588e11sm426572e87.42.2026.07.21.06.35.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2026 06:35:09 -0700 (PDT) Message-ID: <864c13a0-a52c-43f4-9d94-646bf66ba31a@linaro.org> Date: Tue, 21 Jul 2026 16:35:08 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema To: Bryan O'Donoghue , Bryan O'Donoghue , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski References: <20260720-x1e-csi2-phy-v13-0-160c31958863@linaro.org> <20260720-x1e-csi2-phy-v13-1-160c31958863@linaro.org> <0da6d314-bfa9-493a-bcc6-8c3b75751d0c@linaro.org> <88ae6662-cb85-4e3a-bbb5-1b536348df34@kernel.org> <_t1jiMTX3iIXhUkTDz0Cbh_uZhdUK_Y8vlIwxt1VNRbuKuRnpVCWabal-b4AuFrVaKrDnQSFOWtDn6-VCbS3DA==@protonmail.internalid> <345ca98e-09f6-4965-87bb-e64dac096498@linaro.org> <1f128571-ed46-4a60-9594-74fdd5f440d0@kernel.org> From: Vladimir Zapolskiy In-Reply-To: <1f128571-ed46-4a60-9594-74fdd5f440d0@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7/21/26 16:19, Bryan O'Donoghue wrote: > On 21/07/2026 12:24, Bryan O'Donoghue wrote: >> On 21/07/2026 12:05, Vladimir Zapolskiy wrote: >>> On 7/21/26 13:47, Bryan O'Donoghue wrote: >>>> On 21/07/2026 10:56, Vladimir Zapolskiy wrote: >>>>> On 7/21/26 12:39, Bryan O'Donoghue wrote: >>>>>> On 21/07/2026 09:17, Vladimir Zapolskiy wrote: >>>>>>>> +  "#phy-cells": >>>>>>>> +    const: 1 >>>>>>>> +    description: >>>>>>>> +      The single cell specifies the PHY operating mode. >>>>>>> This has been reported before, #phy-cells shall be 0, the operation >>>>>>> mode is selected by bus-type of endpoints as it is described in >>>>>>> video-interfaces.yaml >>>>>>> >>>>>>> Two competing values are redundant and it opens a door to a wrong >>>>>>> hardware description, the technical discussion has not been started >>>>>>> yet. >>>>>> So as I said before, I'm following Rob Herring's input on this and >>>>>> Krzysztof has given RB for this binding. At this stage, I don't see >>>>>> scope to change it. >>>>>> >>>>>> Adding endpoints was already a compromise to address your feedback, >>>>>> which I hoped would bring you on board with the design. >>>>> That's my comment dated March 27, 2026, and it says moving phy type >>>>> from phy cell to the endpoint property excludes the need to set any >>>>> phy cells: >>>>> >>>>> https://lore.kernel.org/linux-arm-msm/e37ce438-12c7-462d- >>>>> b2bc-1351be62b806@linaro.org/ >>>>> >>>>> The technical comment is left unresponded so far since then. >>>>> >>>>> Since there is no expected phy cells to get on consumer's side, and >>>>> since there is another link between CSIPHY and CSID described in >>>>> video-interfaces.yaml, any kind of dependency of this IP on phy can >>>>> be just removed, which serves the purpose of hardware description >>>>> simplification. >>>> >>>> Rob's v1 feedback was consumer-decides-mode via the cell; Krzysztof has >>>> R-b'd the binding with cells=1. >>> >>> Unfortunately this is not a technical discussion to move forward >>> a better hardware description. >>> >>>> I'm happy to lock down this binding as-is on that basis. >>>> >>>> Are you arguing about phy-cells or are you actually arguing the entire >>>> instantiation of Qualcomm MIPI CSI2 as a standalone generic driver in >>>> drivers/phy ? Its not the same debate at all. >>> >>> So far I don't review the driver, only CSIPHY IP hardware description. >>> >>> In the current version of the hardware description one may find that >>> the exploited 'video-intefaces' interface completely covers the 'phys' >>> interface between CSIPHY and CSID, quite probably both are not needed >>> at the same time, and the simpler 'phys' can be removed without any >>> losses. But if it is kept, then its cell value is anyway redundant. >>> >>>> As the CAMSS maintainer, I'm fully against adding more inline monolithic >>>> CSIPHY init sequences. That could be represented as a separate >>>> linux-media driver but, then that implies that _all_ upstream CSIPHY >>>> drivers in drivers/phy are wrong, and I just don't accept that. >>> >>> Other two drivers are different and should be excluded as good >>> references, both of them links exactly one sensor to exactly one >>> CSI-2 decoder, it's not the case here. Also one of these two drivers >>> has no upstream users. >>> >>>> The bindings have DT maintainer RB, and the driver has Qcom engineer >>>> tested-by, review-by. >>>> >>>> Vinod, Kishon - Again, I'd request this merges as-is. >>>> >>> >> >> The graph and phys are different layers, endpoints describe the >> media topology, phys is how CSID controls the PHY through the PHY >> framework (phy_get/configure/power_on). >> >> Removing phys doesn't simplify the description, it removes the control >> interface which is the monolith again. >> >> We have multiple examples of this model upstream, cdns-dphy-rx + >> ti-csi2rx in-tree, with users. >> >> I'm still kicking this up to Vinod, Kishon, request stands. >> >> Multiple DT and driver users are RB/Tested-by on the schema and driver, >> lots of other work is gated. >> >> It is time to merge. >> >> Please adjudicate. >> >> --- >> bod > > Had a brief discussion with Vlad, Neil and Vinod > > Resolution: > > - phys = <> retained It should suffice as an optional property, moreover any kind of phy interface usage is not supposed to be done from CSID driver. > - phy-cells = <0> > - bus-type from the media-controller > Already specified with camss still aligns with Rob's declaration > "the consumer defines the mode" so I'm comfortable with this > compromise position. > This will still facilitate CPHY work/mode-selection via > phy_ops->configure() with how to define the CPHY part TBD. As it was discussed there should be no phy specific interfaces between this phy driver and CAMSS driver. > - data-lanes = <0 1 2 3> valid Would be nice to get an ack from linux-media maintainers on it. > - MAX_LANES 8 instead of MAX_DATA_LANES 7 Since 'data-lanes' value follows some register bits and not the actual PCB lanes as in video-intefaces.yaml, this shall be explicitly described in the CSIPHY dt binding documentation. > - v14 with these changes shortly. > -- Best wishes, Vladimir