From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f49.google.com (mail-dl1-f49.google.com [74.125.82.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6E6A329E5E for ; Tue, 10 Feb 2026 22:12:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770761548; cv=none; b=qSJ0TO8z4D6sL9S6w5UNx1BHA+NX8HOrI+0X7shisRgPZTleF0XKqVguNXI4oUjBW3IuiZJHK6Kuyb4U5UG7gH5zkqS1JUAjXNjo0GViyjywNEXkohptarMScedkfXF6N7tyKFRBe6WDuPAlV6Z4/eLFRzOSPDs51e5gis6C1RM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770761548; c=relaxed/simple; bh=4w58qAOMvJ3a9eKiAJfg5l3rhuh4BzEpJ/9Nn3CTZgk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YyK0RY36Wu2l7HMSIs/4oMq8Y9z1iPUzH9FyViqRZjBOV543D3MCl6usicfz4mQex0jWR41M1KSaxFQIZjfXrfug10BVexz65IBeea6gRvDCRF0RwPk22X2qSDr0FjSJWvAhSxvuC1VtQ8+W08stYSwM05R75AR4WDyQN54pz3Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ju0HzOUG; arc=none smtp.client-ip=74.125.82.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ju0HzOUG" Received: by mail-dl1-f49.google.com with SMTP id a92af1059eb24-124afd03fd1so6928298c88.0 for ; Tue, 10 Feb 2026 14:12:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770761547; x=1771366347; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YTHbTUA8gqoLAorCfcF3d9LhgsN8Y1afMEZg2UqN9SQ=; b=Ju0HzOUGcDNDVLTGUlE/Db5TPCmdWRWKje8Z0HvCoTZdedXN4xD7KKE59y2uihAth6 wjkMd2gxZCHQgQSCiRRapIQ6M8hrXNPaHRoHdT04E7UDesZQcaeg/trPWZXv3GTXxBG1 tzvZI60iosouvdaHWpuH5teeMeglPelSRU6eKoDwhFQ7yIxtcSS4iRjCYOTP3E4Xgphb CKgIzIXazfiE0WSW0q+9B9AMozI9NAKcTESFHWtrURI19Cab3OPv0VCrwjrkpheUGCWj lnt60DeJE1+kQCfzERyMpecPKRQYmCTWW68b5KRItFnnP6MtUdWkwqS9Epz5SWd+rUNo Ya3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770761547; x=1771366347; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YTHbTUA8gqoLAorCfcF3d9LhgsN8Y1afMEZg2UqN9SQ=; b=uhBn4RQR0Jv5AIsfQS5OmtbBk81te96uuTLa0qHkyFrxR+kz2OSGzxyIoWjIes0hr8 fSvrUPyGjXsBFihAf0h1+6rKSHf7SKWpOD1ecNanyj73zrCCJcufwC/Ap0r2mPBi891p xYCNMGw3y7CPUtnR3AzKkMtyKSRSlOFUI9r+3zAB0yGJbsou918ip7YJ04DqQqRKq1i7 R9DuXFYCkh7HDFYcM7upFvd9hJ/jXmqozNfa1OKrAiv54f+ougUKNlHTKCFRDyu3PFNT 7Xr8IR/biKaXtVfyVRJm/y6+kz2KX6GN95boENX3r7FzJqn/vjjadlLx4uF1c9dIMf1c 3Vvw== X-Forwarded-Encrypted: i=1; AJvYcCU7PVG/fRHqeTs3HBCnfrYODxQXAmniftBWCf5anatdwn2B0oTk5ggabMr60RpA3sDraACLC64e956CDgk=@vger.kernel.org X-Gm-Message-State: AOJu0YyxZQX/Zz6N2ZXnMlrhDMtCEOG7t2liMCxXvHdTRQZ576S5sIL8 6jrYBlZH+82CRMrk5odljcCry9LBujN0qjNlXRI8YhWRfi2RLEysfbg7 X-Gm-Gg: AZuq6aLn0j/1q15ZkiiF7vbqaKNhGv7+3M3HaW2D1BY2vK7xH9s4O4y5Vy9yfqbKVXU GCqZDnYT8Fx9tOpBgXFpUS/zBmYystXC9Xr9pQwNt7N6oiqVZ+JWbLainFzslV3Y/hHf/3QTOle X5EiZk6hqrH4x9Viitgm80KYLFJY+/QENYoB6wl8xekvfi/QAX3PVayiEs1lnOT/dOnNnVJDs7R XMf3fgBJp4uQ3w04FBQb3IaTGSr3VAl3Rhgwl+WFNDC9Nyt6DiBSiiDWLz7jlCkf2S6S75J3Ak7 EGEuNmcPxdygOS7Br8XeUElpJr7Im8E5C0tqfjjjjirm1hqKEcpf/IbWqdaHV0zhauB7Hq/YDi+ tzRfrKk5J8H2XZGPIfUXHsOPI/6bcMz3HUG2IJ9S2rqbfT0SIDQUZTu4kAFVxmzBXFoAcClS55C erL9QIfLtEmgkUnBHqoxJk67MyvAWkOg+SJUh/0On9ctI= X-Received: by 2002:a05:7022:521:b0:11b:9b9f:427a with SMTP id a92af1059eb24-127299516admr299212c88.21.1770761546718; Tue, 10 Feb 2026 14:12:26 -0800 (PST) Received: from [10.69.50.72] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1270433abdfsm12369438c88.12.2026.02.10.14.12.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Feb 2026 14:12:26 -0800 (PST) Message-ID: <864e0ce2-4fa0-4d89-aaaa-a552977781a3@gmail.com> Date: Tue, 10 Feb 2026 14:12:24 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 13/14] nvme-fc: Use CCR to recover controller that hits an error To: Mohamed Khalfella , Justin Tee , Naresh Gottumukkala , Paul Ely , Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg Cc: Aaron Dailey , Randy Jennings , Dhaval Giani , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, jsmart833426@gmail.com References: <20260130223531.2478849-1-mkhalfella@purestorage.com> <20260130223531.2478849-14-mkhalfella@purestorage.com> Content-Language: en-US From: James Smart In-Reply-To: <20260130223531.2478849-14-mkhalfella@purestorage.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/30/2026 2:34 PM, Mohamed Khalfella wrote: > +static void nvme_fc_fenced_work(struct work_struct *work) > +{ > + struct nvme_fc_ctrl *fc_ctrl = container_of(to_delayed_work(work), > + struct nvme_fc_ctrl, fenced_work); > + struct nvme_ctrl *ctrl = &fc_ctrl->ctrl; > + > + nvme_change_ctrl_state(ctrl, NVME_CTRL_FENCED); > + if (nvme_change_ctrl_state(ctrl, NVME_CTRL_RESETTING)) > + queue_work(nvme_reset_wq, &fc_ctrl->ioerr_work); > +} I'm not a fan of 1, maybe 2, state changes that may silently fail. Some trace message would be worthwhile to state fencing cancelled/ended. -- james