From: Jens Axboe <axboe@kernel.dk>
To: Marcos Paulo de Souza <marcos.souza.org@gmail.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
hare@suse.com
Subject: Re: [PATCH 0/2] Remove blk_mq_sched_started_request function
Date: Mon, 22 Jul 2019 20:17:51 -0600 [thread overview]
Message-ID: <864e671d-06ba-9689-9caa-8435cde1c860@kernel.dk> (raw)
In-Reply-To: <20190723021439.8419-1-marcos.souza.org@gmail.com>
On 7/22/19 8:14 PM, Marcos Paulo de Souza wrote:
> While inspecting the queue_rq calling sites, I verified that
> blk_mq_start_request calls blk_mq_sched_started_request, and this function
> checks if the elevator of the current request implements the started_request,
> but currently none of the available IO schedulers do.
>
> So, let's remove blk_mq_sched_started_request along with started_request, which
> is member of the elevator_mq_ops struct.
Looks fine to me as it's unused, but please fold the two patches. Makes no
sense to split that into two separate patches.
--
Jens Axboe
prev parent reply other threads:[~2019-07-23 2:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 2:14 Marcos Paulo de Souza
2019-07-23 2:14 ` [PATCH 1/2] block: blk-mq: " Marcos Paulo de Souza
2019-07-23 2:14 ` [PATCH 2/2] include: elevator.h: Remove started_request from elevator_mq_ops Marcos Paulo de Souza
2019-07-23 2:17 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864e671d-06ba-9689-9caa-8435cde1c860@kernel.dk \
--to=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcos.souza.org@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®