From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F21239EF01 for ; Sat, 17 Oct 2026 17:22:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792257775; cv=none; b=NLJZ0uSjhNWRe0NjUynN7EntDOYiQDtm7PaVpjgPlO7R9QU6MhvwA8TUo+XU7XMEuL4weNp0mObyTYmzUvPYbI10/6ZaxXtsVtWGXcQnQgSBJ8mhofIi+1xXx1kmD4by5GziqBSHgqw3Nx9z09aOzvkjE/ZnJUSIiGN3tuZWGAE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792257775; c=relaxed/simple; bh=9+Z55do5MvjOgLX/y/9zTuXuoHK6P86gHOfxi/wSdTY=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=sOV30JeeC+h1DXDk5mRvk7Ieihrx7G8MempipGLyTb0EisEPL3E0kXub9y5TjVhJAPBtTWn0rEbdifFRWE52Og9/yiXjO9pV3FOb9E67QXxznW3RbdNmJUW0QhBcZEEwdC5dkdiwHxRJL6/d98Q9RT2D2REHdEbn5ClAJ3i3SsY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=E5994FI8; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="E5994FI8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AE971F000C5; Sat, 17 Oct 2026 17:22:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792257774; bh=XLe8JXdyBEFFJmBvlr2WFTfY/8qS8WbugaiAG9OA1pU=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=E5994FI8BIFPq8T4RnDF1uGTb3Qi5ps6Tz8bl0HzJcqhSpsdnESC3rRCbEqiqlzd3 D+g9kZnc6xyHJ0lJX0qpuyzPVQCyYZFbaxNe3nVCRgO4OmqlyDF2dt5TZumGLDRQq/ C+hpENK60XsFem6BeNWdlx2GONT1H3Fp7N7jg365IWAWynkl5gFE26RfNpov9o4b+k cQnSbRuhwEXdPQlXJrG3YXU7YqNZJ/o4v+eUwTf5EyIrlVlDeq1oTCt24TKeOjJBFh HhVwij6rJhxG/0FD0So+1ijaJKJ6UeDyLwCWQxGtTrLHVwzUq3staINgjrGFyD06V+ PlRExEP7uWo6A== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xI87P-000000048vp-3vWG; Sat, 17 Oct 2026 17:22:52 +0000 Date: Sat, 17 Oct 2026 18:22:51 +0100 Message-ID: <864iek1btg.wl-maz@kernel.org> From: Marc Zyngier To: Julian Braha Cc: mark.rutland@arm.com, lpieralisi@kernel.org, sudeep.holla@kernel.org, tglx@kernel.org, radu@rendec.net, vsethi@nvidia.com, sdonthineni@nvidia.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/2] irqchip: gic-v3: fix unmet dependency on ARM_PSCI_FW In-Reply-To: <20261014123539.2259230-1-julianbraha@gmail.com> References: <20261014123539.2259230-1-julianbraha@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: julianbraha@gmail.com, mark.rutland@arm.com, lpieralisi@kernel.org, sudeep.holla@kernel.org, tglx@kernel.org, radu@rendec.net, vsethi@nvidia.com, sdonthineni@nvidia.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 14 Oct 2026 13:35:37 +0100, Julian Braha wrote: > > ARM_GIC_V3 currently selects HAVE_ARM_SMCCC_DISCOVERY without ensuring its > dependency, ARM_PSCI_FW, is met. > > Patch 1 of this series makes the select conditional on arm64, and patch 2 > adds stubs for arm32. > > --- > Julian Braha (2): > irqchip: gic-v3: fix unmet dependency on ARM_PSCI_FW > firmware: smccc: provide stubs when discovery is disabled > > drivers/irqchip/Kconfig | 2 +- > include/linux/arm-smccc.h | 7 +++++++ > 2 files changed, 8 insertions(+), 1 deletion(-) This hasn't been correctly tested, I'm afraid. The patches are in the wrong order, as applying patch #1 on its own will break a 32bit ARM build without PSCI (HAVE_ARM_SMCCC_DISCOVERY not selected, but the stubs that are supposed to save the day are in patch #2...): arm-linux-gnueabihf-ld: drivers/irqchip/irq-gic-v3.o: in function `gic_enable_quirk_nvidia_t241': /home/maz/hot-poop/arm-platforms/drivers/irqchip/irq-gic-v3.c:1816:(.text+0xb04): undefined reference to `arm_smccc_get_soc_id_version' make[2]: *** [scripts/Makefile.vmlinux:72: vmlinux.unstripped] Error 1 make[1]: *** [/home/maz/hot-poop/arm-platforms/Makefile:1387: vmlinux] Error 2 make: *** [Makefile:248: __sub-make] Error 2 With the patch ordering fixed and the whole thing applied to the same tree: Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.