From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B964345A2BD; Wed, 30 Sep 2026 08:20:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790756459; cv=none; b=IsjE+/r2TizD9Igjpmrgfj6DULrZ6RmxAxxydnAzKOz8HhoRx0DMCOgSBWQrrwRL+0W/TZkvGNiW3unnkOB7PwkgqYXoE9hWDUbASn1kC+lLlU1vu3CNbDiO7xZHR5OZL8ZfA38SNFsGER+KJbrBEWSVShVxYulA5xJJ7fSc9+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790756459; c=relaxed/simple; bh=u016q+T3ZG95kX40mCqacc5cB+rNEjOrL5eR9KhIkCs=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=g3cMco80ApKk2sS9ggYjeqbMHGiQYXHZKPjvUPRStNH8fSwmfj/Zx79iaQNTuQ0er9Oznwy0v9/Lff3YdjDKRp9qxQ+XMK0iKs9eHL0i6t00e2Is6QemcDn/cA8F8uEpZSpbah6pG1B/i96Cww/OLjgd0jtHUn4GJW1wpgpg80I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BYfxPu8/; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BYfxPu8/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C1A11F000FF; Wed, 30 Sep 2026 08:20:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790756457; bh=8Kl5UcJrGEhp2IPa8cWZX2IgI14wRtDck030fk2wpo0=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=BYfxPu8/AekEa34JEpsE65qz0QWzoF4W7RjDh1tFhBVHQrbik9vAbAGCTKXVf3r/G yy0DRqV4kKEuZsI7oGF83xPgqRFBg5GunS1Hc+OrfEP5DBR1hqlBUl460eXiad08yy 0rZZw9O787nzndvfPQzXtd8zmRWdkJPe2K/w7/9xvb5niqNU/FLHUnNRN8kJmRFE+T XUCPIDUlfriM6lCZZrWO4VfbbBNK6zLib4+IEa4wgOj4R8PILpMNhvxOIMwIxU+rXp xOYt4RSozj97uYVtmYvg0L2gm+Eu5iiJEaNr9u8EnCCX/bdNdCV3DYniGcUNErQKjq tgEpNyFDcrNYQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xBpYc-0000000FCz3-37bI; Wed, 30 Sep 2026 08:20:54 +0000 Date: Wed, 30 Sep 2026 09:20:54 +0100 Message-ID: <864if740bd.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: Oliver Upton , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Fuad Tabba , Peter Maydell , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, "Lorenzo Stoakes (ARM)" Subject: Re: [PATCH v4 2/3] KVM: arm64: Block ID register changes after we rely on the values In-Reply-To: <20260929-kvm-arm64-idreg-final-v4-2-75296dde994d@kernel.org> References: <20260929-kvm-arm64-idreg-final-v4-0-75296dde994d@kernel.org> <20260929-kvm-arm64-idreg-final-v4-2-75296dde994d@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: broonie@kernel.org, oupton@kernel.org, joey.gouly@arm.com, seiden@linux.ibm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, fuad.tabba@linux.dev, peter.maydell@linaro.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, ljs@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 29 Sep 2026 12:57:59 +0100, Mark Brown wrote: [...] > +#define kvm_id_regs_final(kvm) \ > + test_bit(KVM_ARCH_FLAG_ID_REGS_FINAL, &(kvm)->arch.flags) > + > +#define vcpu_id_regs_final(vcpu) \ > + kvm_id_regs_final((vcpu)->kvm) > + This second helper really gives the wrong idea (idregs are never vcpu-specific with KVM). I've dropped it when applying this series. Thanks, M. -- Without deviation from the norm, progress is not possible.