From: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
To: Zwane Mwaikambo <zwane@arm.linux.org.uk>
Cc: Gerd Knorr <kraxel@suse.de>,
Xen merge mainline list <xen-merge@lists.xensource.com>,
linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-merge] Re: [patch] SMP alternatives for i386
Date: Wed, 14 Dec 2005 20:15:01 +0000 [thread overview]
Message-ID: <865100f9f39bd64c72af67447023b1cd@cl.cam.ac.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.0512141129090.1678@montezuma.fsmlabs.com>
On 14 Dec 2005, at 19:35, Zwane Mwaikambo wrote:
> diff -urN -x 'build-*' -x '*~' -x Make -x scripts
> linux-2.6.15-rc5/arch/i386/kernel/smpboot.c
> work-2.6.15-rc5/arch/i386/kernel/smpboot.c
> --- linux-2.6.15-rc5/arch/i386/kernel/smpboot.c 2005-12-06
> 17:00:36.000000000 +0100
> +++ work-2.6.15-rc5/arch/i386/kernel/smpboot.c 2005-12-06
> 17:06:48.000000000 +0100
> @@ -1351,6 +1352,9 @@
> fixup_irqs(map);
> /* It's now safe to remove this processor from the online map */
> cpu_clear(cpu, cpu_online_map);
> +
> + if (1 == num_online_cpus())
> + alternatives_smp_switch(0);
> return 0;
> }
>
> Is that really safe there? Ideally you want to do the switch when the
> processor going offline is no longer executing kernel code.
Perhaps that check belongs at the end of __cpu_die()? That's where it
lives in xen's smpboot.c.
-- Keir
next prev parent reply other threads:[~2005-12-14 20:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-13 15:22 Gerd Knorr
2005-12-13 15:36 ` [Xen-merge] " Zachary Amsden
2005-12-13 16:32 ` Gerd Knorr
2005-12-13 15:58 ` Alan Cox
2005-12-14 19:35 ` Zwane Mwaikambo
2005-12-14 20:15 ` Keir Fraser [this message]
2005-12-15 1:20 ` [Xen-merge] " Zwane Mwaikambo
2005-12-15 13:44 ` Gerd Knorr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=865100f9f39bd64c72af67447023b1cd@cl.cam.ac.uk \
--to=keir.fraser@cl.cam.ac.uk \
--cc=kraxel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-merge@lists.xensource.com \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®