From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 986F5286D70 for ; Fri, 10 Jul 2026 15:14:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783696453; cv=none; b=lTrazeDUcXIjSztI6dHxyBn9PDJU/EAEeVl9Dh73uIRdP2r+uDRUZsyZ5A2ZVSQ3qEAVCEHaiGtDPg1HyldBGTrZPreJcc0t45mvFj41HAksDwGa3Wf2pHsbnO/3J6e5L4pKzbNZ66e/NWqY8lfkEBV1/oCBmNlDPimDJUybWvI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783696453; c=relaxed/simple; bh=S+o07CGsB2yXVWZKEPHm972ZzUJuCHHo/Rajn4YiYaI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cTE9zYjvQaok+oOFLTQftLeWWa9Gf/q8dzQXdngSFsjAabsEuw1j0ILN7KvCjGqa/Oo9ZnoRlxuKou2XGZzKM6wFy03+6w/CK1D18YCfNonlVcKJ/SsNAd4OWIrzWUrsXPwfWNOYsTmEONahQ3x27No5uYHY7Ig/ZnGklg7xGnQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mic7hgd7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IXpsmtP1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mic7hgd7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IXpsmtP1" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66AEclHc1127920 for ; Fri, 10 Jul 2026 15:14:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= t8xr+988QWqirlSbwRDuuvdc9FU1IuRlxyIRd32MgSo=; b=mic7hgd7riKWXIAc wMuL6FGfh3OXLD6c/GqL7XqyF1RwctfV8f+m0AipsFiqQT4+VhqpwcCinuswIkrW LSDd9WPEwPqRH7jB1eoxGRCMktB7ChUKQw2g2rV+OE5j+R3JBM3XnD7mK4+A3fZg 8g0iTK7x6jIyhd3CfV1/ad+nZ8f6ShFC0aROp7oTBvQk62TnSPSsAScVvPzocsJX P64FEqhxPdBNP6pEdVmQeSUfQrGXEJ1FwzcibVm4MqsOUQfZiQjob4P/58fzhJsQ 637dZyBgcoC2tIJI6KgvSDw/LbK9e/td6T9628/epwN3HhnOfMcQrUlhmgU4m2nw rxPBYg== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fay3e118t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Jul 2026 15:14:11 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51bfa45b280so2842491cf.3 for ; Fri, 10 Jul 2026 08:14:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783696451; x=1784301251; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=t8xr+988QWqirlSbwRDuuvdc9FU1IuRlxyIRd32MgSo=; b=IXpsmtP16AFnDPs+kGGnaR8xRwSkeZUiRjc1L/04+5shdyWt1pxZZFg0/ZytS3Sikg GRJjcB3OBzQqNuresVcNeBlmpnDoEP0HbEgo6q611mClAOJOeDDecyVnF8iszUwcuJHi FG/nDRPWPH7QN1PXvdq1K1Kvvzx3CsJb4teAzwOExEOi2iVamSsFLsr+7VwKmNcAkgqd PNB9f2oam+OjfGAbWrPO0+zf0K1ksQx7+7HaW8R7VIhNDOibOdJXsR87fiqDvjD/ePwc 0Z7mcpNLe3v/it/MyAdlVdOgVys6d4oODoi1bpTFwuieH8EBGvtreU8q8QQjX3h8n+Jx iINg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783696451; x=1784301251; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=t8xr+988QWqirlSbwRDuuvdc9FU1IuRlxyIRd32MgSo=; b=ETIj6YhmjSksDmemH5FTJsPv3EystAPtEUEsybqfDajG4+NvuZkDKJOt2r6XlGwrKj pa0Vv9WzyL5RlquUTIMDMD/qqalMgr8wn595A413t8h65rLXe6Mst58INzZCNFTA0/bQ PcchoDUgO/rHwhQFcN5xLO9ciCYF7bGHD6IgxELYP8gtGNO9N8ijEqKuVFcFSEFtp5YX H5JA7RENkIdZ5NKEbAr5/VV44oXYEZ4XsXNSm5ewXT99OCwlGrsldtnm36ou8wnNn8Lm BjE3Ibyo84Yrgh4MyNw/NWzrqx96rm1c++dwjnwOMwH+Orj98P8x+II6e/98F93jaJTP leeA== X-Forwarded-Encrypted: i=1; AHgh+Ro3iBlYyIz4EOF190NMNuSZWfBskf/KSq0NJs/lVFwal6dMamatKYzZsEQWl1KjTJuyxZnQx9Q0kuDwtXs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1ayAb0QaBBKY/uVXvlfI/Wvkh9IpyRj4mlD3e/edIBT1LK4jI J8+Nf7FaiDyfqBk/UwjtZ5qD2CDyrn7psxN/6bqDcVKsaXhQZVoNbYd+mI5i85oiU0MGnPbqeIc dRmrUPhcVHJZe3uSIubQAB4bZzmkJN5ys7jUgZtqez7Is+QnDRdtaXrsXD4QCnXkj4dA= X-Gm-Gg: AfdE7ckpOD49nBJDBAhQodn3vLg57ge4sL+9P4kIRlWqdrip/Bu/K+Iq2Y2AmmGNItt L6/IfqsWs4uElb0EyjfmnreIQhY+DOyiHimymwF6Se2Qi0T9Nqu1G9fZcX3z+y4oLczdGOWtz+I H5B64qAzXH4wUDsizL/Zl4LnoglSH697gqnwKmdzjQHbgpwt8CkKNvXwoV46ZSjImLlB6Y6mcJb 3hCUTM8yuNJCEKtDGmr1ibfCKR9vszHmFcozP/nAgZk1TpI1a5rSZpRsUJwmZDrdj9ooLGzebWn PRiJRc9QryhxDYeihjhoOm4GtJWwj1mLoi2Qa8C1ZfeH0rBWvMBPfy+6bn6Gr0PyBDZCRz7alDp UWXSPs6wG3r2mj6LFvMSneeHFQy9mvo0Gm60= X-Received: by 2002:a05:622a:101:b0:517:8999:6c50 with SMTP id d75a77b69052e-51c8b512840mr100771081cf.8.1783696450984; Fri, 10 Jul 2026 08:14:10 -0700 (PDT) X-Received: by 2002:a05:622a:101:b0:517:8999:6c50 with SMTP id d75a77b69052e-51c8b512840mr100770831cf.8.1783696450567; Fri, 10 Jul 2026 08:14:10 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69a19d78a08sm12347815a12.18.2026.07.10.08.14.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2026 08:14:09 -0700 (PDT) Message-ID: <865cd059-49ed-4922-806c-4c59eb37f5db@oss.qualcomm.com> Date: Fri, 10 Jul 2026 17:14:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] PCI: qcom: Clear Attention Button Present in Slot Capabilities To: Qiang Yu , Manivannan Sadhasivam , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260710-clear_abp_0710-v1-1-efd63ebdaa09@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260710-clear_abp_0710-v1-1-efd63ebdaa09@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDE1MiBTYWx0ZWRfX/k8YDRXB6RFc TlBzmHDA2KhsLIdtcQpVGwQG4Wec/ChJVBeuqhS6Q0mxr9xVdvTI7dOsdgdxEFKu7zch402T6kt fkoFxIzk5rFPJbhS03v0M+zrJwaatxk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDE1MiBTYWx0ZWRfXy7HZrI13m96S cGSHfLmDIFUQjSstqaEyMO75BcKQDJo4DMyg9n/u1VY+MZS4jgSvooB2iGHuc3ZvV+NH+VEPWaN ZdUiZTis7PBYFj9VSEICSxzuwD/WzrNqjZV3QTd5opZGQ/fxAGzTq5MGyjtEbCB42gaPOq0EAwI t4xotI//ELNCWTj45cF218JpD0d+sHD9NpaGaY3eItJTaEffguK+4HJ/bi7eLjnjgTwcQwEAnHM F0a8y/JmFbk7xnpi+lqVR8PTPUUpsCNVfCQBOecSQmVEjnr7ky3EeBPXbA/YNkapph18n+sbtXs Xjknm5yKfXifIKPe0IBgwYcrpzBY44oePIN3Hqc2N+AFtjaugxU4TDbYclAUwnwhtJrkckElev3 cxDqbWrBzjqeDwNIJ0OUvnyaCZpfZ2MThfalQ7e+TNCtNJEtkADwkYzLhTCyUcotfabvTEn912O CNZgKC2MIr8KOEnOLgA== X-Proofpoint-GUID: cFNMGKRsWkd6eTg2Q4kFVEYID6WhKTXA X-Authority-Analysis: v=2.4 cv=HqpG3UTS c=1 sm=1 tr=0 ts=6a510c43 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=Exl5BUTtluaCrdyZuN8A:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: cFNMGKRsWkd6eTg2Q4kFVEYID6WhKTXA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-10_04,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100152 On 7/10/26 3:20 PM, Qiang Yu wrote: > Qcom PCIe Root Ports advertise the Attention Button Present (ABP) bit in > the Slot Capabilities register, but the slots have no attention button. > > When ABP is set, pcie_enable_notification() in the pciehp driver enables > the Attention Button Pressed interrupt (ABPE) and leaves the Presence > Detect Changed interrupt (PDCE) disabled. As a result, presence detect > changes are never reported and surprise hot-plug detection that relies on > Presence Detect Changed events does not work. > > While at it, rename qcom_pcie_set_slot_nccs() to qcom_pcie_set_slot_cap() > since it now programs more than just the NCCS field. > > Signed-off-by: Qiang Yu > --- Reviewed-by: Konrad Dybcio Tested-by: Konrad Dybcio # X1E80100 CRD Konrad