From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5C3BECAAD1 for ; Sat, 27 Aug 2022 04:20:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238547AbiH0EUj (ORCPT ); Sat, 27 Aug 2022 00:20:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbiH0EUf (ORCPT ); Sat, 27 Aug 2022 00:20:35 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EF6814085; Fri, 26 Aug 2022 21:20:33 -0700 (PDT) Received: from dggpeml500026.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4MF3Nm3w3LzGpkW; Sat, 27 Aug 2022 12:18:48 +0800 (CST) Received: from [10.174.178.66] (10.174.178.66) by dggpeml500026.china.huawei.com (7.185.36.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 27 Aug 2022 12:20:30 +0800 Message-ID: <865db8c4-63c1-d2f4-585f-26c3be713948@huawei.com> Date: Sat, 27 Aug 2022 12:20:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0.2 Subject: Re: [PATCH -next] net: sched: sch_skbprio: add support for qlen statistics of each priority in sch_skbprio To: Jakub Kicinski CC: , , , , , , , , , References: <20220825102745.70728-1-shaozhengchao@huawei.com> <20220826194616.37abfe9e@kernel.org> From: shaozhengchao In-Reply-To: <20220826194616.37abfe9e@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.66] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500026.china.huawei.com (7.185.36.106) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/8/27 10:46, Jakub Kicinski wrote: > On Thu, 25 Aug 2022 18:27:45 +0800 Zhengchao Shao wrote: >> diff --git a/net/sched/sch_skbprio.c b/net/sched/sch_skbprio.c >> index 7a5e4c454715..fe2bb7bf9d2a 100644 >> --- a/net/sched/sch_skbprio.c >> +++ b/net/sched/sch_skbprio.c >> @@ -83,6 +83,7 @@ static int skbprio_enqueue(struct sk_buff *skb, struct Qdisc *sch, >> __skb_queue_tail(qdisc, skb); > > The skb queue called "qdisc" here (confusingly) already maintains > a length (also called qlen). Can we just access that variable instead > of maintaining the same value manually? > >> qdisc_qstats_backlog_inc(sch, skb); >> q->qstats[prio].backlog += qdisc_pkt_len(skb); >> + q->qstats[prio].qlen++; > Hi Jakub: Thank you for your reply. You are right, I have missed something. This patch seems to be unnecessary. Zhengchao Shao