From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932976AbcHYLdq (ORCPT ); Thu, 25 Aug 2016 07:33:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48776 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758630AbcHYLdp (ORCPT ); Thu, 25 Aug 2016 07:33:45 -0400 Subject: Re: [PATCH] x86/mce: Use kmalloc_array() in mce_chrdev_read() To: SF Markus Elfring , linux-edac@vger.kernel.org, x86@kernel.org, Borislav Petkov , "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , Tony Luck References: <88a63817-f601-28ce-ed2f-ffeb28512528@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Paolo Bonzini Message-ID: <865fa33f-2339-cafe-d3cc-ccf119c9a50d@redhat.com> Date: Thu, 25 Aug 2016 13:33:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <88a63817-f601-28ce-ed2f-ffeb28512528@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 25 Aug 2016 11:33:44 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/08/2016 11:17, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 25 Aug 2016 11:00:05 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus reuse the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > * Replace the specification of a data type by a pointer dereference > to make the corresponding size determination a bit safer according to > the Linux coding style convention. > > Signed-off-by: Markus Elfring > --- > arch/x86/kernel/cpu/mcheck/mce.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c > index 79d8ec8..0bc831d 100644 > --- a/arch/x86/kernel/cpu/mcheck/mce.c > +++ b/arch/x86/kernel/cpu/mcheck/mce.c > @@ -1901,7 +1901,7 @@ static ssize_t mce_chrdev_read(struct file *filp, char __user *ubuf, > unsigned prev, next; > int i, err; > > - cpu_tsc = kmalloc(nr_cpu_ids * sizeof(long), GFP_KERNEL); > + cpu_tsc = kmalloc_array(nr_cpu_ids, sizeof(*cpu_tsc), GFP_KERNEL); > if (!cpu_tsc) > return -ENOMEM; > > Reviewed-by: Paolo Bonzini I think you can post the patches with a larger granularity (e.g. one for all of arch/x86/kernel). Paolo