From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1551183CC3 for ; Fri, 29 Aug 2025 15:04:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756479879; cv=none; b=VA4g9j6V9xMG9zddtxq3RkJ01JKCGcKbqH6dbkGbxC3306FfQajYb1C1sGiXSwefQjNg6Reg5CZ130riQbxUOQ3lZ55hlxdXJi87QX4U+66kw3oA1tI2x16SZ0bVvHKSOzosDrP/WxvZRzv1ZGsxq3rdJ/QotDZtn1Ma5uF8lCE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756479879; c=relaxed/simple; bh=h0bS6nde0r5gPiUlkTLFoDI7mpvVlgMMqMLvnUG6IGM=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=Gh7k+0hhOSAvLLJYGSXsWg+KulE3QDsX5r0o7AGExdKoHiOeP2jGBj9diKfBDGVm+zX55q2uuBi8FJv3WdTaGliQGObUNMPnfmpzp8S6uC/WcF9N+QtCNrlM/PT/13v5et+0/00QMhEW3JXh/7bBON1aRReLmCxZAwLNsTM25VE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RqeIBF0U; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RqeIBF0U" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8579BC4CEF0; Fri, 29 Aug 2025 15:04:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756479878; bh=h0bS6nde0r5gPiUlkTLFoDI7mpvVlgMMqMLvnUG6IGM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RqeIBF0UEpPPXZ8Lr7uMRvz6xHJVBjbvYR9KCy/1NpxMORLmELCKYMyBYqzsMcMM3 sgsCiDaqmAsaw7RutTdHHY6sjB1FgxYsZC5ym3/fmXM9FrE+hhRCx0Iebze3Sg9oBA W2KQq26lDddF8t4RF+FZMvT4lOwcrnMDWoMqqPf8c6hyrbGzq/fF/OKb5uACwwgvFH 1K8f7SmRRtk+XhPFWL6ykuLYu76wRsriU+or/uwP3H/fTCTuUdF+lfjuD13xjnSkCS X6V2R55u4Q29xzkRfJjZaGOIsNwfzMJxQagTS0DkGxUpyvGkVUvRe6aWO1vO6CjG5a P6ajjgDUqVK8w== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1us0ea-00000001cZ8-13qy; Fri, 29 Aug 2025 15:04:36 +0000 Date: Fri, 29 Aug 2025 16:04:35 +0100 Message-ID: <865xe6dv98.wl-maz@kernel.org> From: Marc Zyngier To: Qianfeng Rong Cc: Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] irqchip: Use int type to store negative error codes In-Reply-To: <20250829132020.82077-1-rongqianfeng@vivo.com> References: <20250829132020.82077-1-rongqianfeng@vivo.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: rongqianfeng@vivo.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 29 Aug 2025 14:20:19 +0100, Qianfeng Rong wrote: > > Change the 'ret' variable from unsigned int to int to store negative error > codes or zero returned by other functions. > > Storing the negative error codes in unsigned type, doesn't cause an issue > at runtime but it's ugly. Additionally, assigning negative error codes to > unsigned type may trigger a GCC warning when the -Wsign-conversion flag is > enabled. > > Signed-off-by: Qianfeng Rong For the GICv3 code: Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.