From: Robin Murphy <robin.murphy@arm.com>
To: Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org,
Arnaud Pouliquen <arnaud.pouliquen@st.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Jonathan Cameron <jic23@kernel.org>,
Alexandre Torgue <alexandre.torgue@st.com>
Subject: Re: [PATCH] IIO: ADC: stm32-dfsdm: avoid unused-variable warning
Date: Thu, 11 Jan 2018 14:27:29 +0000 [thread overview]
Message-ID: <866335ff-d9a8-99c0-0946-82b3f207f266@arm.com> (raw)
In-Reply-To: <20180111103510.1408292-1-arnd@arndb.de>
On 11/01/18 10:34, Arnd Bergmann wrote:
> Building with CONFIG_OF disabled produces a compiler warning:
>
> drivers/iio/adc/stm32-dfsdm-core.c: In function 'stm32_dfsdm_probe':
> drivers/iio/adc/stm32-dfsdm-core.c:245:22: error: unused variable 'pnode' [-Werror=unused-variable]
>
> This removes the variable and open-codes it in the only place
> it gets used to avoid that warning.
>
> Fixes: bed73904e76f ("IIO: ADC: add stm32 DFSDM core support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/iio/adc/stm32-dfsdm-core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
> index 72427414db7f..6cd655f8239b 100644
> --- a/drivers/iio/adc/stm32-dfsdm-core.c
> +++ b/drivers/iio/adc/stm32-dfsdm-core.c
> @@ -242,7 +242,6 @@ MODULE_DEVICE_TABLE(of, stm32_dfsdm_of_match);
> static int stm32_dfsdm_probe(struct platform_device *pdev)
> {
> struct dfsdm_priv *priv;
> - struct device_node *pnode = pdev->dev.of_node;
> const struct of_device_id *of_id;
> const struct stm32_dfsdm_dev_data *dev_data;
> struct stm32_dfsdm *dfsdm;
> @@ -254,7 +253,7 @@ static int stm32_dfsdm_probe(struct platform_device *pdev)
>
> priv->pdev = pdev;
>
> - of_id = of_match_node(stm32_dfsdm_of_match, pnode);
> + of_id = of_match_node(stm32_dfsdm_of_match, pdev->dev.of_node);
> if (!of_id->data) {
> dev_err(&pdev->dev, "Data associated to device is missing\n");
> return -EINVAL;
FWIW, it looks like this whole lot could be cleaned up by using
of_device_get_match_data().
Robin.
next prev parent reply other threads:[~2018-01-11 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 10:34 Arnd Bergmann
2018-01-11 14:27 ` Robin Murphy [this message]
2018-01-11 17:38 ` Arnaud Pouliquen
2018-01-14 12:07 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=866335ff-d9a8-99c0-0946-82b3f207f266@arm.com \
--to=robin.murphy@arm.com \
--cc=alexandre.torgue@st.com \
--cc=arnaud.pouliquen@st.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®