From: Detlev Casanova <detlev.casanova@collabora.com>
To: Mark Brown <broonie@kernel.org>,
Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: linux-kernel@vger.kernel.org,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org, linux-sound@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@collabora.com,
alexandre.belloni@bootlin.com, thomas.petazzoni@bootlin.com
Subject: Re: [REGRESSION] Re: [PATCH v1] ASoC: rockchip: i2s_tdm: Re-add the set_sysclk callback
Date: Wed, 18 Feb 2026 12:17:04 -0500 [thread overview]
Message-ID: <86644ac4-6ffd-48c6-a79d-8e8144f18e2e@collabora.com> (raw)
In-Reply-To: <e1cea076-fb1e-475e-b6a5-383370a69722@sirena.org.uk>
Hi Mark,
On 2/18/26 12:10, Mark Brown wrote:
> On Wed, Feb 18, 2026 at 05:51:51PM +0100, Luca Ceresoli wrote:
>> On Wed Feb 18, 2026 at 5:01 PM CET, Detlev Casanova wrote:
>> + if (!mclk_rate)
>> + mclk_rate = DEFAULT_MCLK_FS * params_rate(params);
>> With this, and DEFAULT_MCLK_FS defined to 256, arecord is working again.
> I did have the revert queued, but a fix would be even better if the
> patch could be sent?
A fix will follow a bit later today, then.
Detlev.
next prev parent reply other threads:[~2026-02-18 17:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 16:31 Detlev Casanova
2025-01-21 18:10 ` Mark Brown
2026-02-10 9:54 ` [REGRESSION] " Luca Ceresoli
2026-02-17 19:22 ` Mark Brown
2026-02-18 12:14 ` Luca Ceresoli
2026-02-18 12:19 ` Luca Ceresoli
2026-02-18 16:01 ` Detlev Casanova
2026-02-18 16:51 ` Luca Ceresoli
2026-02-18 17:10 ` Mark Brown
2026-02-18 17:17 ` Detlev Casanova [this message]
2026-02-18 17:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86644ac4-6ffd-48c6-a79d-8e8144f18e2e@collabora.com \
--to=detlev.casanova@collabora.com \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=frattaroli.nicolas@gmail.com \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=perex@perex.cz \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®