mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Reizer, Eyal" <eyalr@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: "kvalo@codeaurora.org" <kvalo@codeaurora.org>,
	"���� �����" <eyalreizer@gmail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>
Subject: RE: [PATCHv2] wlcore: spi: add wl18xx support
Date: Thu, 21 Apr 2016 11:07:37 +0000	[thread overview]
Message-ID: <8665E2433BC68541A24DFFCA87B70F5B360C2E14@DFRE01.ent.ti.com> (raw)
In-Reply-To: <20160419184627.GG3217@sirena.org.uk>

> 
> > Thanks! Glad the illustration helped.
> > I will try it out again as if i recall cotrectly, i did try that l, and it didnt produce
> the correct waveform, but perhaps i didnt understand the usage of
> .cs_change correctly.
> > Will double check anyway.
> 
> It could also be a bug in your controller driver, it's common for them to not
> handle cs_change correctly (at least those that open code the message loop,
> obviously modern ones just factor this out into the core).

Tried looking into using cs_change and not sure I understand how it would do what I need.
According to, include/linux/spi/spi.h:

* All SPI transfers start with the relevant chipselect active.  Normally
* it stays selected until after the last transfer in a message.  Drivers
* can affect the chipselect signal using cs_change.
*
* (i) If the transfer isn't the last one in the message, this flag is
* used to make the chipselect briefly go inactive in the middle of the
* message.  Toggling chipselect in this way may be needed to terminate
* a chip command, letting a single spi_message perform all of group of
* chip transactions together.

Now, in my case I need the CS pin to go inactive and stay inactive during the transfer 
of the next byte for completing the SPI init correctly (sending the extra clock cycles while CS is inactive)
If I read the above correctly, CS will only briefly go inactive but will when the next byte 
is sent it will be active again.
What am I missing?

Best Regards,
Eyal

  reply	other threads:[~2016-04-21 11:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1460273570-12298-1-git-send-email-eyalr@ti.com>
2016-04-10  7:37 ` Reizer, Eyal
2016-04-17 22:19   ` Arnd Bergmann
2016-04-18  5:55     ` Reizer, Eyal
2016-04-18 14:57       ` Arnd Bergmann
2016-04-19  9:05         ` Reizer, Eyal
2016-04-19 14:21           ` Arnd Bergmann
2016-04-19 14:35             ` Reizer, Eyal
2016-04-19 17:12           ` Mark Brown
     [not found]             ` <sjdvun1fuj4nyi0bgf268g53.1461086401627@email.android.com>
2016-04-19 17:27               ` Mark Brown
     [not found]                 ` <oe8hqfknrcljrjawnrxlohvr.1461087275186@email.android.com>
2016-04-19 17:54                   ` Mark Brown
     [not found]                     ` <us0dopt1inbrt0x47njgc2vy.1461089085965@email.android.com>
2016-04-19 18:46                       ` Mark Brown
2016-04-21 11:07                         ` Reizer, Eyal [this message]
2016-04-21 11:11                           ` Mark Brown
2016-04-19 17:07       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8665E2433BC68541A24DFFCA87B70F5B360C2E14@DFRE01.ent.ti.com \
    --to=eyalr@ti.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=eyalreizer@gmail.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®