From: Luka Gejak <luka.gejak@linux.dev>
To: Leonard Lausen <leonard@lausen.nl>, Ping-Ke Shih <pkshih@realtek.com>
Cc: leonard@lausen.nl, "David Härdeman" <david@hardeman.nu>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Heiko Stuebner" <heiko@sntech.de>,
linux-wireless@vger.kernel.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH rtw-next v3 1/2] wifi: rtw88: 8822c: filter hardware-handled control frames on SDIO
Date: Tue, 17 Nov 2026 06:43:29 +0100 [thread overview]
Message-ID: <8667155C-5EFC-47A7-887C-A2AC8F180F33@linux.dev> (raw)
In-Reply-To: <20261116205739.462458-4-leonard@lausen.nl>
On November 16, 2026 9:57:38 PM GMT+01:00, Leonard Lausen
<leonard@lausen.nl> wrote:
>RTL8822C forwards every control-frame subtype to the host by default.
>ACK, Block Ack, RTS and CTS frames are handled by hardware, but forwarding
>them also adds small SDIO transfers to the data path.
>
>Clear these four subtypes from the normal SDIO RX filter, retaining BAR,
>PS-Poll and the remaining subtypes. Cache the current FIF_CONTROL request
>separately from that default, using the full requested flags even when
>changed_flags does not contain FIF_CONTROL.
>
>Use a shared writer in filter configuration, every chip initializer and
>both beamforming paths. This keeps the monitor override across IPS wake,
>MAC reinitialization and beamforming, while removing the request restores
>the current normal filter.
>
>Limit the reduced default to SDIO, where profiling identified this
>overhead. PCIe and USB receive paths have not been tested with it.
>FriendlyElec's RTL8822CS driver also filters control frames at startup;
>this change retains additional subtypes for mac80211.
>
>Link: https://github.com/friendlyarm/rtl8822cs/blob/c8b944a34bba2116fcdb060362bde40242bb87e5/hal/rtl8822c/rtl8822c_halinit.c
>Suggested-by: Luka Gejak <luka.gejak@linux.dev>
>Signed-off-by: Leonard Lausen <leonard@lausen.nl>
>---
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Best regards,
Luka Gejak
next prev parent reply other threads:[~2026-11-17 5:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 20:57 [PATCH rtw-next v3 0/2] wifi: rtw88: reduce RTL8822CS SDIO request overhead Leonard Lausen
2026-11-16 20:57 ` [PATCH rtw-next v3 1/2] wifi: rtw88: 8822c: filter hardware-handled control frames on SDIO Leonard Lausen
2026-11-17 5:43 ` Luka Gejak [this message]
2026-11-16 20:57 ` [PATCH rtw-next v3 2/2] wifi: rtw88: sdio: combine free TX page register reads Leonard Lausen
2026-11-17 5:43 ` Luka Gejak
2026-11-16 21:46 ` [PATCH rtw-next v3 0/2] wifi: rtw88: reduce RTL8822CS SDIO request overhead Luka Gejak
2026-11-17 0:54 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8667155C-5EFC-47A7-887C-A2AC8F180F33@linux.dev \
--to=luka.gejak@linux.dev \
--cc=david@hardeman.nu \
--cc=heiko@sntech.de \
--cc=leonard@lausen.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®