From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD9363115AF for ; Fri, 6 Mar 2026 16:07:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772813244; cv=none; b=HR4uRhOQi/qP8CD9tIOfsXemwEhOoocoVQ140ct12yXuDzhPHAkgmtI1FuiO4KRrN5mnT2CftYsTaOoqRTCkBiUJM8fsn36Tvn2nYtCct/PWt6Lclg4kUrB5sMlgJ0IVBk4yq3sIOPI+KEB0DiQWCTjEAgLHmxqtkqZbooZd5QM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772813244; c=relaxed/simple; bh=cdxKXLY4dYCWYDvJkWDm/Fa2uK8iUSliE1rdVGBSmNA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ofygN6Y3HIa6HbaEV6WBfAWIWRlSMf52DbiTke1dcUbGPLq40bhnUlvuWy0YYQov8esjZ54Y5xzo653oCbLHbMBhxGnzFT1zObWxN7JcHJcxJ4b1C+YF1gHMMCDK54l55804/Y+Jx+INStv+F73Uu+hlUS9WFYjv+dLUKBxp7JE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BdKLaLkZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cRYb4TPe; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BdKLaLkZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cRYb4TPe" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626FrJBC2577866 for ; Fri, 6 Mar 2026 16:07:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= y6rjc/+TCoxfFxZSfhxFAwcD/5kiCHA+X7AyfBBMsZ4=; b=BdKLaLkZQjwvwMDK XgygIWHhaBEO3qrdbb0d8Z/qOV8kdKQ/CkXjWvjBUpGg8lyaHA3amOufArHH45MB K5q1PmhU5s/x/9suZnVPZFGtFLAkOiO+EVqGsm2DNnVE1+GD0xgmv91wzRj/6tlR RrDvou7ExYtYeZIkiDJhbZqTg6BBGmvW/dk2AR3FV6g8hTQhiplYcVYqymWnvJXV v2ZvUh4dkukJtbSNxnqOQu2Ly7RTvSpVtCegRy849GvF9XytaXABTB7QriY5TORc Of/zUFf701HS1GW9MWUjdq1DKlJo6Fw6468sDDMIKbBVNMBIXk9Y5HBYbA6R+TeQ KrTpRA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqfg6bu2e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:07:22 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ae3e462daeso32491345ad.0 for ; Fri, 06 Mar 2026 08:07:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772813242; x=1773418042; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=y6rjc/+TCoxfFxZSfhxFAwcD/5kiCHA+X7AyfBBMsZ4=; b=cRYb4TPeUUZEfLdjIiRXfU9DBzQrzMk7n4qPA0a4KJGwG8lKekLIsu/yp/LP9cgzIR +O55TSXRJwQ5YKzWQhynlhiD4qvpH1AGE5JitMnVIFDdSVWk5to3aSgLZRuXdz6BVGle yvRG/zPDg7ryTAQbOHpVCztjuBs/hfQeVe5RRes3ui8HEzHEmHEasOl3NQ2tlgPR8+Ls tA80Ul/JCKT08T9w7+7Ru7U+wgoJaDiaU8xl1nr8RjDWB+Ok6w9a2Mms+Zki5C0TzlSJ 9L1RaTa5vVK+dwezuemqXVunDuqrxEe4M0gmDRewupkVFbwQ4tVtE9UweH+qZnzKh5Y4 wl0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772813242; x=1773418042; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y6rjc/+TCoxfFxZSfhxFAwcD/5kiCHA+X7AyfBBMsZ4=; b=sN8E5CbgAqp4NAM8QymdSJpUDQ7u0RC3yNt5OlSWGCI3FWecJoKXqZk6Wcd+XJ8Wj+ iafPTFpHPbSdCCbDBwVZvVArkQtTKZwUSltxqz+Q5VJbqXQ1+A3kpz27CNwurWJipuaE LFPQ7mEj2acbUYDpkzBcFDSRithSDOFjdmiWFBraePX4uyCx6pwSQr+hO1Kj5fnzrZ7Y 2WLvpuvp/8LbnN9duHLndeAu7No3F/t5xKayxbc9bkZtoDukTTBFD+s7v5ojUWxVPytb eFcS3rU1Hxk5QhOTkItUd48YCUuaIWaLWi/mM+x55FxGCj0ft7nRgFhb+LhC91gMqBaA bW5g== X-Forwarded-Encrypted: i=1; AJvYcCWasUDb2+X+0Myr1mIFuUvkgmReHt2TowJALpBNi84hy1KL+4EujWC0wr5euwk+JmOKctZ0f9DIEMJRlck=@vger.kernel.org X-Gm-Message-State: AOJu0YyApFiJo+slaK/SaDYqxHGceFRi7ET5KpOFvP0U0N5qir/q3xAA HBP5wDzX99HcXprSFMdoJiqNzJ0GtOJGatIrp2Z8lsFsxbWb8J3vf3RxIhDURSP30hymhy0W7F8 d0PrqjkTpGlcx81U49YGLgpQbAgiLHyz28v9D1QTjzeWk0e7eKpPnUpVMKvyxNVe9GQE= X-Gm-Gg: ATEYQzylvvXQiwwtO0FNHVVpWLYz+bTd/CbZK+3R8yiphpaLJuzKQU3AQ9/KeJ3cTQ2 ZNjzlpv5Fegdb9u1P0bxdB5rm/7L+Czmw4LLOMMoyuT0hNsOvMyeO+EcNU3T6eXt2EZne2eBV08 vX4eQeDmWgzDI7mJYTYoBqBFrR75gMmmea84BMSAJwE6Lis/Koi6whbDyqgw7dNmpEDDq9KCAzU 47wpV+16P+Q5O1kTEDSIvSbv0KFZEXp5irBIe2ZNdwkKiKZ/e+OA8fknKPWMN1OPI7PWEXqVQQb ayyPwCQ6pjtkVyPY16RR57uWfs9WM9khHX6g3PxqMg+udc2oJ91JrfQfoZv1lwEcUsktSJz0HYF Rt1WZ3vjFzZHNXJWmCKPB/7DLjm+Y1Fhi0zzqpz8YWIizfA== X-Received: by 2002:a17:902:d585:b0:2ae:608d:ecc0 with SMTP id d9443c01a7336-2ae89ebec33mr1836555ad.3.1772813241759; Fri, 06 Mar 2026 08:07:21 -0800 (PST) X-Received: by 2002:a17:902:d585:b0:2ae:608d:ecc0 with SMTP id d9443c01a7336-2ae89ebec33mr1836095ad.3.1772813241029; Fri, 06 Mar 2026 08:07:21 -0800 (PST) Received: from [192.168.1.11] ([106.222.228.80]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83f770ffsm34727825ad.45.2026.03.06.08.07.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Mar 2026 08:07:20 -0800 (PST) Message-ID: <866adc34-1a42-4abf-a95f-76259d86d779@oss.qualcomm.com> Date: Fri, 6 Mar 2026 21:37:16 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] soc: qcom: ubwc: disable bank swizzling for Glymur platform To: Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Rob Clark , Abel Vesa Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260228-fix-glymur-ubwc-v2-1-70819bd6a6b4@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: GkoFML3iquycDulYG9CwHlmzDcXYKj4O X-Proofpoint-ORIG-GUID: GkoFML3iquycDulYG9CwHlmzDcXYKj4O X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1MiBTYWx0ZWRfX3LmSYSuRQO0r Lx2fWXs7nsCn9IP6bIJtPPudxOMNqyh/842B59oo8bYHYgmmvNbd7OLvV8A44xX7IHuRkmyJ4OD ovlGCeZbim+UCvZtW/K88dJ4knBfeZp1qWkueQy9Fr6afry+N1zSJridm/GJ0GBocapMI840+Th VoWS+mfJUkJJOcJpjhBip4OkiclPmEPdWamITZel5rySm1vV6MWiYz/ILst2BVQmZ1rBlVtsHwB Kmft+mvyS8KSfoh7kywwwBhECWvOmyLzJL+frg7M9s+8dDijFDdJFmYCKKdnRQMoq6ivHkztdrC HeJ/tgTcm+xRUwf/q2o1JrOrHsAQMZiOuMeRr3IwhCfCCtqT7NtqFqSbepzySDfk+7giPN6b1We GnxYfVBoXwGt6qw4MrBJ98imoLzL6I+LiZFtEpAApcaIQA2M4EnKIOLTgNatIdsjivD/p5T+IkI ZS4HIc0/upmefJOJu+Q== X-Authority-Analysis: v=2.4 cv=XKg9iAhE c=1 sm=1 tr=0 ts=69aafbba cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=uL+hpB4jSAN/g3a/thif0w==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=COk6AnOGAAAA:8 a=yqkthdN8_KF3SHEi0AoA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 clxscore=1015 priorityscore=1501 phishscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060152 On 3/6/2026 8:45 PM, Dmitry Baryshkov wrote: > On Sat, Feb 28, 2026 at 08:34:27PM +0200, Dmitry Baryshkov wrote: >> Due to the way the DDR controller is organized on Glymur, hardware >> engineers strongly recommended disabling UBWC bank swizzling on Glymur. >> Follow that recommendation. >> >> Fixes: 9b21c3bd2480 ("soc: qcom: ubwc: Add configuration Glymur platform") >> Signed-off-by: Dmitry Baryshkov >> --- >> Changes in v2: >> - Fix the syntax error... >> - Link to v1: https://lore.kernel.org/r/20260228-fix-glymur-ubwc-v1-1-d80e3fe0dcc7@oss.qualcomm.com >> --- >> drivers/soc/qcom/ubwc_config.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c >> index 1c25aaf55e52..8304463f238a 100644 >> --- a/drivers/soc/qcom/ubwc_config.c >> +++ b/drivers/soc/qcom/ubwc_config.c >> @@ -231,8 +231,7 @@ static const struct qcom_ubwc_cfg_data x1e80100_data = { >> static const struct qcom_ubwc_cfg_data glymur_data = { >> .ubwc_enc_version = UBWC_5_0, >> .ubwc_dec_version = UBWC_5_0, >> - .ubwc_swizzle = UBWC_SWIZZLE_ENABLE_LVL2 | >> - UBWC_SWIZZLE_ENABLE_LVL3, >> + .ubwc_swizzle = 0, >> .ubwc_bank_spread = true, >> /* TODO: highest_bank_bit = 15 for LP_DDR4 */ >> .highest_bank_bit = 16, > > Carrying over from v1 discussion. > > Reviewed-by: Akhil P Oommen Sorry, please use my oss email instead: Reviewed-by: Akhil P Oommen -Akhil. > > It depends on the fix which is currently a part of msm-fixes for the > device to function correctly. Raised the question on IRC regarding the > immutable tag or any other proper way to merge it. > >> >> --- >> base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f >> change-id: 20260228-fix-glymur-ubwc-f673d5ca0581 >> >> Best regards, >> -- >> With best wishes >> Dmitry >> >