From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79278C4167B for ; Thu, 7 Dec 2023 22:19:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1444093AbjLGWT0 (ORCPT ); Thu, 7 Dec 2023 17:19:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232173AbjLGWTW (ORCPT ); Thu, 7 Dec 2023 17:19:22 -0500 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 967B610F1; Thu, 7 Dec 2023 14:19:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1701987565; bh=86p3ylrkbz2hpcmZExuM50REXyynwKwbcr5XPixsGws=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qNhzJPTYRkdipYePc/C6vS7fT5ohZ8VF4yqLBsoiWKJ3QpmsJa1zgc6AEATOzt7yh VgjauIWncZhzOhve0lJbPCv/ls4qL30vMlIQ9MXyPuPQlvyRIIz9PmzvmPDbIf8elc UkzCxVx2Y7NtbSw/4tVIinVsaOg4hYSvnUuWF3sOII/1mz8spT9b3h7Li5adn7Do7x ceWpIs8a/JwvnjzEGd8bzFXiZHNE1rhfxsc36nDaIIpMFZozelByoNKoXDl9ZhXgJY +9LrsZbpDjTc1IAWJODbTqcXl/cytdiGIVBwMhOahh3DzbiPAhDDeodzOpzeYwyP8r CKppzR//kmkPw== Received: from [192.168.104.112] (Sansfil-Eduroam-Externe-212-2.polymtl.ca [132.207.212.2]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4SmTG55KTRzFpv; Thu, 7 Dec 2023 17:19:25 -0500 (EST) Message-ID: <866d40a8-4e0c-465c-ab8c-b5d864c1a668@efficios.com> Date: Thu, 7 Dec 2023 17:19:24 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ring-buffer: Add offset of events in dump on mismatch Content-Language: en-US To: Steven Rostedt , LKML , Linux Trace Kernel Cc: Masami Hiramatsu , Mark Rutland References: <20231207171613.0592087d@gandalf.local.home> From: Mathieu Desnoyers In-Reply-To: <20231207171613.0592087d@gandalf.local.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-12-07 17:16, Steven Rostedt wrote: [...] > diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c > index 8d2a4f00eca9..b10deb8a5647 100644 > --- a/kernel/trace/ring_buffer.c > +++ b/kernel/trace/ring_buffer.c > @@ -3424,23 +3424,27 @@ static void dump_buffer_page(struct buffer_data_page *bpage, > case RINGBUF_TYPE_TIME_EXTEND: > delta = rb_event_time_stamp(event); > ts += delta; > - pr_warn(" [%lld] delta:%lld TIME EXTEND\n", ts, delta); > + pr_warn(" %x: [%lld] delta:%lld TIME EXTEND\n", Please prefix hex values with "0x", as in: pr_warn(" 0x%x: [%lld] delta:%lld TIME EXTEND\n" Otherwise it can be confusing. Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com