Re: [PATCH] sched/fair: Remove cfs_rq::nr_spread_over and cfs_rq::exec_clock

[Chuyi Zhou <zhouchuyi@bytedance.com>]

在 2024/7/17 19:25, Chengming Zhou 写道:
> On 2024/7/17 19:07, Vishal Chourasia wrote:
>> On Tue, Jul 16, 2024 at 11:06:34PM +0800, Chuyi Zhou wrote:
>>> cfs_rq::nr_spread_over and cfs_rq::exec_clock are not used anymore in
>>> eevdf. Remove them from struct cfs_rq.
>>>
>>
>> nr_spread_over tracks the number of instances where the difference
>> between a scheduling entity's virtual runtime and the minimum virtual
>> runtime in the runqueue exceeds three times the scheduler latency,
>> indicating significant disparity in task scheduling.
>> Commit that removed its usage: 5e963f2bd: sched/fair: Commit to EEVDF
>>
>>
>> cfs_rq->exec_clock was used to account for time spent executing tasks.
>> Commit that removed its usage: 5d69eca542ee1 sched: Unify runtime
>> accounting across classes
>>
>>> Signed-off-by: Chuyi Zhou <zhouchuyi@bytedance.com>
>>
>> Acked-by: Vishal Chourasia <vishalc@linux.ibm.com>
> 
> Looks good to me! Maybe it's better to add these to your changelog.
> 
> Reviewed-by: Chengming Zhou <chengming.zhou@linux.dev>
> 
> Thanks.



Thanks, will do this later.