From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751844AbcFFGmT (ORCPT ); Mon, 6 Jun 2016 02:42:19 -0400 Received: from nasmtp01.atmel.com ([192.199.1.245]:16965 "EHLO ussmtp01.atmel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751118AbcFFGmQ (ORCPT ); Mon, 6 Jun 2016 02:42:16 -0400 Subject: Re: [PATCH v3 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver To: Rob Herring References: <1464677903-28412-1-git-send-email-songjun.wu@atmel.com> <1464677903-28412-3-git-send-email-songjun.wu@atmel.com> <20160602231609.GA24529@rob-hp-laptop> CC: , , , , , Kumar Gala , , Ian Campbell , Pawel Moll , Mark Rutland From: "Wu, Songjun" Organization: ATMEL Message-ID: <867b83cb-c3c2-f53d-7c41-0d6983dc8468@atmel.com> Date: Mon, 6 Jun 2016 14:42:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160602231609.GA24529@rob-hp-laptop> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, Thank you for your comments. On 6/3/2016 07:16, Rob Herring wrote: > On Tue, May 31, 2016 at 02:58:23PM +0800, Songjun Wu wrote: >> DT binding documentation for ISC driver. >> >> Signed-off-by: Songjun Wu >> --- >> >> Changes in v3: >> - Remove the 'atmel,sensor-preferred'. >> - Modify the isc clock node according to the Rob's remarks. >> >> Changes in v2: >> - Remove the unit address of the endpoint. >> - Add the unit address to the clock node. >> - Avoid using underscores in node names. >> - Drop the "0x" in the unit address of the i2c node. >> - Modify the description of 'atmel,sensor-preferred'. >> - Add the description for the ISC internal clock. >> >> .../devicetree/bindings/media/atmel-isc.txt | 88 ++++++++++++++++++++++ >> 1 file changed, 88 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/atmel-isc.txt >> >> diff --git a/Documentation/devicetree/bindings/media/atmel-isc.txt b/Documentation/devicetree/bindings/media/atmel-isc.txt >> new file mode 100644 >> index 0000000..2ae1d60 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/atmel-isc.txt >> @@ -0,0 +1,88 @@ >> +Atmel Image Sensor Controller (ISC) >> +---------------------------------------------- >> + >> +Required properties for ISC: >> +- compatible >> + Must be "atmel,sama5d2-isc" >> +- reg >> + Physical base address and length of the registers set for the device; >> +- interrupts >> + Should contain IRQ line for the ISI; >> +- clocks >> + List of clock specifiers, corresponding to entries in >> + the clock-names property; >> + Please refer to clock-bindings.txt. >> +- clock-names >> + Required elements: "hclock", "ispck". >> +- pinctrl-names, pinctrl-0 >> + Please refer to pinctrl-bindings.txt. >> +- isc-ispck >> + The clock for the ISC digital pipeline. >> + - compatible >> + Must be "atmel,sama5d2-isc-ispck". >> + - clock-cells >> + From common clock binding; should be set to 0. >> + - clocks >> + The clock source phandles. >> +- isc-mck >> + The clock for the image sensor. >> + - compatible >> + Must be "atmel,sama5d2-isc-mck". >> + - clock-cells >> + From common clock binding; should be set to 0. >> + - clocks >> + The clock source phandles. >> + >> +ISC supports a single port node with parallel bus. It should contain one >> +'port' child node with child 'endpoint' node. Please refer to the bindings >> +defined in Documentation/devicetree/bindings/media/video-interfaces.txt. >> + >> +Example: >> +isc: isc@f0008000 { >> + compatible = "atmel,sama5d2-isc"; >> + reg = <0xf0008000 0x4000>; >> + interrupts = <46 IRQ_TYPE_LEVEL_HIGH 5>; >> + clocks = <&isc_clk>, <&isc_ispck>; >> + clock-names = "hclock", "ispck"; >> + >> + port { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + isc_0: endpoint { >> + remote-endpoint = <&ov7740_0>; >> + hsync-active = <1>; >> + vsync-active = <0>; >> + pclk-sample = <1>; >> + }; >> + }; >> + >> + isc_ispck: isc-ispck@0 { > > Drop the unit-address. You should only have one if you have a reg > property. > Accept. Thank you. >> + compatible = "atmel,sama5d2-isc-ispck"; >> + #clock-cells = <0>; >> + clocks = <&isc_clk>, <&iscck>; >> + }; >> + >> + isc_mck: isc-mck@1 { > > ditto. > > I still think these should be implied by atmel,sama5d2-isc and not in > DT. The fact that you don't have any registers for them pretty much > indicates that. It is also strange that isc-ispck is used by isc. If > that is the only user, there is certainly no need to put it in DT. > The isc-ispck in only used by isc, it can be removed from DT. Thank you. > >> + compatible = "atmel,sama5d2-isc-mck"; >> + #clock-cells = <0>; >> + clocks = <&isc_clk>, <&iscck>, <&isc_gclk>; >> + }; >> +}; >> + >> +i2c1: i2c@fc028000 { >> + ov7740: camera@21 { >> + compatible = "ovti,ov7740"; >> + reg = <0x21>; >> + >> + clocks = <&isc_mck>; >> + clock-names = "xvclk"; >> + assigned-clocks = <&isc_mck>; >> + assigned-clock-rates = <24000000>; >> + >> + port { >> + ov7740_0: endpoint { >> + remote-endpoint = <&isc_0>; >> + }; >> + }; >> +}; >> -- >> 2.7.4 >>