From: Tom Lendacky <thomas.lendacky@amd.com>
To: Li Zetao <lizetao1@huawei.com>,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de
Cc: x86@kernel.org, hpa@zytor.com, rppt@kernel.org,
kirill.shutemov@linux.intel.com, michael.roth@amd.com,
nikunj@amd.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] x86/sev: Mark boot_ghcb_page and boot_ghcb static
Date: Wed, 26 Jul 2023 08:22:44 -0500 [thread overview]
Message-ID: <867d53e7-2d56-0f8d-2987-a0b2320dea43@amd.com> (raw)
In-Reply-To: <20230726170659.2474934-1-lizetao1@huawei.com>
On 7/26/23 12:06, Li Zetao wrote:
> This patch fixes the following sprse warning:
>
> arch/x86/boot/compressed/sev.c:28:13: warning:
> symbol boot_ghcb_page was not declared. Should it be static?
> arch/x86/boot/compressed/sev.c:29:13: warning:
> symbol boot_ghcb was not declared. Should it be static?
>
> No functional change intended.
>
> Signed-off-by: Li Zetao <lizetao1@huawei.com>
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> arch/x86/boot/compressed/sev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c
> index 09dc8c187b3c..323f6298a6b2 100644
> --- a/arch/x86/boot/compressed/sev.c
> +++ b/arch/x86/boot/compressed/sev.c
> @@ -25,8 +25,8 @@
> #include "error.h"
> #include "../msr.h"
>
> -struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
> -struct ghcb *boot_ghcb;
> +static struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
> +static struct ghcb *boot_ghcb;
>
> /*
> * Copy a version of this function here - insn-eval.c can't be used in
prev parent reply other threads:[~2023-07-26 13:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 17:06 Li Zetao
2023-07-26 9:20 ` Nikunj A. Dadhania
2023-07-26 13:22 ` Tom Lendacky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867d53e7-2d56-0f8d-2987-a0b2320dea43@amd.com \
--to=thomas.lendacky@amd.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=michael.roth@amd.com \
--cc=mingo@redhat.com \
--cc=nikunj@amd.com \
--cc=rppt@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®