From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C64D9C76188 for ; Fri, 19 Jul 2019 09:49:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9849921849 for ; Fri, 19 Jul 2019 09:49:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726711AbfGSJtx (ORCPT ); Fri, 19 Jul 2019 05:49:53 -0400 Received: from foss.arm.com ([217.140.110.172]:41060 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725794AbfGSJtx (ORCPT ); Fri, 19 Jul 2019 05:49:53 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 215AD337; Fri, 19 Jul 2019 02:49:52 -0700 (PDT) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A4BB33F59C; Fri, 19 Jul 2019 02:49:49 -0700 (PDT) Subject: Re: [PATCH] arm64: vdso: Cleanup Makefiles. To: Will Deacon Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, arnd@arndb.de, linux@armlinux.org.uk, daniel.lezcano@linaro.org, tglx@linutronix.de, salyzyn@android.com, pcc@google.com, 0x7f454c46@gmail.com, linux@rasmusvillemoes.dk, huw@codeweavers.com, sthotton@marvell.com, andre.przywara@arm.com, luto@kernel.org, john.stultz@linaro.org, naohiro.aota@wdc.com, yamada.masahiro@socionext.com References: <20190712153746.5dwwptgrle3z25m7@willie-the-truck> <20190718114121.33024-1-vincenzo.frascino@arm.com> <20190719080435.f3nlecyu3ysnsnpv@willie-the-truck> From: Vincenzo Frascino Message-ID: <867d5696-6784-20ee-79cc-8a2bf39431f9@arm.com> Date: Fri, 19 Jul 2019 10:49:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190719080435.f3nlecyu3ysnsnpv@willie-the-truck> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Will, On 19/07/2019 09:04, Will Deacon wrote: > On Thu, Jul 18, 2019 at 12:41:21PM +0100, Vincenzo Frascino wrote: >> diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile >> index 21009ed5a755..6c4e496309c4 100644 >> --- a/arch/arm64/kernel/vdso32/Makefile >> +++ b/arch/arm64/kernel/vdso32/Makefile >> @@ -155,17 +155,17 @@ $(asm-obj-vdso): %.o: %.S FORCE >> $(call if_changed_dep,vdsoas) >> >> # Actual build commands >> -quiet_cmd_vdsold_and_vdso_check = LD $@ >> +quiet_cmd_vdsold_and_vdso_check = VDSOLIB $@ >> cmd_vdsold_and_vdso_check = $(cmd_vdsold); $(cmd_vdso_check) >> >> -quiet_cmd_vdsold = VDSOL $@ >> +quiet_cmd_vdsold = VDSOLD $@ > > I think we should be more consistent about whether or not we prefix things > with VDSO, so either go with "VDSOLD, VDSOCC and VDSOAS" or stick to "LD, > CC and AS" rather than mixing between them. > > I think my suggestion would be something along the lines of CC, LD, AS for > the native vdso and CC32, LD32, AS32 for the compat vdso. > Sounds good. I will send v2 accordingly. > Will > -- Regards, Vincenzo