From: "Yinghai Lu" <yinghai.lu@amd.com>
To: "Olivier Nicolas" <olivn@trollprod.org>
Cc: "Linus Torvalds" <torvalds@osdl.org>,
Mws <mws@twisted-brains.org>, "Jeff Garzik" <jeff@garzik.org>,
"Krzysztof Halasa" <khc@pm.waw.pl>,
"David Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, tiwai@suse.de
Subject: Re: [PATCH] ALSA: hda-intel - Disable MSI support by default
Date: Wed, 15 Nov 2006 22:08:11 -0800 [thread overview]
Message-ID: <86802c440611152208jf415991vdd348a0a369f8aa2@mail.gmail.com> (raw)
In-Reply-To: <455B7E3F.6040403@trollprod.org>
[-- Attachment #1: Type: text/plain, Size: 66 bytes --]
Please try the patch about using pci_intx.
it could use msi.
YH
[-- Attachment #2: hda_intel_pci_intx.diff --]
[-- Type: text/x-patch, Size: 1374 bytes --]
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index e35cfd3..88b99ab 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -547,6 +547,7 @@ static unsigned int azx_rirb_get_respons
chip->msi = 0;
if (azx_acquire_irq(chip, 1) < 0)
return -1;
+ pci_intx(chip->pci, 1);
goto again;
}
@@ -1435,11 +1436,16 @@ static int azx_resume(struct pci_dev *pc
return -EIO;
}
pci_set_master(pci);
- if (chip->msi)
+ if (chip->msi) {
+ pci_intx(pci, 0);
if (pci_enable_msi(pci) < 0)
chip->msi = 0;
+ }
if (azx_acquire_irq(chip, 1) < 0)
return -EIO;
+
+ if (!chip->msi)
+ pci_intx(pci, 1);
azx_init_chip(chip);
snd_hda_resume(chip->bus);
snd_power_change_state(card, SNDRV_CTL_POWER_D0);
@@ -1531,7 +1537,8 @@ static int __devinit azx_create(struct s
chip->pci = pci;
chip->irq = -1;
chip->driver_type = driver_type;
- chip->msi = enable_msi;
+// chip->msi = enable_msi;
+ chip->msi = 1;
chip->position_fix = position_fix;
chip->single_cmd = single_cmd;
@@ -1561,14 +1568,19 @@ #endif
goto errout;
}
- if (chip->msi)
+ if (chip->msi) {
+ pci_intx(pci, 0);
if (pci_enable_msi(pci) < 0)
chip->msi = 0;
+ }
if (azx_acquire_irq(chip, 0) < 0) {
err = -EBUSY;
goto errout;
}
+
+ if(!chip->msi)
+ pci_intx(pci, 1);
pci_set_master(pci);
synchronize_irq(chip->irq);
next prev parent reply other threads:[~2006-11-16 6:08 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200611150059.kAF0xBTl009796@hera.kernel.org>
2006-11-15 1:34 ` Jeff Garzik
2006-11-15 1:55 ` Linus Torvalds
2006-11-15 2:40 ` Jeff Garzik
2006-11-15 2:49 ` Linus Torvalds
2006-11-15 3:00 ` David Miller
2006-11-15 3:10 ` Linus Torvalds
2006-11-15 3:21 ` David Miller
2006-11-15 3:54 ` Linus Torvalds
2006-11-15 4:11 ` Jeff Garzik
2006-11-15 4:15 ` David Miller
2006-11-15 4:24 ` Jeff Garzik
2006-11-15 4:28 ` David Miller
2006-11-16 2:25 ` Benjamin Herrenschmidt
2006-11-16 2:28 ` Benjamin Herrenschmidt
2006-11-16 3:25 ` Jeff Garzik
2006-11-16 4:12 ` Benjamin Herrenschmidt
2006-11-16 6:13 ` Jeff Garzik
2006-11-16 14:41 ` Krzysztof Halasa
2006-11-16 15:27 ` Jeff Garzik
2006-11-16 17:24 ` Roland Dreier
2006-11-15 19:09 ` Stephen Hemminger
2006-11-15 19:23 ` Jeff Garzik
2006-11-15 19:49 ` Stephen Hemminger
2006-11-15 22:31 ` Roland Dreier
2006-11-16 2:24 ` Benjamin Herrenschmidt
2006-11-15 4:30 ` Roland Dreier
2006-11-15 4:56 ` Jeff Garzik
2006-11-15 15:53 ` Linus Torvalds
2006-11-15 18:30 ` Jeff Garzik
2006-11-15 18:45 ` Roland Dreier
2006-11-16 2:29 ` Benjamin Herrenschmidt
2006-11-15 13:34 ` Krzysztof Halasa
2006-11-15 18:42 ` Jeff Garzik
2006-11-15 19:04 ` Linus Torvalds
2006-11-15 19:20 ` Jeff Garzik
2006-11-15 19:35 ` Linus Torvalds
2006-11-15 19:59 ` Mws
2006-11-15 20:14 ` Linus Torvalds
2006-11-15 20:53 ` Olivier Nicolas
2006-11-16 6:08 ` Yinghai Lu [this message]
2006-11-16 23:25 ` Olivier Nicolas
2006-11-15 21:10 ` Mws
2006-11-16 11:10 ` Mws
2006-11-15 4:14 ` Roland Dreier
2006-11-15 4:49 ` Andi Kleen
2006-11-15 4:57 ` Roland Dreier
2006-11-15 5:11 ` Andi Kleen
2006-11-15 22:43 ` Roland Dreier
2006-11-15 18:35 ` [PATCH] ACPI: use MSI_NOT_SUPPORTED bit Randy Dunlap
2006-11-15 18:44 ` Andi Kleen
2006-11-15 19:41 ` [PATCH v2] " Randy Dunlap
2006-11-15 19:58 ` [PATCH v3] " Randy Dunlap
2006-11-15 20:19 ` [PATCH] " Len Brown
2006-11-16 2:22 ` [PATCH] ALSA: hda-intel - Disable MSI support by default Benjamin Herrenschmidt
2006-11-15 10:31 ` Takashi Iwai
2006-11-15 16:19 ` Linus Torvalds
2006-11-15 16:24 ` Arjan van de Ven
2006-11-15 16:36 ` Linus Torvalds
2006-11-15 18:40 ` Jeff Garzik
2006-11-15 18:51 ` Linus Torvalds
2006-11-15 19:01 ` Arjan van de Ven
2006-11-15 19:34 ` Stephen Clark
2006-11-15 19:48 ` Jeff Garzik
2006-11-15 20:01 ` Stephen Clark
2006-11-15 18:32 ` Jeff Garzik
2006-11-15 18:32 ` Jeff Garzik
2006-11-15 18:58 ` Takashi Iwai
2006-11-15 19:15 ` Jeff Garzik
2006-11-16 10:44 ` Takashi Iwai
2006-11-16 23:01 ` Olivier Nicolas
2006-11-17 10:55 ` Takashi Iwai
2006-11-17 16:17 ` Yinghai Lu
2006-11-17 16:35 ` Linus Torvalds
2006-11-15 19:20 ` Stephen Hemminger
2006-11-15 22:35 ` Roland Dreier
2006-11-15 4:01 ` Benjamin Herrenschmidt
2006-11-15 4:07 ` David Miller
2006-11-15 7:23 ` Benjamin Herrenschmidt
2006-11-15 10:06 ` Segher Boessenkool
2006-11-15 4:23 ` Roland Dreier
2006-11-15 7:24 ` Benjamin Herrenschmidt
2006-11-15 4:04 ` Benjamin Herrenschmidt
2006-11-15 4:14 ` Jeff Garzik
2006-11-15 4:24 ` Roland Dreier
2006-11-15 2:58 ` Randy Dunlap
2006-11-15 3:10 ` D. Hazelton
2006-11-15 3:30 ` Jeff Garzik
2006-11-15 3:53 ` D. Hazelton
2006-11-15 11:40 ` Alan
2006-11-16 4:06 ` D. Hazelton
2006-11-16 0:17 Lu, Yinghai
2006-11-16 3:50 Lu, Yinghai
2006-11-16 23:36 ` Olivier Nicolas
2006-11-16 4:24 linux
2006-11-16 10:53 ` Alan
2006-11-16 16:05 ` Linus Torvalds
2006-11-16 4:25 Lu, Yinghai
2006-11-16 18:00 ` D. Hazelton
2006-11-16 23:54 Lu, Yinghai
2006-11-17 0:49 ` Olivier Nicolas
2006-11-17 17:42 Lu, Yinghai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440611152208jf415991vdd348a0a369f8aa2@mail.gmail.com \
--to=yinghai.lu@amd.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=mws@twisted-brains.org \
--cc=olivn@trollprod.org \
--cc=tiwai@suse.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®