Re: [PATCH]serial: make early_uart to use early_param instead of console_initcall

["Yinghai Lu" <yhlu.kernel@gmail.com>]

On 5/21/07, Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
>
> How about just plain "console=8250,io,..."?

then the
__setup("console", setup_console);
setup_console will think their is one ttyS8, and then ...

How about console=uart8250,...?

> I don't want to add asm-ia64/fixmap.h with dummy definitions
> just for this.
>
> Can we add this:
>
>   asm-ia64/io.h:   #define bt_ioremap ioremap
>   asm-x86_64/io.h: #define bt_ioremap early_ioremap
>
> and use bt_ioremap instead?

I will try it.

>
> > new command line will be
> >
> >       earlycon=early8250,io,0x3f8,9600n8
> >       earlycon=early8250,mmio,0xff5e0000,115200n8
> >  or
> >       console=early8250,io,0x3f8,9600n8
> >       console=early8250,mmio,0xff5e0000,115200n8
>
> If you can make "console=early8250" work, we don't need
> "earlycon=early8250", do we?

actually I modify init/main.c
diff --git a/init/main.c b/init/main.c
index 1940fa7..07dad53 100644
--- a/init/main.c
+++ b/init/main.c
@@ -452,7 +452,9 @@ static int __init do_early_param(char *param, char *val)
 	struct obs_kernel_param *p;

 	for (p = __setup_start; p < __setup_end; p++) {
-		if (p->early && strcmp(param, p->str) == 0) {
+		if ((p->early && strcmp(param, p->str) == 0) ||
+		  (strcmp(param,"console")==0 && strcmp(p->str, "earlycon")==0)
+		) {
 			if (p->setup_func(val) != 0)
 				printk(KERN_WARNING
 				       "Malformed early option '%s'\n", param);

so make earlycon early_param setup will check console command line.


>
> Your patch adds trailing whitespace and a few cases of"<space><tab>".
> I use this in my .vimrc to catch these:
>
>   highlight WhitespaceEOL ctermbg=red guibg=red
>   match WhitespaceEOL /\s\+$\| \+\ze\t/
>
I will check it.

YH