Re: [PATCH 4/5] serial: convert early_uart to earlycon for 8250

["Yinghai Lu" <yhlu.kernel@gmail.com>]

On 5/30/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Wed, 30 May 2007 21:34:35 -0700 "Yinghai Lu" <yhlu.kernel@gmail.com> wrote:
>
> > they will need
> > diff --git a/include/asm-x86_64/io.h b/include/asm-x86_64/io.h
> > index de2cd9a..e2d66de 100644
> > --- a/include/asm-x86_64/io.h
> > +++ b/include/asm-x86_64/io.h
> > @@ -145,6 +145,19 @@ extern void early_iounmap(void *addr, unsigned long size);
> >  extern void __iomem * ioremap_nocache (unsigned long offset, unsigned
> > long size);
> >  extern void iounmap(volatile void __iomem *addr);
> >
> > +#include <asm/pgtable.h>
> > +#include <asm/fixmap.h>
> > +
> > +static inline void __iomem * fix_ioremap (unsigned idx, unsigned long phys)
> > +{
> > +       void __iomem * vaddr;
> > +       set_fixmap_nocache(idx, phys & PAGE_MASK);
> > +       vaddr = (void __iomem *)__fix_to_virt(idx);
> > +       vaddr += phys & ~PAGE_MASK;
> > +
> > +       return vaddr;
> > +}
> > +
>
> I hope not - I just removed that inlined function.  It's too large and the
> inclusion of pgtable.h in io.h causes all sorts of problems.
>
> This function should go into arch/.../mm/ioremap.c
>
agree, but need to keep

#include <asm/fixmap.h>

and will create dummy fixmap.h for arch that doesn't support fixmap

YH