From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Christoph Hellwig" <hch@infradead.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Yinghai Lu" <Yinghai.Lu@sun.com>, "Andi Kleen" <ak@suse.de>,
"Greg KH" <greg@kroah.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] net: make net and forcedeth to use kmalloc_node
Date: Wed, 4 Jul 2007 10:00:29 -0700 [thread overview]
Message-ID: <86802c440707041000m1378823dwff25ace3e93e54fe@mail.gmail.com> (raw)
In-Reply-To: <20070704084938.GA19515@infradead.org>
On 7/4/07, Christoph Hellwig <hch@infradead.org> wrote:
> On Tue, Jul 03, 2007 at 11:58:40AM -0700, Andrew Morton wrote:
> > >
> > > while (np->put_rx.orig != less_rx) {
> > > - struct sk_buff *skb = dev_alloc_skb(np->rx_buf_sz + NV_RX_ALLOC_PAD);
> > > + struct sk_buff *skb = dev_alloc_skb_node(np->rx_buf_sz + NV_RX_ALLOC_PAD, dev_to_node(&dev->dev));
> >
> > If we're going to do this then it would probably make sense to change
> > dev_alloc_skb_node() so that it takes a `struct net_device *' rather than a
> > bare node-id. That's a call which the net guys will need to make, which is
> > why we cc them on our emails.
>
> That thing is called netdev_alloc_skb and already exists. And it's indeed
> what they should be using in the rx path.
>
> -
please check
http://lkml.org/lkml/2007/7/3/418
[PATCH 3/4] net: make forcedeth to use kmalloc_node and
__netdev_alloc_skb for skb allocation
but need to replace __netdev_alloc_skb to netdev_alloc_skb.
YH
prev parent reply other threads:[~2007-07-04 17:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-29 20:30 Yinghai Lu
2007-07-03 18:58 ` Andrew Morton
2007-07-03 19:04 ` Stephen Hemminger
2007-07-03 21:28 ` Yinghai Lu
2007-07-03 21:34 ` Stephen Hemminger
2007-07-04 0:30 ` [PATCH 2/4] net: use numa_node in net_devcice->dev instead of parent Yinghai Lu
2007-07-04 8:51 ` Christoph Hellwig
2007-07-04 10:35 ` David Miller
2007-07-04 11:04 ` Stefan Richter
2007-07-04 16:54 ` Yinghai Lu
2007-07-04 0:34 ` [PATCH 3/4] net: make forcedeth to use kmalloc_node and __netdev_alloc_skb for skb allocation Yinghai Lu
2007-07-03 21:36 ` [PATCH 2/2] net: make net and forcedeth to use kmalloc_node Yinghai Lu
2007-07-04 8:49 ` Christoph Hellwig
2007-07-04 17:00 ` Yinghai Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440707041000m1378823dwff25ace3e93e54fe@mail.gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=Yinghai.Lu@sun.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®