From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756031AbXGVBgU (ORCPT ); Sat, 21 Jul 2007 21:36:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753393AbXGVBgL (ORCPT ); Sat, 21 Jul 2007 21:36:11 -0400 Received: from wa-out-1112.google.com ([209.85.146.182]:47172 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753086AbXGVBgK (ORCPT ); Sat, 21 Jul 2007 21:36:10 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=dJh5CvdhSVcZDI4YjeRofGe8YznDTFFcnxRdcsA6SPOBEmMuZ1xlbFbe8A9mcgTmjVoEylhKr9mSXeB7IDPrw57WOjD609iBinhp3rMpbdTEzG0ffGuA2od/v5q9Q2wjyg7TkSxLr5HhY48XPNKjNLJED6RzewCnh5+7gE114y4= Message-ID: <86802c440707211836l75661bc1m18e7f48f86a6c67f@mail.gmail.com> Date: Sat, 21 Jul 2007 18:36:04 -0700 From: "Yinghai Lu" To: "Andi Kleen" Subject: Re: [PATCH] x86_64: use apic core id bits for core nums Cc: "Andrew Morton" , joachim.deguara@amd.com, linux-kernel@vger.kernel.org In-Reply-To: <200707211428.46711.ak@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <86802c440707210056s745d44f1jc6437064741299eb@mail.gmail.com> <200707211022.47859.ak@suse.de> <86802c440707210421h33a4fa50n9856bfe95e5b386f@mail.gmail.com> <200707211428.46711.ak@suse.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 7/21/07, Andi Kleen wrote: > On Saturday 21 July 2007 13:21:34 Yinghai Lu wrote: > > On 7/21/07, Andi Kleen wrote: > > > On Saturday 21 July 2007 09:56:15 Yinghai Lu wrote: > > > > please check my version, we should use core id bits instead. > > > > > > > > it should replace > > > > [PATCH for review] [37/48] x86_64: make k8topology multi-core aware > > > > > > Yes, you're right the patch is not good. It should probably use > > > information from the regular CPU setup code, not touch cpuid > > > directly > > > > need move some code into early_identify_cpu from identify_cpu in > > arch/x86_64/kernel/setup.c > > then could use that bits in bsp cpu info. > > Yes something like this > > > BTW: > > it seems for BSP only early_identify_cpu is called, and identify_cpu > > is only use in smp_callin for AP. Do i miss sth. > > identify_cpu calls early_identify_cpu as first thing. the calling to identify_cpu in BSP is in check_bugs(). It is easy to ignore it... maybe we could move that to setup_arch directly. YH