From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Andrew Morton" <akpm@linux-foundation.org>,
"Christoph Lameter" <clameter@sgi.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"Adrian Bunk" <bunk@stusta.de>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: free_pages_check
Date: Mon, 7 Jan 2008 18:43:46 -0800 [thread overview]
Message-ID: <86802c440801071843p583f390as53f8b600622b93b2@mail.gmail.com> (raw)
wonder why free_pages_check mm/page_alloc.c is using bit OR than logical OR
@@ -450,9 +450,9 @@ static inline void __free_one_page(struc
static inline int free_pages_check(struct page *page)
{
- if (unlikely(page_mapcount(page) |
- (page->mapping != NULL) |
- (page_count(page) != 0) |
+ if (unlikely(page_mapcount(page) ||
+ (page->mapping != NULL) ||
+ (page_count(page) != 0) ||
(page->flags & (
1 << PG_lru |
1 << PG_private |
YH
next reply other threads:[~2008-01-08 2:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 2:43 Yinghai Lu [this message]
2008-01-08 3:08 ` free_pages_check Andrew Morton
2008-01-08 3:34 ` free_pages_check Nick Piggin
2008-01-08 5:44 ` free_pages_check H. Peter Anvin
2008-01-08 7:44 ` free_pages_check Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440801071843p583f390as53f8b600622b93b2@mail.gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bunk@stusta.de \
--cc=clameter@sgi.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®