mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	mingo@elte.hu, clameter@sgi.com, linux-kernel@vger.kernel.org,
	"Andi Kleen" <ak@suse.de>,
	"Yasunori Goto" <y-goto@jp.fujitsu.com>
Subject: Re: [PATCH] mm: make free_bootmem to loop bdata_list
Date: Thu, 13 Mar 2008 18:39:34 -0700	[thread overview]
Message-ID: <86802c440803131839n4f723d14md906a15acb26c3a2@mail.gmail.com> (raw)
In-Reply-To: <20080314103953.70be95b1.kamezawa.hiroyu@jp.fujitsu.com>

On Thu, Mar 13, 2008 at 6:39 PM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu@jp.fujitsu.com> wrote:
> On Thu, 13 Mar 2008 11:53:31 -0700
>  "Yinghai Lu" <yhlu.kernel@gmail.com> wrote:
>  > ===================================================================
>  > --- linux-2.6.orig/mm/bootmem.c
>  > +++ linux-2.6/mm/bootmem.c
>  > @@ -427,7 +438,9 @@ int __init reserve_bootmem(unsigned long
>  >
>  >  void __init free_bootmem(unsigned long addr, unsigned long size)
>  >  {
>  > -     free_bootmem_core(NODE_DATA(0)->bdata, addr, size);
>  > +     bootmem_data_t *bdata;
>  > +     list_for_each_entry(bdata, &bdata_list, list)
>  > +             free_bootmem_core(bdata, addr, size);
>  >  }
>
>
>  Just a confirmation.
>  In above loop, boundary check in free_bootmem_core() hits two or more times ?
>  If yes, it's ok.
>  If no, please exit loop at hit.

yes. need that handle range cross node (RAMDISK case that is end
beyond end_of_ram).

YH

  reply	other threads:[~2008-03-14  1:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-13 18:53 Yinghai Lu
2008-03-13 19:05 ` Andrew Morton
2008-03-13 19:10   ` Yinghai Lu
2008-03-14  1:39 ` KAMEZAWA Hiroyuki
2008-03-14  1:39   ` Yinghai Lu [this message]
2008-03-14  2:04     ` KAMEZAWA Hiroyuki
2008-03-14  2:07       ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86802c440803131839n4f723d14md906a15acb26c3a2@mail.gmail.com \
    --to=yhlu.kernel@gmail.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=y-goto@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®