From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752897AbYDPSop (ORCPT ); Wed, 16 Apr 2008 14:44:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751365AbYDPSoi (ORCPT ); Wed, 16 Apr 2008 14:44:38 -0400 Received: from rv-out-0708.google.com ([209.85.198.244]:28678 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751247AbYDPSoh (ORCPT ); Wed, 16 Apr 2008 14:44:37 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=B1ZZdqQj8ElaMMoc4Jvjoa+Uy6yNfE0d/CeZWkefJ0ONTdKPMx/R+PI3WeqH2k3CpQOiMugJlY3ONM5goi18lo3hM33aBr00XUEHQNIMxuRDHp8RyfHI5aA+nOyH8stLora51HW6AiSYZ9k6in2qKWXpY8i3vRnsiu5siToVTnk= Message-ID: <86802c440804161144id4f2a68i37513ac0428c693@mail.gmail.com> Date: Wed, 16 Apr 2008 11:44:36 -0700 From: "Yinghai Lu" To: "Johannes Weiner" Subject: Re: [RFC][patch 2/5] mm: Node-setup agnostic free_bootmem() Cc: LKML , "Linux MM" , "Ingo Molnar" , "Andi Kleen" , "Yasunori Goto" , "KAMEZAWA Hiroyuki" , "Christoph Lameter" , "Andrew Morton" , "Siddha, Suresh B" In-Reply-To: <86802c440804161054h6f0cfc3dmde49006afb7889b2@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080416113629.947746497@skyscraper.fehenstaub.lan> <20080416113719.092060936@skyscraper.fehenstaub.lan> <86802c440804161054h6f0cfc3dmde49006afb7889b2@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 16, 2008 at 10:54 AM, Yinghai Lu wrote: > > On Wed, Apr 16, 2008 at 4:36 AM, Johannes Weiner wrote: > > Make free_bootmem() look up the node holding the specified address > > range which lets it work transparently on single-node and multi-node > > configurations. > > > > If the address range exceeds the node range, it well be marked free > > across node boundaries, too. > > > > Signed-off-by: Johannes Weiner > > CC: Ingo Molnar > > CC: Andi Kleen > > CC: Yinghai Lu > > CC: Yasunori Goto > > CC: KAMEZAWA Hiroyuki > > CC: Christoph Lameter > > CC: Andrew Morton > > --- > > mm/bootmem.c | 10 +++++++++- > > 1 files changed, 9 insertions(+), 1 deletions(-) > > > > Index: tree-linus/mm/bootmem.c > > =================================================================== > > --- tree-linus.orig/mm/bootmem.c > > +++ tree-linus/mm/bootmem.c > > @@ -421,7 +421,32 @@ int __init reserve_bootmem(unsigned long > > > > void __init free_bootmem(unsigned long addr, unsigned long size) > > { > > - free_bootmem_core(NODE_DATA(0)->bdata, addr, size); > > + bootmem_data_t *bdata; > > + unsigned long pos = addr; > > + unsigned long partsize = size; > > + > > + list_for_each_entry(bdata, &bdata_list, list) { > > + unsigned long remainder = 0; > > + > > + if (pos < bdata->node_boot_start) > > + continue; > > + > > + if (PFN_DOWN(pos + partsize) > bdata->node_low_pfn) { > > + remainder = PFN_DOWN(pos + partsize) - bdata->node_low_pfn; > > + partsize -= remainder; > > + } > > + > > + free_bootmem_core(bdata, pos, partsize); > > + > > + if (!remainder) > > + return; > > + > > + pos = PFN_PHYS(bdata->node_low_pfn + 1); > > + } > > + printk(KERN_ERR "free_bootmem: request: addr=%lx, size=%lx, " > > + "state: pos=%lx, partsize=%lx\n", addr, size, > > + pos, partsize); > > + BUG(); > > } > > > > unsigned long __init free_all_bootmem(void) > > > > -- > > Yes, it should work well with cross nodes case. > > but please add boundary check on free_bootmem_node too. also please note: it will have problem span nodes box. for example: node 0: 0-2g, 4-6g, node1: 2-4g, 6-8g. and if ramdisk sit creoss 2G boundary. you will only free the range before 2g. YH