From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763598AbYDQKFU (ORCPT ); Thu, 17 Apr 2008 06:05:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933083AbYDQJo2 (ORCPT ); Thu, 17 Apr 2008 05:44:28 -0400 Received: from yw-out-2324.google.com ([74.125.46.29]:12220 "EHLO yw-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934848AbYDQJo0 (ORCPT ); Thu, 17 Apr 2008 05:44:26 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=pM6Ku81lZxSDlnNp5kiy89x87H0a7PERDMtvEMynyHmG+1ub7RWd79xjYXCVn6/klqpWUnQWKxHRlp/E2amKSVUYaSA8oKZ351vYEUow8Xh3DezRY5zS0hBhkMo4ky+3QmVaGl/FFGgUy3S1d2ObnRljqei9dedXwSMNIE5Clzg= Message-ID: <86802c440804170244g3463d1bcx632844dc0204ded2@mail.gmail.com> Date: Thu, 17 Apr 2008 02:44:16 -0700 From: "Yinghai Lu" To: "Eric W. Biederman" Subject: Re: [PATCH] x86_64: restore mask_bits in msi shutdown Cc: hlu.kernel@gmail.com, "Thomas Gleixner" , "Andrew Morton" , "Ingo Molnar" , "Jeff Garzik" , "Ayaz Abdulla" , "kernel list" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200804111626.11232.yhlu.kernel@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 17, 2008 at 2:19 AM, Eric W. Biederman wrote: > > Yinghai Lu writes: > > > I can not kexec RHEL 5.1 from 2.6.25-rc3 later > > > > caused by: > > commit 89d694b9dbe769ca1004e01db0ca43964806a611 > > Author: Thomas Gleixner > > Date: Mon Feb 18 18:25:17 2008 +0100 > > > > genirq: do not leave interupts enabled on free_irq > > > > The default_disable() function was changed in commit: > > > > 76d2160147f43f982dfe881404cfde9fd0a9da21 > > genirq: do not mask interrupts by default > > > > It removed the mask function in favour of the default delayed > > interrupt disabling. Unfortunately this also broke the shutdown in > > free_irq() when the last handler is removed from the interrupt for > > those architectures which rely on the default implementations. Now we > > can end up with a enabled interrupt line after the last handler was > > removed, which can result in spurious interrupts. > > > > Fix this by adding a default_shutdown function, which is only > > installed, when the irqchip implementation does provide neither a > > shutdown nor a disable function. > > > > [@stable: affected versions: .21 - .24 ] > > > > > > > > for MSI, default_shutdown will call mask_bit for msi device. so all mask bits > > will > > left disabled after free_irq. > > then if kexec next kernel that only can use msi_enable bit. > > all device's MSI can not be used. > > > > So try to restore MSI mask bits that is saved before using msi in first kernel. > > > > Signed-off-by: Yinghai Lu > > Ouch! In the case of MSI-X this is horrible. Reenabling an interrupt > line when we are not using it. That is likely to cause even stranger > things than kexec to fail. only does save and restore with msi and doesn't do anything with MSIX +void msi_restore_mask_bits(unsigned int irq) +{ + struct msi_desc *entry; + + entry = get_irq_msi(irq); + BUG_ON(!entry || !entry->dev); + switch (entry->msi_attrib.type) { + case PCI_CAP_ID_MSI: + if (entry->msi_attrib.maskbit) { + int pos; + u32 mask_bits; + + pos = (long)entry->mask_base; + mask_bits = entry->orig_mask_bits; + pci_write_config_dword(entry->dev, pos, mask_bits); + } + break; + case PCI_CAP_ID_MSIX: + break; ======================> does not restore that for MSIX + default: + BUG(); + break; + } +} YH