Re: [PATCH] x86: early dump pci conf space v2

["Yinghai Lu" <yhlu.kernel@gmail.com>]

On Thu, May 22, 2008 at 10:38 PM, Grant Grundler
<grundler@parisc-linux.org> wrote:
> On Thu, May 22, 2008 at 02:35:11PM -0700, Yinghai Lu wrote:
>>
>> so we can printout pci config before kernel touch it
>>
>> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
>
> Yinghai,
> No offense, but my first thought was this is debug code that should be
> maintained outside the kernel.org tree. It will rarely get used.
> Just want people to think about this before saying "great, add it!"
>
> (And this isn't a stab at Jesse since I think he's doing a better
> job than I could. I saw his previous reply to this mail.)
>
> Having debugged lots of PCI resource and config issues, I understand
> why this is useful and do NOT object to it being included in the tree.

could print out the setting from buggy BIOS, or first kernel.
and don't need the reporter apply debug patch again...

>
> The boot option also needs to be added to Documentation/ .
> At least if you want people to use it. :)
> Perhaps Jesse can suggest a preferred location.

we could add it.
..
>
> Please call this "pci_early_dump" (I prefer with underscores but don't care).
> Don't want it confused with kernel dumps (LKCD) or any other
> general debugging tools.

so you want pci_early_dump instead of pci=earlydump?
or pci=early_dump?

YH