Re: kernel boot hangs after x86: insert_resorce for lapic addr after e820_reserve_resources

["Yinghai Lu" <yhlu.kernel@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 862 bytes --]

On Fri, May 23, 2008 at 6:51 PM, Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> On Fri, May 23, 2008 at 6:09 PM, Ciaran McCreesh
> <ciaran.mccreesh@googlemail.com> wrote:
>> On Fri, 23 May 2008 17:05:34 -0700
>> "Yinghai Lu" <yhlu.kernel@gmail.com> wrote:
>>> > Without the ram_reserve
>>> > patch, /proc/iomem is as it was earlier in the discussion.
>>> >
>>> >> can you boot with pnpacpi=off ?
>>> >
>>> > No, that doesn't help either.
>>>
>>> how about /proc/iomem with pnpacpi=off?
>>
>> I've attached /proc/iomem from current head minus the original patch,
>> with and without pnpacpi=off.
>
> it's weird,
>
> you should have
>
> 00000 - 9f400: System RAM  ===> is not showing up
> 100000 - d7ff0000: System RAM ===> is not showing up
> 100000000-11fffffff : System RAM

please try to revert attached commit...

it seems that your compiler is not happy...

YH

[-- Attachment #2: commit-0156126 --]
[-- Type: application/octet-stream, Size: 1186 bytes --]

commit 01561264bd1ea1d654d09babe02d784a5b150124
Author: Yinghai Lu <yhlu.kernel.send@gmail.com>
Date:   Thu Mar 20 23:57:21 2008 -0700

    x86: allocate e820 resource struct all together
    
    don't need to allocate that one by one
    
    Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>

diff --git a/arch/x86/kernel/e820_64.c b/arch/x86/kernel/e820_64.c
index 4509757..9184e64 100644
--- a/arch/x86/kernel/e820_64.c
+++ b/arch/x86/kernel/e820_64.c
@@ -300,9 +300,10 @@ unsigned long __init e820_end_of_ram(void)
 void __init e820_reserve_resources(void)
 {
 	int i;
+	struct resource *res;
+
+	res = alloc_bootmem_low(sizeof(struct resource) * e820.nr_map);
 	for (i = 0; i < e820.nr_map; i++) {
-		struct resource *res;
-		res = alloc_bootmem_low(sizeof(struct resource));
 		switch (e820.map[i].type) {
 		case E820_RAM:	res->name = "System RAM"; break;
 		case E820_ACPI:	res->name = "ACPI Tables"; break;
@@ -313,6 +314,7 @@ void __init e820_reserve_resources(void)
 		res->end = res->start + e820.map[i].size - 1;
 		res->flags = IORESOURCE_MEM | IORESOURCE_BUSY;
 		insert_resource(&iomem_resource, res);
+		res++;
 	}
 }