From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Kevin Winchester" <kjwinchester@gmail.com>
Cc: "Ingo Molnar" <mingo@redhat.com>,
linux-kernel@vger.kernel.org,
"Thomas Gleixner" <tglx@linutronix.de>
Subject: Re: [PATCH] x86: fix pointer type warning in arch/x86/mm/init_64.c:early_memtest
Date: Fri, 30 May 2008 17:56:24 -0700 [thread overview]
Message-ID: <86802c440805301756m65bd717bxc973d77b3c585735@mail.gmail.com> (raw)
In-Reply-To: <48409D2D.4020207@gmail.com>
On Fri, May 30, 2008 at 5:34 PM, Kevin Winchester
<kjwinchester@gmail.com> wrote:
> Kevin Winchester wrote:
>>
>> Changed the call to find_e820_area_size to pass u64 instead of unsigned
>> long.
>>
>> Signed-off-by: Kevin Winchester <kjwinchester@gmail.com>
>> ---
>> arch/x86/mm/init_64.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
>> index 83ab7f9..94f73c2 100644
>> --- a/arch/x86/mm/init_64.c
>> +++ b/arch/x86/mm/init_64.c
>> @@ -515,7 +515,7 @@ early_param("memtest", parse_memtest);
>> static void __init early_memtest(unsigned long start, unsigned long end)
>> {
>> - unsigned long t_start, t_size;
>> + u64 t_start, t_size;
>> unsigned pattern;
>> if (!memtest_pattern)
>> @@ -534,7 +534,7 @@ static void __init early_memtest(unsigned long start,
>> unsigned long end)
>> if (t_start + t_size > end)
>> t_size = end - t_start;
>> - printk(KERN_CONT "\n %016lx - %016lx pattern
>> %d",
>> + printk(KERN_CONT "\n %016llx - %016llx pattern
>> %d",
>> t_start, t_start + t_size, pattern);
>> memtest(t_start, t_size, pattern);
>
> I still see this warning on next-20080530 - so I expanded the CC list a
> little. Did I do this patch right?
i had one in local too.
Acked-by: Yinghai Lu <yhlu.kernel@gmail.com>
prev parent reply other threads:[~2008-05-31 0:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 0:14 Kevin Winchester
2008-05-30 0:33 ` Kevin Winchester
2008-05-31 0:34 ` Kevin Winchester
2008-05-31 0:56 ` Yinghai Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440805301756m65bd717bxc973d77b3c585735@mail.gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=kjwinchester@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®