mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: reserve_bootmem_generic in early_res_to_bootmem
Date: Mon, 9 Jun 2008 13:07:52 -0700	[thread overview]
Message-ID: <86802c440806091307r3c4d5e77h12e22abfe578769f@mail.gmail.com> (raw)

can you make the 64 bit still use reserve_bootmem_generic in
early_res_to_bootmem?

reserve_bootmem_generic is some smart than reserve_bootmem when numa is enabled.

YH

commit 3f3040c347653b93e4e82ee45bb7d41f11c10be8
Author: Ingo Molnar <mingo@elte.hu>
Date:   Mon Jun 9 15:12:20 2008 +0200

    x86: reserve highmem pages via reserve_early, fix #2

    fix:

    arch/x86/kernel/built-in.o: In function `early_res_to_bootmem':
    : undefined reference to `reserve_bootmem_generic'

    Signed-off-by: Ingo Molnar <mingo@elte.hu>

diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
index a488bd0..68aba41 100644
--- a/arch/x86/kernel/e820.c
+++ b/arch/x86/kernel/e820.c
@@ -635,7 +635,7 @@ void __init early_res_to_bootmem(u64 start, u64 end)
                        continue;
                printk(KERN_INFO "  early res: %d [%llx-%llx] %s\n", i,
                        final_start, final_end - 1, r->name);
-               reserve_bootmem_generic(final_start, final_end - final_start,
+               reserve_bootmem(final_start, final_end - final_start,
                                BOOTMEM_DEFAULT);
        }
 }

commit df10637c5d57c2c1b42aeb2233e00da9764fd873
Author: Ingo Molnar <mingo@elte.hu>
Date:   Mon Jun 9 15:05:26 2008 +0200

    x86: reserve highmem pages via reserve_early, fix

    fix:

    arch/x86/kernel/e820.c: In function 'early_res_to_bootmem':
    arch/x86/kernel/e820.c:639: error: too few arguments to function
'reserve_bootmem_generic'

    Signed-off-by: Ingo Molnar <mingo@elte.hu>

diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
index a706e90..a488bd0 100644
--- a/arch/x86/kernel/e820.c
+++ b/arch/x86/kernel/e820.c
@@ -635,12 +635,8 @@ void __init early_res_to_bootmem(u64 start, u64 end)
                        continue;
                printk(KERN_INFO "  early res: %d [%llx-%llx] %s\n", i,
                        final_start, final_end - 1, r->name);
-#ifdef CONFIG_X86_64
-               reserve_bootmem_generic(final_start, final_end - final_start);
-#else
-               reserve_bootmem(final_start, final_end - final_start,
+               reserve_bootmem_generic(final_start, final_end - final_start,
                                BOOTMEM_DEFAULT);
-#endif
        }
 }

             reply	other threads:[~2008-06-09 20:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-09 20:07 Yinghai Lu [this message]
2008-06-10  2:15 ` Yinghai Lu
2008-06-11  8:52   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86802c440806091307r3c4d5e77h12e22abfe578769f@mail.gmail.com \
    --to=yhlu.kernel@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®