Re: [PATCH 2/2] x86 boot: early_res_to_e820

["Yinghai Lu" <yhlu.kernel@gmail.com>]

On Thu, Jun 26, 2008 at 1:03 AM, Huang, Ying <ying.huang@intel.com> wrote:
> On Thu, 2008-06-26 at 00:29 -0700, Yinghai Lu wrote:
> [...]
>> >
>> > For example, if EFI memory map is allocated in highmem area by
>> > boot-loader, it need to be reserved in kernel. But on i386, bootmem can
>> > only reserve memory area below max_low_pfn. So I think this is needed.
>> >
>> > In general, I think it is needed to provide a reservation mechanism for
>> > highmem area on i386. Because some memory area from BIOS or boot-loader
>> > may in highmem area.
>>
>> I mean call reserve_setup_data right after finish_e820_parsing,  and
>> it could call e820_update_range directly.
>
> e820_update_range() can only be used after finish_e820_parsing()?

you could call that just after setup_memory_map

>
> parse_setup_data() should be called before parse_early_param() to let
> early_param override settings in setup_data. Which is before
> finish_e820_parsing(). It seems a little wired to use the data before
> reserve it.

that is ok, because no one use find_e820_area yet and e820 is a static
array. so it is safe.

>
> And this means find_e820_area() should not be called before
> e820_update_range()?

Yes.. no one use it....first user is supposed for bootmap?

YH