From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "David Brownell" <david-b@pacbell.net>
Cc: gregkh@suse.de, mingo@elte.hu, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] usb: don't hide bios bug warning
Date: Sat, 26 Jul 2008 20:24:53 -0700 [thread overview]
Message-ID: <86802c440807262024x56ea8defpabcc70f66b27baf9@mail.gmail.com> (raw)
In-Reply-To: <20080727015633.479B228C8F1@adsl-69-226-248-13.dsl.pltn13.pacbell.net>
On Sat, Jul 26, 2008 at 6:56 PM, David Brownell <david-b@pacbell.net> wrote:
>> >> - dev_warn(&pdev->dev, "EHCI: BIOS handoff failed"
>> >> + dev_printk(KERN_WARNING, &pdev->dev,
>> >> + "EHCI: BIOS handoff failed"
>> >
>> > This is the exact same thing, no change.
>> >
>> > confused,
>>
>> end user will not set CONFIG_USB_DEBUG, so that dev_warn will do nothing.
>
> Yes it does ... KERN_WARNING != KERN_DEBUG, and it's the latter
> which is toggled (via DEBUG) by CONFIG_USB_DEBUG...
you are right,
please forget about the patch.
YH
prev parent reply other threads:[~2008-07-27 3:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-27 1:12 Yinghai Lu
2008-07-27 1:24 ` Greg KH
2008-07-27 1:48 ` Yinghai Lu
2008-07-27 1:56 ` David Brownell
2008-07-27 3:24 ` Yinghai Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440807262024x56ea8defpabcc70f66b27baf9@mail.gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®