From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Alan Cox" <alan@lxorguk.ukuu.org.uk>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
"Ingo Molnar" <mingo@elte.hu>,
"Thomas Gleixner" <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"Dhaval Giani" <dhaval@linux.vnet.ibm.com>,
"Mike Travis" <travis@sgi.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 21/25] serial: change remove NR_IRQS in 8250.c v2
Date: Mon, 4 Aug 2008 11:13:36 -0700 [thread overview]
Message-ID: <86802c440808041113i77ad39b6of5b84e36e6bed830@mail.gmail.com> (raw)
In-Reply-To: <20080804151734.0d82fbe9@lxorguk.ukuu.org.uk>
On Mon, Aug 4, 2008 at 7:17 AM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>> Would allow us to use the generic hash table code.
>
> Nice.. that makes the code a bit longer in source form but much clearer
> and sharing common design.
>
>> Looks like we can also tweak serial_do_unlink to free irq_info when
>> the list goes empty, so we don't have a leak if the driver is ever
>> unloaded.
>
> Like this (again not yet tested)
>
> 8250: Remove NR_IRQ usage
>
> From: Alan Cox <alan@redhat.com>
>
>
> ---
>
> drivers/serial/68328serial.c | 11 +------
> drivers/serial/8250.c | 68 +++++++++++++++++++++++++++++++++---------
> 2 files changed, 56 insertions(+), 23 deletions(-)
>
thanks. will test it.
YH
next prev parent reply other threads:[~2008-08-04 18:19 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-03 2:59 [PATCH 00/25] dyn_array and nr_irqs support v3 Yinghai Lu
2008-08-03 2:59 ` [PATCH 01/25] x86: 64bit support more than 256 irq v2 Yinghai Lu
2008-08-03 2:59 ` [PATCH 02/25] x86: remove irq_vectors_limits Yinghai Lu
2008-08-03 2:59 ` [PATCH 03/25] add dyn_array support Yinghai Lu
2008-08-03 2:59 ` [PATCH 04/25] add per_cpu_dyn_array support Yinghai Lu
2008-08-03 2:59 ` [PATCH 05/25] x86: alloc dyn_array all alltogether Yinghai Lu
2008-08-03 2:59 ` [PATCH 06/25] x86: enable dyn_array support Yinghai Lu
2008-08-03 2:59 ` [PATCH 07/25] introduce nr_irqs Yinghai Lu
2008-08-03 2:59 ` [PATCH 08/25] x86: using nr_irqs Yinghai Lu
2008-08-03 2:59 ` [PATCH 09/25] drivers/char to use nr_irqs Yinghai Lu
2008-08-03 2:59 ` [PATCH 10/25] drivers/net " Yinghai Lu
2008-08-03 2:59 ` [PATCH 11/25] drivers intr remapping " Yinghai Lu
2008-08-03 2:59 ` [PATCH 12/25] drivers/pcmcia " Yinghai Lu
2008-08-03 2:59 ` [PATCH 13/25] drivers/rtc " Yinghai Lu
2008-08-03 2:59 ` [PATCH 14/25] drivers/scsi " Yinghai Lu
2008-08-03 2:59 ` [PATCH 15/25] drivers/serial " Yinghai Lu
2008-08-03 2:59 ` [PATCH 16/25] drivers proc " Yinghai Lu
2008-08-03 2:59 ` [PATCH 17/25] drivers xen events " Yinghai Lu
2008-08-03 2:59 ` [PATCH 18/25] make irq_timer_state to use dyn_array Yinghai Lu
2008-08-03 2:59 ` [PATCH 19/25] make irq2_iommu " Yinghai Lu
2008-08-03 2:59 ` [PATCH 20/25] make irq_desc " Yinghai Lu
2008-08-03 2:59 ` [PATCH 21/25] serial: change remove NR_IRQS in 8250.c v2 Yinghai Lu
2008-08-03 2:59 ` [PATCH 22/25] irq: make irqs in kernel stat use per_cpu_dyn_array Yinghai Lu
2008-08-03 2:59 ` [PATCH 23/25] x86: use dyn_array in io_apic_xx.c Yinghai Lu
2008-08-03 2:59 ` [PATCH 24/25] x86: get mp_irqs from madt Yinghai Lu
2008-08-03 2:59 ` [PATCH 25/25] x86: remove nr_irq_vectors Yinghai Lu
2008-08-03 13:03 ` [PATCH 21/25] serial: change remove NR_IRQS in 8250.c v2 Alan Cox
2008-08-03 15:14 ` Alan Cox
2008-08-03 19:57 ` Eric W. Biederman
2008-08-04 14:17 ` Alan Cox
2008-08-04 18:13 ` Yinghai Lu [this message]
2008-08-04 18:51 ` Eric W. Biederman
2008-08-06 13:09 ` [PATCH] serial: Remove NR_IRQS usage Alan Cox
2008-08-06 16:10 ` Eric W. Biederman
2008-08-03 13:02 ` [PATCH 15/25] drivers/serial to use nr_irqs Alan Cox
2008-08-03 17:43 ` Yinghai Lu
2008-08-03 4:16 ` [PATCH 05/25] x86: alloc dyn_array all alltogether Johannes Weiner
2008-08-03 4:03 ` [PATCH 03/25] add dyn_array support Johannes Weiner
2008-08-03 4:21 ` Yinghai Lu
2008-08-03 4:55 ` Johannes Weiner
2008-08-03 5:04 ` Yinghai Lu
2008-08-03 5:31 ` Johannes Weiner
2008-08-03 5:39 ` Yinghai Lu
2008-08-03 5:40 ` Yinghai Lu
2008-08-03 5:47 ` Johannes Weiner
2008-08-03 5:48 ` Yinghai Lu
2008-08-03 5:51 ` [PATCH 00/25] dyn_array and nr_irqs support v3 Eric W. Biederman
2008-08-03 6:04 ` Yinghai Lu
2008-08-03 6:39 ` Eric W. Biederman
2008-08-03 8:25 ` Yinghai Lu
2008-08-03 9:15 ` Eric W. Biederman
2008-08-03 17:54 ` Yinghai Lu
2008-08-03 19:20 ` Yinghai Lu
2008-08-04 1:59 ` Yinghai Lu
2008-08-04 14:31 ` Mike Travis
2008-08-05 23:01 ` H. Peter Anvin
2008-08-05 23:15 ` Yinghai Lu
2008-08-05 23:26 ` H. Peter Anvin
2008-08-05 23:53 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440808041113i77ad39b6of5b84e36e6bed830@mail.gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dhaval@linux.vnet.ibm.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®